Re: [Test] MYFACESTEST50 : Review

2011-05-27 Thread Rudy De Busscher
hi All, There was a small piece missing in the TestPerClassLoader (see https://issues.apache.org/jira/browse/MYFACESTEST-54) to make it completely functional for MyFaces core. In attachment the patch for MyFaces core to use the TestPerClassLoader for the test class FactoryFinderProviderTest if

Re: [Test] MYFACESTEST50 : Review

2011-05-26 Thread Rudy De Busscher
Leonardo, Thx for your input. It is indeed probably better to just copy the excluded.properties file to the test20 codebase then adding a lot of not very readable stuff in the pom.xml. The contents of the file will probably never change. About the FactoryFinderProviderTest, i'll have a look at

Re: [Test] MYFACESTEST50 : Review

2011-05-24 Thread Leonardo Uribe
Hi Rudy I don't think it could be any side effect caused by the change. The working setup in test20 just copy all java source files from test12 that does not have an alternate in test20. So I think the best in this case is just copy excluded.properties to test20 codebase. Feel free to do the

[Test] MYFACESTEST50 : Review

2011-05-23 Thread Rudy De Busscher
@All, Matt Benson identified that the file *excluded.properties*, required for the TestPerClassLoaderRunner to function, isn't packaged in the test20.jar. I verified his fix to the pom.xml file by copying the test cases we have for TestPerClassLoaderRunner from test12 to test20. (see the second