Re: [core] move or add integration tests to myfaces 2.1.x (now trunk)

2011-08-03 Thread Jakob Korherr
Hi, The reasons I put the integration tests module as a submodule directly into myfaces core was that 1) if you checkout core, you get the whole integration-testing stuff too (like in every maven-plugin project where the integration-tests are in src/it/) 2) the sub-module can be added via

Re: [core] move or add integration tests to myfaces 2.1.x (now trunk)

2011-07-29 Thread Jakob Korherr
Hi, I would like to do it exactly like we did it in MyFaces-Test, however not exactly like you're proposing. As you said, MyFaces-Test keeps the most code in the 1.2 module and the 2.0 module just takes what it needs. But what you're proposing is to move all integration-tests to 2.1 and also run

Re: [core] move or add integration tests to myfaces 2.1.x (now trunk)

2011-07-29 Thread Gerhard Petracek
@jakob: +1 regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/7/29 Jakob Korherr jakob.korh...@gmail.com Hi, I would like to do it exactly like we did it in MyFaces-Test,

Re: [core] move or add integration tests to myfaces 2.1.x (now trunk)

2011-07-29 Thread Leonardo Uribe
Hi I think there are many ways to do it. For example, you can play with source paths and maven profiles. For example the following code is valid: profiles profile idtests-jsf-21/id activation property namejsf/name value21/value /property

Re: [core] move or add integration tests to myfaces 2.1.x (now trunk)

2011-07-29 Thread Gerhard Petracek
imo we should keep it simple. #1 it should be as simple as possible to execute the tests #2 tests for the jsf api should be executed with the first possible version as well as all later versions (e.g. 2.0.2 - 2.1.0+ - 2.2.0+ ...). a solution which meets both will get my +1 regards, gerhard

[core] move or add integration tests to myfaces 2.1.x (now trunk)

2011-07-28 Thread Leonardo Uribe
Hi Some weeks ago a new module for integration test was added. See. https://issues.apache.org/jira/browse/MYFACES-3217 The code proposed was committed on 2.0.x branch. In the following mail we'll discuss if we should move this to current trunk (2.1.x) or create and maintain two copies: one in