[ 
https://issues.apache.org/jira/browse/TRINIDAD-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629749#comment-13629749
 ] 

Jeanne Waldman edited comment on TRINIDAD-2377 at 4/16/13 5:48 PM:
-------------------------------------------------------------------

outputFormatted splits the characters, so we are getting the high surrogate, 
but not the low surrogate in HTMLEscapes. See FormattedTextParser.
I have a patch where I remove the IllegalArgumentException in HTMLEscapes and 
only increase 'i' if the surrogate is valid. I still write out the character.

The remaining issue is surrogate chars still shown as garbled in Firefox but
only in outputFormatted. It should be good in IE. So there is no regression. We 
will need to log a new issue for this remaining issue.
                
      was (Author: jeanne.wald...@oracle.com):
    outputFormatted splits the characters, so we are getting the high 
surrogate, but not the low surrogate in HTMLEscapes. See FormattedTextParser.
I have a patch where I remove the IllegalArgumentException in HTMLEscapes, and 
in this case
I log a fine message, and continue parsing as it used to do.

The remaining issue is surrogate chars still shown as garbled in Firefox but
only in outputFormatted. It should be good in IE. So there is no regression.
                  
> surrogate characters in outputFormatted throws IllegalArgumentException
> -----------------------------------------------------------------------
>
>                 Key: TRINIDAD-2377
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2377
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>            Reporter: Jeanne Waldman
>            Assignee: Jeanne Waldman
>
> <af:outputFormatted value="#{TestInput.surrogateVal}" id="of1"/> 
> where
> TestInput.surrogateValue is a surrogateValue, like
>   private String surrogateVal = "\ud840\udc00";
>   public void setSurrogateVal(String surrogateVal) {
>       this.surrogateVal = surrogateVal;
>   }
>   public String getSurrogateVal() {
>       return surrogateVal;
> The page shows up blank, and you get an IllegalArgumentException from 
> HTMLEscapes. outputText works fine. This is a regression caused by 
> MYFACES-3690 Trinidad doesn't support surrogate characters

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to