[
https://issues.apache.org/jira/browse/MYFACES-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787988#comment-13787988
]
Leonardo Uribe commented on MYFACES-3798:
-----------------------------------------
Recreate the unmodifiable map is not necessary. It is just a wrapper applying
delegation pattern over the real one, so it does not have sense to recreate it
because there is an internal one that is the one who is holding the values and
dealing with the concurrency. The wrapper will always be the same.
The implementation done is spec compliant, and the current implementation works
well, at least for the test cases (unless the opposite can be proven).
> protected-view handling is broken
> ---------------------------------
>
> Key: MYFACES-3798
> URL: https://issues.apache.org/jira/browse/MYFACES-3798
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-344
> Affects Versions: 2.2.0
> Reporter: Gerhard Petracek
> Assignee: Leonardo Uribe
>
> the result of ViewHandlerImpl#getProtectedViewsUnmodifiable isn't spec.
> compliant.
> addProtectedView and removeProtectedView don't recreate
> _unmodifiableProtectedViewsSet. at the end of both we need:
> _unmodifiableProtectedViewsSet =
> Collections.unmodifiableSet(_protectedViewsSet);
> or we always return Collections.unmodifiableSet(_protectedViewsSet); in
> ViewHandlerImpl#getProtectedViewsUnmodifiable
--
This message was sent by Atlassian JIRA
(v6.1#6144)
