Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-08-16 Thread Martin Marinschek
Hi Harry, can you tell me what you're trying to do - with a code snippet? regards, Martin On 8/14/06, Harry Co (JIRA) dev@myfaces.apache.org wrote: [ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12427928 ] Harry Co commented on MYFACES-1110:

[jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-08-14 Thread Harry Co (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12427928 ] Harry Co commented on MYFACES-1110: --- Hi Martin, I'm facing the same issue using my-faces 1.1.3. Is thios definitely fixed in a release or do I need a patch?

[jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-04-22 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12375838 ] Martin Marinschek commented on MYFACES-1110: Hi Dave, my fix for this kind of things was in definitely after 1/15. regards, Martin findComponent return

[jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-18 Thread Dave (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12366926 ] Dave commented on MYFACES-1110: --- I tried before/after PhaseId.ANY_PHASE the findComponent() always return null. findComponent return null for a valid clientId

[jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-18 Thread Dave (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12366927 ] Dave commented on MYFACES-1110: --- I am using nigtly build 1/15/06. findComponent return null for a valid clientId --

Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-12 Thread Martin Marinschek
Yes - but I extended the findComponent concept for data table to allow scoped id's with a row-identifier included, so this is now much the same as a client-id, except if the renderer does a conversion. So what Dave wants ought to work. In the latest nightly build and several before them.

Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-12 Thread Jacob Hookom
But doesn't that break spec? Are you returning the UIComponent itself or some proxy instance? Martin Marinschek wrote: Yes - but I extended the findComponent concept for data table to allow scoped id's with a row-identifier included, so this is now much the same as a client-id, except if the

Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-12 Thread Martin Marinschek
Some proxy instance. It can't break the spec, cause it's only implemented in t:dataTable's findComponent method. regards, Martin On 2/12/06, Jacob Hookom [EMAIL PROTECTED] wrote: But doesn't that break spec? Are you returning the UIComponent itself or some proxy instance? Martin

Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-12 Thread Jacob Hookom
The reason why I ask is that we are trying to correct this for JSF 1.2, and I'd like to know if you've come up with an alternate, working solution. Example: UIComponent cA = root.findComponent(_id0:mytable:4:text); UIComponent cB = root.findComponent(_id0:mytable:9:text); cA.encodeAll(faces);

Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-12 Thread Martin Marinschek
Well, I don't know if you remember the last part of the discussion you, Adam, Manfred and me had on this topic. If you remember I originally wanted to have something like a visitComponent(). Now this is only possible with a spec-change - so I took your original approach of creating a

Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-12 Thread Jacob Hookom
Thanks Martin, So your feelings are that the API would be better served with being able to explicitly pass a visitor or callback to a visitComponent? -- Jacob Martin Marinschek wrote: Well, I don't know if you remember the last part of the discussion you, Adam, Manfred and me had on this

Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-12 Thread Martin Marinschek
Yeah. that would be my feeling. You treat the component much more like the blackbox it is with that. regards, Martin On 2/12/06, Jacob Hookom [EMAIL PROTECTED] wrote: Thanks Martin, So your feelings are that the API would be better served with being able to explicitly pass a visitor or

Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-12 Thread Jacob Hookom
Thanks Martin! Martin Marinschek wrote: Yeah. that would be my feeling. You treat the component much more like the blackbox it is with that. regards, Martin On 2/12/06, Jacob Hookom [EMAIL PROTECTED] wrote: Thanks Martin, So your feelings are that the API would be better served with

[jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-11 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12366012 ] Martin Marinschek commented on MYFACES-1110: Try to switch over to t:dataTable. I implemented a new version of findComponent for this kind of problems.

[jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-11 Thread Dave (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12366020 ] Dave commented on MYFACES-1110: --- I was using t:dataTable. I just realized that the clientId for components in a dataTable has row number (e.g., 1 in the example above), it

[jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-11 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12366049 ] Martin Marinschek commented on MYFACES-1110: Hmmm... yes, you should be able to search from the view-root no problem. Can you debug a little through

[jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-11 Thread Dave (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12366055 ] Dave commented on MYFACES-1110: --- Do you remember which nightly build that might have the fix? I would like to give it a test. Thanks! findComponent return null for a valid

[jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-11 Thread Dennis Byrne (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12366060 ] Dennis Byrne commented on MYFACES-1110: --- If this is beforePhase for the restore view phase, then findComponent() should be returning null. Are you getting this for

Re: [jira] Commented: (MYFACES-1110) findComponent return null for a valid clientId

2006-02-11 Thread Jacob Hookom
findComponent has nothing to do with client ids. They work off of different logic. Martin Marinschek (JIRA) wrote: [ http://issues.apache.org/jira/browse/MYFACES-1110?page=comments#action_12366049 ] Martin Marinschek commented on MYFACES-1110: