Most components 'overuse' encodeEnd
-----------------------------------

         Key: MYFACES-659
         URL: http://issues.apache.org/jira/browse/MYFACES-659
     Project: MyFaces
        Type: Improvement
  Components: Implementation  
    Versions: 1.1.0    
    Reporter: Thomas Timbul


Most of the component rendering implementations make use only of the encodeEnd 
method.

If this is the case, why do encodeBegin and encodeChildren exist in the first 
place?

I believe that encodeBegin should be used to validate parameters and children 
prerequisites, prepare the component for rendering (e.g computing a model or 
something), and rendering the start tag(s), encodeChildren should take care of 
any child components (i.e. the actual body) and encodeEnd should finish off by 
closing the tags opened in encodeBegin.

Yes, this will create an overhead for sharing data between the methods, but it 
would make the operations clearer (intutitive method names?)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to