ExternalContext encodeAction/resource URL should only unXML encode URLs that aren't XML encoded -----------------------------------------------------------------------------------------------
Key: PORTLETBRIDGE-109 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-109 Project: MyFaces Portlet Bridge Issue Type: Bug Components: Impl Affects Versions: 2.0.0-alpha, 1.0.0-beta Reporter: Michael Freedman Assignee: Michael Freedman When the bridge relies on the underlying portlet container to construct the URL returned from encodeActionURL/encodeResourceURL is always unXML encodes the URl prior to return (i.e. it replaces & with &) this is done because it found renderkits sometimes/often did there own XML encoding on the result (as they don't expect these functions to do this. By doing the unencode we worked around incorrectly double encoding. A better strategy is to look at the URL that is past in to these methods. If the URL isn't XML encoded then we should continue to decode at the end of the method (assuming the renderkit wil do any post encoding that is needed. However if it is already encoded then we should skip the decode as its more likely the renderkit has already done its encoding (or else it will double encode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.