Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-05-21 Thread Max Starets
Hey Leonardo, You are right - the same issue reproduces with two nested ui:composition templates. I logged the following Mojarra issue for the problem: https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1684 I do not think we have to abandon the idea of using TemplateClient

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-05-20 Thread Andy Schwartz
Hey Leonardo - Thanks for giving this a go and for sharing your findings! I am still hopeful that we can make something along these lines work. I will try to take a look at your patch to see if I have any ideas. (Though have other things I need to take care of first - so may be a few days

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-05-19 Thread Andy Schwartz
Leonardo - Thanks for this detailed analysis - lots of good information here. I've been meaning to follow up on this for some time now. Better late than never I guess. :-) My thoughts inline below... On 3/17/10 9:10 PM, Leonardo Uribe wrote: Actually the event publishing conditions of

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-05-19 Thread Leonardo Uribe
Hi I tried the proposal of use some variation of TemplateClient API (I attach it as reference on MYFACES-2638-6.patch ). The solution works for simple cases, but it does not when nested composite components are used. Look this example (I removed the non relevant code):

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-05-18 Thread Leonardo Uribe
Hi 2010/5/18 Andy Schwartz andy.schwa...@oracle.com Leonardo - Thanks for this detailed analysis - lots of good information here. I've been meaning to follow up on this for some time now. Better late than never I guess. :-) My thoughts inline below... On 3/17/10 9:10 PM, Leonardo

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-03-31 Thread Leonardo Uribe
Hi On this link: https://issues.apache.org/jira/browse/MYFACES-2638 attachment: MYFACES-2638-3.patch I attached a proposal to fix this issue, based on myfaces code. The idea is create a event called javax.faces.event.PostBuildRefreshViewEvent. This event is quite different from the one

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-03-31 Thread Leonardo Uribe
Hi Ok, the spec issue is this one: https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=782 regards, Leonardo Uribe 2010/3/31 Leonardo Uribe lu4...@gmail.com Hi On this link: https://issues.apache.org/jira/browse/MYFACES-2638 attachment: MYFACES-2638-3.patch I

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-03-30 Thread Martin Marinschek
Hi, - Create a new event (let's call it PostBuildViewEvent for the moment), that is propagated every time the view is build (when it is created, restored or refreshed before render response). h:outputScript, h:outputStylesheet, cc:insertChildren and cc:insertFacet should add a listener for

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-03-30 Thread Leonardo Uribe
Hi Martin In theory the secod event (PreRemoveFromViewEvent) should not be called when the view is refreshed. The important for me at this point is make clear the problem, but in this point I think the better is do a prototype with myfaces. It will take some time, but as soon as I have something

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-03-29 Thread Martin Marinschek
Now, the instants of time where PostAddToViewEvent is published are: - With Partial State Saving enabled    * When the view is build at first time.    * In a postback when the view is build but before the state of the component is restored. - With Partial State Saving disabled    *

Re: [jsr-314-open] PostAddToViewEvent publishing conditions

2010-03-29 Thread Leonardo Uribe
2010/3/29 Martin Marinschek mmarinsc...@apache.org Now, the instants of time where PostAddToViewEvent is published are: - With Partial State Saving enabled * When the view is build at first time. * In a postback when the view is build but before the state of the component is

[jsr-314-open] PostAddToViewEvent publishing conditions

2010-03-17 Thread Leonardo Uribe
Actually the event publishing conditions of PostAddToViewEvent/PreRemoveFromViewEvent are not very clear. These conditions depends if partial state saving is used or not and if facelets updates the view or not. The problem is this fact is not very intuitive, so for write code correctly the user