MYFACES-3063 - code cleanup and performance review

2015-09-21 Thread Thomas Andraschko
Hi, i would take care of this ticket. I would inspect our trunk with findbugs performance rules and fix them. The most are something like: lastIndexOf(".") -> lastIndexOf('.') new Integer(val) -> Integer.valueOf(val) and some more. Findbugs will also warn about unused private methods. Should we r

Re: MYFACES-3063 - code cleanup and performance review

2015-09-22 Thread Thomas Andraschko
Not sure, i just started findbugs via netbeans on my local machine :) 2015-09-22 9:46 GMT+02:00 Dennis Kieselhorst : > Hi, > > good idea. Does anyone know where to find our Sonar results? I couldn't > find anything (except CODI) on https://analysis.apache.org. > > We should create a ticket as des

Re: MYFACES-3063 - code cleanup and performance review

2015-09-22 Thread Dennis Kieselhorst
Hi, good idea. Does anyone know where to find our Sonar results? I couldn't find anything (except CODI) on https://analysis.apache.org. We should create a ticket as described in https://wiki.apache.org/general/SonarInstance so that we are able to compare the results before and after the cleanup.

Re: MYFACES-3063 - code cleanup and performance review

2015-09-22 Thread Thomas Andraschko
Created a issue for sonar setup: https://issues.apache.org/jira/browse/INFRA-10477 I will come back if everything is working fine. 2015-09-22 9:48 GMT+02:00 Thomas Andraschko : > Not sure, i just started findbugs via netbeans on my local machine :) > > 2015-09-22 9:46 GMT+02:00 Dennis Kieselhors

Re: MYFACES-3063 - code cleanup and performance review

2015-10-28 Thread Thomas Andraschko
Done: https://analysis.apache.org/dashboard/index/org.apache.myfaces.core:myfaces-core-module Will do the task now :) 2015-09-22 12:50 GMT+02:00 Thomas Andraschko : > Created a issue for sonar setup: > https://issues.apache.org/jira/browse/INFRA-10477 > > I will come back if everything is workin

[jira] Created: (MYFACES-3063) code cleanup and performance review

2011-03-09 Thread Mark Struberg (JIRA)
code cleanup and performance review Key: MYFACES-3063 URL: https://issues.apache.org/jira/browse/MYFACES-3063 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 2.0

[jira] [Resolved] (MYFACES-3063) code cleanup and performance review

2015-10-28 Thread Thomas Andraschko (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-3063. Resolution: Fixed > code cleanup and performance review > ---