Opinion on a possible page flow scope bug

2007-09-28 Thread Simon Lessard
Hi all, We have a client who played with page flow scope and bit and came to the following. Of course, the use case is extremely synthetic, but it's still strange: page.jspx f:view tr:document tr:form tr:inputText value=#{bean.value}/ tr:commandButton text=Go/ /tr:form

Re: Opinion on a possible page flow scope bug

2007-09-28 Thread Adam Winer
It's a long-standing problem with form URL encoding. If you don't add anything to pageFlowScope until Render Response, those objects will be lost, 'cause the token is written out on the form too early. We try to be conservative and not generate new pageFlowScopes unless its necessary. The

Re: Opinion on a possible page flow scope bug

2007-09-28 Thread Simon Lessard
Yeah, that's what we figured while playing with it, but it's not the most elegant solution. Maybe we should make that configurable in trinidad-config (not supporting EL)? Most users can probably deal with the issue so it should not save the scope by default when it's empty, but users needing it

Re: Opinion on a possible page flow scope bug

2007-09-28 Thread Adam Winer
Yeah, absolutely a hack. Option #2 that I can think of is caching the action URL at the start of the FormRenderer encoding, then re-querying it at the end. If it's changed, add Javascript to find the form and overwrite the action. Also gross, but at least it's not as bad as adding a