Re: proposed API change on ChangeManager

2010-04-13 Thread Yuan Gao
hi, Simon, Thanks for the vote. Please see my comments inline. On 4/9/2010 8:01 PM, Simon Lessard wrote: +0, see below for the why. Blake, Let see if I understand the issue correctly. We have: - Detect a row key change (can happen if the rowKey is the PK and the PK changes during the

Re: proposed API change on ChangeManager

2010-04-09 Thread Yuan Gao
hi, Simon, Thanks for the comments. I still feel it's better to have the client code explicitly say replace...() since it's more clear. On the other way if you wrap all your logic in one single API and controls the logic by pass in parameters, it's gonna create a hard time for people who read

[trinidad][api]Re: proposed API change on ChangeManager

2010-04-09 Thread Blake Sullivan
Resending with better subject so that the chain doesn't get filtered out. -- Blake Sullivan Blake Sullivan said the following On 4/9/2010 4:17 PM PT: Simon, The use case is this: Say I have a table with a selectedRowKeys attribute that contains the identifiers for the currently selected

Re: proposed API change on ChangeManager

2010-04-09 Thread Blake Sullivan
Simon, The use case is this: Say I have a table with a selectedRowKeys attribute that contains the identifiers for the currently selected rows. If my application allows a row key to change (perhaps during creation or because the application actually allows the fields that make up the

Re: proposed API change on ChangeManager

2010-04-09 Thread Simon Lessard
+0, see below for the why. Blake, Let see if I understand the issue correctly. We have: - Detect a row key change (can happen if the rowKey is the PK and the PK changes during the request processing). See 1) 2) below please - Now, if the selectedRowKeys attribute, or any other attribute with

Re: [Trinidad] proposed API change on ChangeManager

2010-04-08 Thread Matthias Wessendorf
looks OK +1 On Wed, Apr 7, 2010 at 11:29 PM, Gabrielle Crawford gabrielle.crawf...@oracle.com wrote: adding Trinidad to the subject Yuan Gao wrote: hi, For JIRA 1761 (https://issues.apache.org/jira/browse/TRINIDAD-1761), we propose to add this API to the ChangeManager interface:  /**  

proposed API change on ChangeManager

2010-04-07 Thread Yuan Gao
hi, For JIRA 1761 (https://issues.apache.org/jira/browse/TRINIDAD-1761), we propose to add this API to the ChangeManager interface: /** * Replace an AttributeComponentChange if it's present. * * @param facesContext * @param uiComponent * @param attributeComponentChange *

[Trinidad] proposed API change on ChangeManager

2010-04-07 Thread Gabrielle Crawford
adding Trinidad to the subject Yuan Gao wrote: hi, For JIRA 1761 (https://issues.apache.org/jira/browse/TRINIDAD-1761), we propose to add this API to the ChangeManager interface: /** * Replace an AttributeComponentChange if it's present. * * @param facesContext * @param