Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Martin Marinschek
Hi guys, let me weigh in on the filter question: please, no filter! @prefix suffix mappings: you can get the registered mappings in previous servlet versions: parsing the web.xml in servlet 3.0: via the API http://download.oracle.com/javaee/6/api/javax/servlet/ServletRegistration.html the

Re: [codi] first steps for the next release

2011-06-30 Thread Rudy De Busscher
I'll try to review today and tomorrow the last pieces of the docs (wiki). Sorry for the delay. Regards Rudy. On 30 June 2011 01:57, Leonardo Uribe lu4...@gmail.com wrote: +1. sounds good 2011/6/29 Gerhard Petracek gerhard.petra...@gmail.com: hi @ all, if there are no objections, i'll

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Jakob Korherr
Hi Martin, Thank you so much for your mail! This is exactly my point of view about the ResourceHandler. However, Leonardo in I kinda got into a fight about it and unfortunately, I do not have time for that right now! Leonardo, please reconsider my reasoning from the previous mails of this

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
Hi 2011/6/30 Martin Marinschek mmarinsc...@apache.org: Hi guys, let me weigh in on the filter question: please, no filter! @prefix suffix mappings: you can get the registered mappings in previous servlet versions: parsing the web.xml in servlet 3.0: via the API

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
Hi Jakob 2011/6/30 Jakob Korherr jakob.korh...@gmail.com: Hi Martin, Thank you so much for your mail! This is exactly my point of view about the ResourceHandler. However, Leonardo in I kinda got into a fight about it and unfortunately, I do not have time for that right now! For me this is

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Jakob Korherr
[...] The new alternative proposed is similar. This alternative is not new! My first version of the AdvancedResourceHandler (before you started committing) already did exactly this! (However, assuming /faces/* as mapping if the page was accessed via suffix mapping, but making it configurable

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
2011/6/30 Jakob Korherr jakob.korh...@gmail.com: [...] The new alternative proposed is similar. This alternative is not new! My first version of the AdvancedResourceHandler (before you started committing) already did exactly this! (However, assuming /faces/* as mapping if the page was

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Jakob Korherr
Hm, you're not getting it. This To do it correctly we need to detect if this is a servlet 3.0 container and do the necessary stuff, but we need to test what happen if a 2.5 or 2.4 web.xml file is deployed on a 3.0 container. Additionally, we need to take care about do not call 3.0 code in 2.5

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
2011/6/30 Jakob Korherr jakob.korh...@gmail.com: Hm, you're not getting it. This To do it correctly we need to detect if this is a servlet 3.0 container and do the necessary stuff, but we need to test what happen if a 2.5 or 2.4 web.xml file is deployed on a 3.0 container. Additionally, we

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Gerhard Petracek
hi @ all, what jakob is talking about makes a lot of sense to me. @jakob: please don't fork it. imo we should continue with the approach started by jakob + the addition mentioned by martin. after finishing that we can think about further improvements (if needed at all). @leo: do you feel we

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
2011/6/30 Gerhard Petracek gerhard.petra...@gmail.com: hi @ all, what jakob is talking about makes a lot of sense to me. @jakob: please don't fork it. imo we should continue with the approach started by jakob + the addition mentioned by martin. after finishing that we can think about

[jira] [Created] (MYFACES-3200) All values of self-defined composite-component attributes disappear unexpected.

2011-06-30 Thread Rene O (JIRA)
All values of self-defined composite-component attributes disappear unexpected. --- Key: MYFACES-3200 URL: https://issues.apache.org/jira/browse/MYFACES-3200 Project: MyFaces

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Gerhard Petracek
ok - so please start a vote about it. describe the topic and why you think something has to be changed (compared to the original commit in combination with the addition mentioned by martin). please write it very concisely! we won't get a lot of votes, if the description is too verbose. thx

[jira] [Commented] (MYFACES-3200) All values of self-defined composite-component attributes disappear unexpected.

2011-06-30 Thread Matt Benson (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057939#comment-13057939 ] Matt Benson commented on MYFACES-3200: -- Not sure what if anything richfaces is

[VOTE] how myfaces-commons-resourcehandler should work with suffix mapping enabled

2011-06-30 Thread Leonardo Uribe
Hi To reference images inside a css file in JSF 2.0, users have to change its code from this: .someclass { ... background-image:url('myimage.gif'); ... } to this: .someclass { ... background-image:url(#{resource['mylib:myimage.gif']}); ... } This means a lot of changes, including

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
Hi Ok, I already send it. I hope it is clear the problem we are discussing about. @Jakob: do you have any other issue related to the current implementation done in myfaces-commons-resourcehandler that we need to take a decision? regards, Leonardo Uribe 2011/6/30 Gerhard Petracek

[jira] [Commented] (MYFACES-3200) All values of self-defined composite-component attributes disappear unexpected.

2011-06-30 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058009#comment-13058009 ] Leonardo Uribe commented on MYFACES-3200: - Maybe this is caused by the commit

Re: [VOTE] how myfaces-commons-resourcehandler should work with suffix mapping enabled

2011-06-30 Thread Leonardo Uribe
+1 for 3. Option 4. doesn't cause any conflict, so we can just keep that code as is. 2011/6/30 Leonardo Uribe lu4...@gmail.com: Hi To reference images inside a css file in JSF 2.0, users have to change its code from this: .someclass { ...    background-image:url('myimage.gif'); ... }

[jira] [Created] (MYFACES-3201) Publish exception in lifecycle methods (process*) instead of re-thrown

2011-06-30 Thread JIRA
Publish exception in lifecycle methods (process*) instead of re-thrown -- Key: MYFACES-3201 URL: https://issues.apache.org/jira/browse/MYFACES-3201 Project: MyFaces Core

[jira] [Commented] (MYFACES-3201) Publish exception in lifecycle methods (process*) instead of re-thrown

2011-06-30 Thread JIRA
[ https://issues.apache.org/jira/browse/MYFACES-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058046#comment-13058046 ] Martin Kočí commented on MYFACES-3201: -- Please notice that proposed new behaviour

[jira] [Created] (MYFACES-3202) Improve EL Exceptions wrapping

2011-06-30 Thread JIRA
Improve EL Exceptions wrapping -- Key: MYFACES-3202 URL: https://issues.apache.org/jira/browse/MYFACES-3202 Project: MyFaces Core Issue Type: Sub-task Reporter: Martin Kočí Priority: Minor

[jira] [Commented] (MYFACES-3200) All values of self-defined composite-component attributes disappear unexpected.

2011-06-30 Thread Matt Benson (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058090#comment-13058090 ] Matt Benson commented on MYFACES-3200: -- Great! I was also going to say that yes,

[jira] [Commented] (MYFACES-3200) All values of self-defined composite-component attributes disappear unexpected.

2011-06-30 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058093#comment-13058093 ] Leonardo Uribe commented on MYFACES-3200: - Thanks for the example. It helped a

[jira] [Issue Comment Edited] (MYFACES-3200) All values of self-defined composite-component attributes disappear unexpected.

2011-06-30 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058093#comment-13058093 ] Leonardo Uribe edited comment on MYFACES-3200 at 6/30/11 9:40 PM:

[jira] [Resolved] (MYFACES-3200) All values of self-defined composite-component attributes disappear unexpected.

2011-06-30 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-3200. - Resolution: Fixed Fix Version/s: 2.1.2 2.0.8

[jira] [Commented] (MYFACES-3199) Handling AbortProcessingException is unconsistent

2011-06-30 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058141#comment-13058141 ] Leonardo Uribe commented on MYFACES-3199: - Problem 1: The spec javadoc is clear