Re: [VOTE] release of MyFaces Core 3.0.0

2021-01-19 Thread Volodymyr Siedlecki
Hello,There have been a few more updates to the 3.0.x branch.I will roll back the previous release and make a newer one.Thank you,   Volodymyr   - Original message -From: "Volodymyr Siedlecki" To: dev@myfaces.apache.orgCc:Subject: [EXTERNAL] [VOTE] release of MyFaces Core 3.0.0Date: Fri,

[GitHub] [myfaces] bohmber commented on pull request #153: Disable the parsing of external general entities and external paramet…

2021-01-19 Thread GitBox
bohmber commented on pull request #153: URL: https://github.com/apache/myfaces/pull/153#issuecomment-762957573 adding `setFeature( "http://apache.org/xml/features/disallow-doctype-decl;, true ); ` would break. The rest is from here

[GitHub] [myfaces] tandraschko commented on pull request #153: Disable the parsing of external general entities and external paramet…

2021-01-19 Thread GitBox
tandraschko commented on pull request #153: URL: https://github.com/apache/myfaces/pull/153#issuecomment-762924791 Could this break something? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [myfaces-tobago] henningn merged pull request #195: fix: jasmine tests

2021-01-19 Thread GitBox
henningn merged pull request #195: URL: https://github.com/apache/myfaces-tobago/pull/195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [myfaces-tobago] henningn merged pull request #194: fix: popup jasmine tests

2021-01-19 Thread GitBox
henningn merged pull request #194: URL: https://github.com/apache/myfaces-tobago/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [myfaces-tobago] henningn merged pull request #192: add comment for dropdown menu

2021-01-19 Thread GitBox
henningn merged pull request #192: URL: https://github.com/apache/myfaces-tobago/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [myfaces-tobago] henningn opened a new pull request #195: fix: jasmine tests

2021-01-19 Thread GitBox
henningn opened a new pull request #195: URL: https://github.com/apache/myfaces-tobago/pull/195 * change "not implemented yet" message to "must be fixed first" where it's appropriate This is an automated message from the

[GitHub] [myfaces] tandraschko edited a comment on pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
tandraschko edited a comment on pull request #152: URL: https://github.com/apache/myfaces/pull/152#issuecomment-762856879 somehow yes, in general its a completely cleaned-up 2.3, which i created as preperation for 4.0. Currently 4.0 equals 2.3-next, but with jakarta namespace and

[GitHub] [myfaces] tandraschko edited a comment on pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
tandraschko edited a comment on pull request #152: URL: https://github.com/apache/myfaces/pull/152#issuecomment-762856879 somehow yes, in general its a completely cleaned-up 2.3, which i created as preperation for 4.0. Currently 2.3-next equals 4.0, but with jakarta namespace and

[GitHub] [myfaces] tandraschko commented on pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
tandraschko commented on pull request #152: URL: https://github.com/apache/myfaces/pull/152#issuecomment-762856879 somehow yes, in general its a completely cleaned-up 2.3, which i created as preperation for 4.0. Currently 2.3-next equals 4.0, but with jakarta namespace and

[GitHub] [myfaces] bohmber commented on pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
bohmber commented on pull request #152: URL: https://github.com/apache/myfaces/pull/152#issuecomment-762854851 @tandraschko Is 2.3-next just a improved replacement for 2.3.x? If yes then I shouldn't apply the change to AES for 2.3-next

[jira] [Resolved] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page

2021-01-19 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4378. Resolution: Cannot Reproduce Will close it for now until we have a reproducer >

[jira] [Comment Edited] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page

2021-01-19 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267876#comment-17267876 ] Thomas Andraschko edited comment on MYFACES-4378 at 1/19/21, 1:18 PM:

[jira] [Commented] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page

2021-01-19 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267876#comment-17267876 ] Thomas Andraschko commented on MYFACES-4378: added unittest and even the reproducer sample

[GitHub] [myfaces] bohmber opened a new pull request #153: Disable the parsing of external general entities and external paramet…

2021-01-19 Thread GitBox
bohmber opened a new pull request #153: URL: https://github.com/apache/myfaces/pull/153 …er entities in XML parsing code MYFACES-4377 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [myfaces] tandraschko commented on pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
tandraschko commented on pull request #152: URL: https://github.com/apache/myfaces/pull/152#issuecomment-762807569 also dont forget the homepage This is an automated message from the Apache Git Service. To respond to the

[GitHub] [myfaces] bohmber merged pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
bohmber merged pull request #152: URL: https://github.com/apache/myfaces/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page

2021-01-19 Thread Thomas Andraschko (Jira)
Thomas Andraschko created MYFACES-4378: -- Summary: onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page Key: MYFACES-4378 URL:

[GitHub] [myfaces] bohmber commented on pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
bohmber commented on pull request #152: URL: https://github.com/apache/myfaces/pull/152#issuecomment-762798710 It's based on this https://github.com/apache/myfaces/security/code-scanning This is an automated message from the

[GitHub] [myfaces] tandraschko edited a comment on pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
tandraschko edited a comment on pull request #152: URL: https://github.com/apache/myfaces/pull/152#issuecomment-762795428 +1 if well tested, code looks fine please also add it to 2.3-next, thats the only version currently usable by Quarkus users and its the same codebase as 4.0

[GitHub] [myfaces] tandraschko commented on pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
tandraschko commented on pull request #152: URL: https://github.com/apache/myfaces/pull/152#issuecomment-762795428 +1 please also add it to 2.3-next, thats the only version currently usable by Quarkus users and its the same codebase as 4.0

[GitHub] [myfaces] tandraschko commented on pull request #146: Ci fixes 3.0.x

2021-01-19 Thread GitBox
tandraschko commented on pull request #146: URL: https://github.com/apache/myfaces/pull/146#issuecomment-762795234 please also add 2.3-next here, thats the only version currently usable by Quarkus users and its the same codebase as 4.0

[GitHub] [myfaces] bohmber opened a new pull request #152: MYFACES-4376

2021-01-19 Thread GitBox
bohmber opened a new pull request #152: URL: https://github.com/apache/myfaces/pull/152 Update Cryptographic algorithm in StateUtils to a stronger version This is an automated message from the Apache Git Service. To respond

[jira] [Created] (MYFACES-4377) Disable the parsing of external general entities and external parameter entities in XML parsing code

2021-01-19 Thread Bernd Bohmann (Jira)
Bernd Bohmann created MYFACES-4377: -- Summary: Disable the parsing of external general entities and external parameter entities in XML parsing code Key: MYFACES-4377 URL:

[jira] [Created] (MYFACES-4376) Update Cryptographic algorithm in StateUtils to a stronger version

2021-01-19 Thread Bernd Bohmann (Jira)
Bernd Bohmann created MYFACES-4376: -- Summary: Update Cryptographic algorithm in StateUtils to a stronger version Key: MYFACES-4376 URL: https://issues.apache.org/jira/browse/MYFACES-4376 Project:

[GitHub] [myfaces-tobago] henningn opened a new pull request #194: fix: popup jasmine tests

2021-01-19 Thread GitBox
henningn opened a new pull request #194: URL: https://github.com/apache/myfaces-tobago/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection

2021-01-19 Thread Jira
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267785#comment-17267785 ] Milan Siebenbürger commented on MYFACES-4375: - Thanks (y) > ResourceLoaderUtils -

[jira] [Commented] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection

2021-01-19 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267783#comment-17267783 ] Thomas Andraschko commented on MYFACES-4375: We may release something next month, but not

[jira] [Commented] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection

2021-01-19 Thread Jira
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267769#comment-17267769 ] Milan Siebenbürger commented on MYFACES-4375: - Confirming, everything is working fine,