werpu commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1301040923
> For the duplicates, I click the button twice which then add the script /
link elements each time. I saw Mojarra had map to avoid this problem. Could we
do the same?
Yes definitely,
volosied commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1301010056
For the duplicates, I click the button twice which then add the script /
link elements each time. I saw Mojarra had map to avoid this problem. Could
we do the same?
--
This is
werpu commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1300789844
> @werpu Thanks for working on this!
>
> I tested it out, and it's improved. However, I still see some odd behavior.
>
> * The CSS stylesheets are applied (i.e background color
volosied commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1300673807
@werpu Thanks for working on this!
I tested it out, and it's improved. However, I still see some odd behavior.
- The CSS stylesheets are applied (i.e background color changes),
Bug is fixed, I also added 3 unit tests to cover this part of the spec on
unit test level on our side.
Please test, if everything is ok we can start to merge.
Cheers and happy evening
Werner
Am Mi., 2. Nov. 2022 um 10:31 Uhr schrieb Werner Punz :
> HI I just got a small bug report in via a
werpu commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1300527603
I have fixed the reported resource processing, issue reported in
https://github.com/apache/myfaces/pull/356#issuecomment-1299148181
and also documented under
HI I just got a small bug report in via a comment, I must have missed this
morning (thanks for pointing me towards it)
I just need to fix this (it is a small protocol part which is rarely used
which needs implementation)
I also will add the missing test.
Once I am done with it I will wait a
Thanks Werner
please go ahead. I will do some testing in the next 2 weeks as well. I
think minor issues can be solved after the merge
Regards
Bernd
On Wed, Nov 2, 2022 at 9:35 AM Werner Punz wrote:
>
> Hello
>
> I am back from my vacation, following. In my opinion the code is ready for
>
werpu commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1299924085
> One item I found -- this code doesn't seem to handle
`jakarta.faces.Resource` in ajax responses Such as ``.
>
> Feel free to test spec1423.xhtml
>
>
werpu commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1299923553
Ok just saw the comment, I will fix the issue.
Thanks for the feedback and BBohman who pointed me towards it.
--
This is an automated message from the Apache Git Service.
To respond
Hello
I am back from my vacation, following. In my opinion the code is ready for
merge and the target has been RC3 which would be, now.
Given I still have one pending review, did anyone test already, are there
any objections to do so?
I just wanted to ask before I go ahead with it.
Werner
PS:
werpu commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1299803155
Hi guys, I would be ready for merge, now... please complete the review and
if you have objections please point them out for correction. If all goes well I
can wrap everything up this week.
12 matches
Mail list logo
