[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1430297468 @tandraschko Let me know what you think of the new changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Comment Edited] (MYFACES-4560) Faces Issue #1791 SelectItems rendering

2023-02-14 Thread Bernd Bohmann (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688597#comment-17688597 ] Bernd Bohmann edited comment on MYFACES-4560 at 2/14/23 7:55 PM: - I

[GitHub] [myfaces] volosied commented on a diff in pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
volosied commented on code in PR #520: URL: https://github.com/apache/myfaces/pull/520#discussion_r1106306711 ## impl/src/main/resources/META-INF/WebConfigParamsLogger.vm: ## @@ -34,88 +34,88 @@ public class WebConfigParamsLogger { private static final Logger log =

[GitHub] [myfaces] volosied commented on a diff in pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
volosied commented on code in PR #520: URL: https://github.com/apache/myfaces/pull/520#discussion_r1106298338 ## impl/src/main/resources/META-INF/WebConfigParamsLogger.vm: ## @@ -34,88 +34,88 @@ public class WebConfigParamsLogger { private static final Logger log =

[GitHub] [myfaces] volosied commented on a diff in pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
volosied commented on code in PR #520: URL: https://github.com/apache/myfaces/pull/520#discussion_r1106297878 ## impl/src/main/resources/META-INF/WebConfigParamsLogger.vm: ## @@ -129,7 +129,18 @@ public class WebConfigParamsLogger #end #end #end -} ## } + +

[jira] [Resolved] (TOBAGO-2179) New Select Component

2023-02-14 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2179. -- Fix Version/s: 5.6.0 (was: 5.x) Resolution: Fixed > New Select

[GitHub] [myfaces-tobago] henningn merged pull request #3767: refactor(cleanup): select[One/Many]List

2023-02-14 Thread via GitHub
henningn merged PR #3767: URL: https://github.com/apache/myfaces-tobago/pull/3767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] henningn merged pull request #3766: refactor(cleanup): select[One/Many]List

2023-02-14 Thread via GitHub
henningn merged PR #3766: URL: https://github.com/apache/myfaces-tobago/pull/3766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] henningn opened a new pull request, #3767: refactor(cleanup): select[One/Many]List

2023-02-14 Thread via GitHub
henningn opened a new pull request, #3767: URL: https://github.com/apache/myfaces-tobago/pull/3767 * make some functions private -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [myfaces-tobago] henningn opened a new pull request, #3766: refactor(cleanup): select[One/Many]List

2023-02-14 Thread via GitHub
henningn opened a new pull request, #3766: URL: https://github.com/apache/myfaces-tobago/pull/3766 * make some functions private -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (MYFACES-4560) Faces Issue #1791 SelectItems rendering

2023-02-14 Thread Bernd Bohmann (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688597#comment-17688597 ] Bernd Bohmann commented on MYFACES-4560: I have a simple test to verify the wrong behavior    

[GitHub] [myfaces-tobago] henningn merged pull request #3765: chore: Tobago 5.x next version

2023-02-14 Thread via GitHub
henningn merged PR #3765: URL: https://github.com/apache/myfaces-tobago/pull/3765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MYFACES-4560) Faces Issue #1791 SelectItems rendering

2023-02-14 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688589#comment-17688589 ] Melloware commented on MYFACES-4560: Yes and that gets completely ignored and the underlying

[jira] [Comment Edited] (MYFACES-4560) Faces Issue #1791 SelectItems rendering

2023-02-14 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688589#comment-17688589 ] Melloware edited comment on MYFACES-4560 at 2/14/23 4:25 PM: - Yes and that

[jira] [Commented] (MYFACES-4560) Faces Issue #1791 SelectItems rendering

2023-02-14 Thread Bernd Bohmann (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688582#comment-17688582 ] Bernd Bohmann commented on MYFACES-4560: I think the description is not correct itemLabel for

[GitHub] [myfaces-tobago] henningn merged pull request #3763: refactor(cleanup): select[One/Many]List

2023-02-14 Thread via GitHub
henningn merged PR #3763: URL: https://github.com/apache/myfaces-tobago/pull/3763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] henningn merged pull request #3764: refactor(cleanup): select[One/Many]List

2023-02-14 Thread via GitHub
henningn merged PR #3764: URL: https://github.com/apache/myfaces-tobago/pull/3764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1429987506 I think I'm following you now. So here's the new behavior for these _info_ message: auto - logs in dev mode only (not prod) (fine messages still logged in prod when trace is

[GitHub] [myfaces] tandraschko commented on pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
tandraschko commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1429976901 i think we should not remove a "feature" and just default auto to dev stage only as default so people can decide how to configure -- This is an automated message from the Apache

[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1429970835 I can keep the new logging code as is, but undo my LOG_WEB_CONTEXT_PARAMS changes. Although, "auto" doesn't seem to make much sense since now it only applies to dev mode (true /

[jira] [Commented] (MYFACES-4560) Faces Issue #1791 SelectItems rendering

2023-02-14 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688555#comment-17688555 ] Melloware commented on MYFACES-4560: Yep we opened a discussion on the Faces Spec page here:

[jira] [Commented] (MYFACES-4560) Faces Issue #1791 SelectItems rendering

2023-02-14 Thread Bernd Bohmann (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688554#comment-17688554 ] Bernd Bohmann commented on MYFACES-4560: Is this a myfaces problem? > Faces Issue #1791

[GitHub] [myfaces] tandraschko commented on pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
tandraschko commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1429909788 why not just redefine LOG_WEB_CONTEXT_PARAMS_DEFAULT = "auto"; to "auto log in development stage"? false = never true = always -- This is an automated message

[jira] [Resolved] (TOBAGO-2195) SelectOneList / SelectManyList: filtered row may be preselected

2023-02-14 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2195. -- Fix Version/s: 5.5.1 Resolution: Fixed > SelectOneList / SelectManyList: filtered row

[GitHub] [myfaces-tobago] henningn merged pull request #3762: fix(select[One/Many]List): preselected row

2023-02-14 Thread via GitHub
henningn merged PR #3762: URL: https://github.com/apache/myfaces-tobago/pull/3762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] henningn merged pull request #3761: fix(select[One/Many]List): preselected row

2023-02-14 Thread via GitHub
henningn merged PR #3761: URL: https://github.com/apache/myfaces-tobago/pull/3761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (TOBAGO-2195) SelectOneList / SelectManyList: filtered row may be preselected

2023-02-14 Thread Jira
Henning Nöth created TOBAGO-2195: Summary: SelectOneList / SelectManyList: filtered row may be preselected Key: TOBAGO-2195 URL: https://issues.apache.org/jira/browse/TOBAGO-2195 Project: MyFaces

[GitHub] [myfaces-tobago] henningn merged pull request #3757: build(deps): bump dependency-check-maven from 8.0.2 to 8.1.0

2023-02-14 Thread via GitHub
henningn merged PR #3757: URL: https://github.com/apache/myfaces-tobago/pull/3757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] henningn merged pull request #3758: build(deps): bump dependency-check-maven from 8.0.2 to 8.1.0

2023-02-14 Thread via GitHub
henningn merged PR #3758: URL: https://github.com/apache/myfaces-tobago/pull/3758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] henningn merged pull request #3759: build(deps): bump dependency-check-maven from 8.0.2 to 8.1.0

2023-02-14 Thread via GitHub
henningn merged PR #3759: URL: https://github.com/apache/myfaces-tobago/pull/3759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] henningn merged pull request #3760: build(deps): bump dependency-check-maven from 8.0.2 to 8.1.0

2023-02-14 Thread via GitHub
henningn merged PR #3760: URL: https://github.com/apache/myfaces-tobago/pull/3760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (MYFACES-4560) Faces Issue #1791 SelectItems rendering

2023-02-14 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688360#comment-17688360 ] Thomas Andraschko edited comment on MYFACES-4560 at 2/14/23 8:24 AM:

[jira] [Commented] (MYFACES-4560) Faces Issue #1791 SelectItems rendering

2023-02-14 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688360#comment-17688360 ] Thomas Andraschko commented on MYFACES-4560: In PF we added it directly when creating the

[jira] [Resolved] (MYFACES-4562) ClientWindowScoped Not Destroyed / Lifecycle Clarification

2023-02-14 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4562. Resolution: Not A Problem > ClientWindowScoped Not Destroyed / Lifecycle

[jira] [Commented] (MYFACES-4562) ClientWindowScoped Not Destroyed / Lifecycle Clarification

2023-02-14 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688358#comment-17688358 ] Thomas Andraschko commented on MYFACES-4562: currently its only destroyed when the max size