Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied merged PR #675: URL: https://github.com/apache/myfaces/pull/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904825840 Oh yeah I tested 17 first. All working once I removed that `javax.validation` depenendency which was not needed. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904825706 It looks to work now with 17 ( new terminal). I guess something got messed up. Let me clean up the PR and we can merge -- This is an automated message from the Apache Git Service. To

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904822695 *head shake* Sorry, I mean 17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904821489 switching to 11 in Showcase pom.xml still works for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904814371 Thanks for looking at this. Can you also try again but with `11`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904774469 I just built your branch locally and its working for me now. ![image](https://github.com/apache/myfaces/assets/4399574/7e1360c5-b976-43a8-8902-3db97d4ff28a) -- This is an

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904765314 I just removed it i don't even think its needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904755648 In the Quarkus Showcase pom.xml shouldn't this be changed to Jakarta? ```xml javax.validation validation-api 2.0.1.Final

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462380480 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: let me take a look --

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462378661 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Correct -- 4.0 is still 11. 4.1 is now part of EE11 which requires

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462379648 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: Hmm -- I tried again and it

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462376946 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: LGTM! -- This is an

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462376233 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: Reverting this change make the

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462375420 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Nope i was just making sure 4.1 minimum version would be 17 now. I

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462374031 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Do you need Quarkus on Java 11? -- This is an automated message

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462373170 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: It would. -- This is an automated message from the Apache Git

Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]

2024-01-22 Thread via GitHub
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462372661 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Will this make 4.1 JDK 17 only for users? -- This is an

Re: [PR] 4.1.x: Support Java 17 & Depdency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904738198 @melloware @tandraschko I'm getting the following error. Could either of figure out why? ``` [INFO] --- [INFO] T E S T

[PR] 4.1.x: Support Java 17 & Depdency Updates [myfaces]

2024-01-22 Thread via GitHub
volosied opened a new pull request, #675: URL: https://github.com/apache/myfaces/pull/675 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[VOTE] Release Tobago 6.2.0 and Tobago 5.10.0

2024-01-22 Thread Henning Nöth
Hello, we would like to release: * Tobago 6.2.0 * Tobago 5.10.0 The artifacts were deployed on nexus repository for binary and source packages: * Tobago 6.2.0 [1] * Tobago 5.10.0 [1] The release notes are in Jira: * Tobago 6.2.0 [2] * Tobago 5.10.0 [3] The artifacts are available at the

Re: [PR] chore(deps): bump actions/cache from 3 to 4 [myfaces-master-pom]

2024-01-22 Thread via GitHub
melloware merged PR #101: URL: https://github.com/apache/myfaces-master-pom/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore: update to minor version [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn merged PR #4803: URL: https://github.com/apache/myfaces-tobago/pull/4803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore: update to minor version [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn merged PR #4802: URL: https://github.com/apache/myfaces-tobago/pull/4802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] chore: update to minor version [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn opened a new pull request, #4803: URL: https://github.com/apache/myfaces-tobago/pull/4803 Update to minor version because of: * https://issues.apache.org/jira/browse/TOBAGO-2272 * https://issues.apache.org/jira/browse/TOBAGO-2276 -- This is an automated message from the

[PR] refactor: update to minor version [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn opened a new pull request, #4802: URL: https://github.com/apache/myfaces-tobago/pull/4802 Update to minor version because of: * https://issues.apache.org/jira/browse/TOBAGO-2272 * https://issues.apache.org/jira/browse/TOBAGO-2276 -- This is an automated message from the

[PR] WIP feat: Support for PassThroughAttributes in Tobago [myfaces-tobago]

2024-01-22 Thread via GitHub
bohmber opened a new pull request, #4801: URL: https://github.com/apache/myfaces-tobago/pull/4801 issue: TOBAGO-2277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (TOBAGO-2277) Support for PassthroughAttributes in Tobago

2024-01-22 Thread Bernd Bohmann (Jira)
Bernd Bohmann created TOBAGO-2277: - Summary: Support for PassthroughAttributes in Tobago Key: TOBAGO-2277 URL: https://issues.apache.org/jira/browse/TOBAGO-2277 Project: MyFaces Tobago Issue

Re: [PR] fix: test-scenarios-locally.sh [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn merged PR #4800: URL: https://github.com/apache/myfaces-tobago/pull/4800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix: test-scenarios-locally.sh [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn opened a new pull request, #4800: URL: https://github.com/apache/myfaces-tobago/pull/4800 * use context path for Tomcat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (TOBAGO-2273) Avoid warning log message for required|converter|validatorMessage attribute

2024-01-22 Thread Bernd Bohmann (Jira)
[ https://issues.apache.org/jira/browse/TOBAGO-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Bohmann resolved TOBAGO-2273. --- Resolution: Fixed > Avoid warning log message for required|converter|validatorMessage

[jira] [Resolved] (TOBAGO-2276) Allow selectionMode only for columnSelector

2024-01-22 Thread Bernd Bohmann (Jira)
[ https://issues.apache.org/jira/browse/TOBAGO-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Bohmann resolved TOBAGO-2276. --- Resolution: Fixed > Allow selectionMode only for columnSelector >

[jira] [Resolved] (TOBAGO-2275) Lazy loading sheet: user cannot change width of columns

2024-01-22 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2275. -- Fix Version/s: 5.9.1 6.1.1 Resolution: Fixed > Lazy loading sheet:

Re: [PR] fix(lazy-sheet): change column width [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn merged PR #4798: URL: https://github.com/apache/myfaces-tobago/pull/4798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(lazy-sheet): change column width [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn merged PR #4799: URL: https://github.com/apache/myfaces-tobago/pull/4799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix(lazy-sheet): change column width [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn opened a new pull request, #4799: URL: https://github.com/apache/myfaces-tobago/pull/4799 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] fix(lazy-sheet): change column width [myfaces-tobago]

2024-01-22 Thread via GitHub
henningn opened a new pull request, #4798: URL: https://github.com/apache/myfaces-tobago/pull/4798 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To