[PR] build(deps): bump com.google.guava:guava from 33.0.0-jre to 33.1.0-jre [myfaces-tobago]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4959: URL: https://github.com/apache/myfaces-tobago/pull/4959 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.0.0-jre to 33.1.0-jre. Release notes Sourced from

[PR] build(deps): bump com.google.guava:guava from 33.0.0-jre to 33.1.0-jre [myfaces-tobago]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4958: URL: https://github.com/apache/myfaces-tobago/pull/4958 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.0.0-jre to 33.1.0-jre. Release notes Sourced from

[PR] build(deps): bump com.google.guava:guava from 33.0.0-jre to 33.1.0-jre [myfaces-tobago]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4957: URL: https://github.com/apache/myfaces-tobago/pull/4957 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.0.0-jre to 33.1.0-jre. Release notes Sourced from

[PR] build(deps): bump com.google.guava:guava from 33.0.0-jre to 33.1.0-jre [myfaces-tobago]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4956: URL: https://github.com/apache/myfaces-tobago/pull/4956 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.0.0-jre to 33.1.0-jre. Release notes Sourced from

[PR] build(deps): bump spring.version from 5.3.32 to 5.3.33 [myfaces-tobago]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4955: URL: https://github.com/apache/myfaces-tobago/pull/4955 Bumps `spring.version` from 5.3.32 to 5.3.33. Updates `org.springframework:spring-core` from 5.3.32 to 5.3.33 Release notes Sourced from

Re: [PR] MYFACES-4655 fix resolving of FacesValidators without value [myfaces]

2024-03-14 Thread via GitHub
NicolaIsotta commented on PR #682: URL: https://github.com/apache/myfaces/pull/682#issuecomment-1997480934 Not needed, I already tried, here's what happens if you don't declare forClass and value on FacesConverter: ``` @FacesConverter must have value, forClass or both. Check

Re: [PR] MYFACES-4655 fix resolving of FacesValidators without value [myfaces]

2024-03-14 Thread via GitHub
tandraschko commented on PR #682: URL: https://github.com/apache/myfaces/pull/682#issuecomment-1997451201 what about the converters? its the same logic there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MYFACES-4655 fix resolving of FacesValidators without value [myfaces]

2024-03-14 Thread via GitHub
NicolaIsotta commented on PR #682: URL: https://github.com/apache/myfaces/pull/682#issuecomment-1997410840 > @tandraschko does this need to be backported and forward ported once accepted? no need to backport to 2.3, but yes I think 4.1 and 5.0 needs this too. > can you explain

Re: [PR] MYFACES-4655 fix resolving of FacesValidators without value [myfaces]

2024-03-14 Thread via GitHub
tandraschko commented on PR #682: URL: https://github.com/apache/myfaces/pull/682#issuecomment-1997391903 can you explain the change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MYFACES-4655 fix resolving of FacesValidators without value [myfaces]

2024-03-14 Thread via GitHub
melloware commented on code in PR #682: URL: https://github.com/apache/myfaces/pull/682#discussion_r1524784165 ## impl/src/main/java/org/apache/myfaces/cdi/util/CDIUtils.java: ## @@ -120,6 +135,17 @@ public static T get(BeanManager beanManager, Type type, boolean create, Anno

Re: [PR] MYFACES-4655 fix resolving of FacesValidators without value [myfaces]

2024-03-14 Thread via GitHub
melloware commented on PR #682: URL: https://github.com/apache/myfaces/pull/682#issuecomment-1997377712 @tandraschko does this need to be backported and forward ported once accepted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (MYFACES-4655) NPE in FacesValidatorCDIWrapper

2024-03-14 Thread Nicola Isotta (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicola Isotta updated MYFACES-4655: --- Status: Patch Available (was: Open) > NPE in FacesValidatorCDIWrapper >

[jira] [Updated] (MYFACES-4655) NPE in FacesValidatorCDIWrapper

2024-03-14 Thread Nicola Isotta (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicola Isotta updated MYFACES-4655: --- Status: Open (was: Patch Available) > NPE in FacesValidatorCDIWrapper >

[PR] MYFACES-4655 fix resolving of FacesValidators without value [myfaces]

2024-03-14 Thread via GitHub
NicolaIsotta opened a new pull request, #682: URL: https://github.com/apache/myfaces/pull/682 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Comment Edited] (MYFACES-4655) NPE in FacesValidatorCDIWrapper

2024-03-14 Thread Nicola Isotta (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827058#comment-17827058 ] Nicola Isotta edited comment on MYFACES-4655 at 3/14/24 11:46 AM: -- I

[jira] [Commented] (MYFACES-4655) NPE in FacesValidatorCDIWrapper

2024-03-14 Thread Nicola Isotta (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827058#comment-17827058 ] Nicola Isotta commented on MYFACES-4655: I can take look. Where are the validators registered

Re: [PR] refactor(demo): Toast example [myfaces-tobago]

2024-03-14 Thread via GitHub
henningn merged PR #4954: URL: https://github.com/apache/myfaces-tobago/pull/4954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] refactor(demo): Toast example [myfaces-tobago]

2024-03-14 Thread via GitHub
henningn merged PR #4953: URL: https://github.com/apache/myfaces-tobago/pull/4953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MYFACES-4655) NPE in FacesValidatorCDIWrapper

2024-03-14 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827041#comment-17827041 ] Thomas Andraschko commented on MYFACES-4655: would you like to prepare a PR? > NPE in

[jira] [Comment Edited] (MYFACES-4655) NPE in FacesValidatorCDIWrapper

2024-03-14 Thread Nicola Isotta (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827039#comment-17827039 ] Nicola Isotta edited comment on MYFACES-4655 at 3/14/24 10:36 AM: --

[jira] [Commented] (MYFACES-4655) NPE in FacesValidatorCDIWrapper

2024-03-14 Thread Nicola Isotta (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827039#comment-17827039 ] Nicola Isotta commented on MYFACES-4655: Reproducer attached. Needs Java 17 bc of Jetty 12. To

[PR] refactor(demo): Toast example [myfaces-tobago]

2024-03-14 Thread via GitHub
henningn opened a new pull request, #4954: URL: https://github.com/apache/myfaces-tobago/pull/4954 * fix ToastFacesMessage (AJAX) button * add code examples * refactor custom toast example to show how a custom CSS class is added -- This is an automated message from the Apache Git

[PR] refactor(demo): Toast example [myfaces-tobago]

2024-03-14 Thread via GitHub
henningn opened a new pull request, #4953: URL: https://github.com/apache/myfaces-tobago/pull/4953 * fix ToastFacesMessage (AJAX) button * add code examples * refactor custom toast example to show how a custom CSS class is added -- This is an automated message from the Apache Git

[jira] [Commented] (MYFACES-4655) NPE in FacesValidatorCDIWrapper

2024-03-14 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827018#comment-17827018 ] Thomas Andraschko commented on MYFACES-4655: yeah please you can use the primefaces-test

[jira] [Created] (MYFACES-4655) NPE in FacesValidatorCDIWrapper

2024-03-14 Thread Nicola Isotta (Jira)
Nicola Isotta created MYFACES-4655: -- Summary: NPE in FacesValidatorCDIWrapper Key: MYFACES-4655 URL: https://issues.apache.org/jira/browse/MYFACES-4655 Project: MyFaces Core Issue Type: Bug

Re: [PR] fix(demo): tc:style on tc:sheet [myfaces-tobago]

2024-03-14 Thread via GitHub
henningn merged PR #4952: URL: https://github.com/apache/myfaces-tobago/pull/4952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(demo): tc:style on tc:sheet [myfaces-tobago]

2024-03-14 Thread via GitHub
henningn merged PR #4951: URL: https://github.com/apache/myfaces-tobago/pull/4951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix(demo): tc:style on tc:sheet [myfaces-tobago]

2024-03-14 Thread via GitHub
henningn opened a new pull request, #4952: URL: https://github.com/apache/myfaces-tobago/pull/4952 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] fix(demo): tc:style on tc:sheet [myfaces-tobago]

2024-03-14 Thread via GitHub
henningn opened a new pull request, #4951: URL: https://github.com/apache/myfaces-tobago/pull/4951 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] build(deps): bump com.fasterxml.jackson.core:jackson-core from 2.16.2 to 2.17.0 [myfaces-tobago]

2024-03-14 Thread via GitHub
henningn merged PR #4950: URL: https://github.com/apache/myfaces-tobago/pull/4950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: