[jira] [Created] (TRINIDAD-2210) backport CollectionModel.getRowData(Object rowKey) to 1.2 and clearly document the behavior

2012-01-27 Thread Yuan Gao (Created) (JIRA)
Project: MyFaces Trinidad Issue Type: Bug Components: Components Affects Versions: 2.0.0-core, 1.2.12-core Reporter: Yuan Gao we want to backport the CollectionModel.getRowData(Object rowKey) API to 1.2 serious. Plus, for the javadoc

[Trinidad] API backport and javadoc change

2012-01-27 Thread Yuan Gao
hi, I just fired a JIRA on the CollectionModel.getRowData(Object rowKey) API backport to 1.2 and some javadoc changes. Can you please review it? https://issues.apache.org/jira/browse/TRINIDAD-2210 Thanks, -Yuan

[jira] [Updated] (TRINIDAD-2070) log a warning message to warn the developers if rowkey is set but not unset at the end of the request

2011-12-21 Thread Yuan Gao (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-2070: --- Status: Patch Available (was: Reopened) log a warning message to warn the developers

[jira] [Updated] (TRINIDAD-2070) log a warning message to warn the developers if rowkey is set but not unset at the end of the request

2011-12-21 Thread Yuan Gao (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-2070: --- Resolution: Fixed Status: Resolved (was: Patch Available) re-uploaded patch with grant

[jira] [Resolved] (TRINIDAD-2181) processsavestate and processrestorestate not called in uixcollection

2011-12-20 Thread Yuan Gao (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao resolved TRINIDAD-2181. Resolution: Fixed re-uploaded the patch with grant license processsavestate

[jira] [Created] (TRINIDAD-2181) processsavestate and processrestorestate not called in uixcollection

2011-12-19 Thread Yuan Gao (Created) (JIRA)
Issue Type: Bug Components: Components Affects Versions: 2.0.0-core Reporter: Yuan Gao With the UIXCollection, in full state saving , we call processSaveState() in a hierarchy. However, in partial state saving, we call directly to saveState() through visitTree(). We

[jira] [Updated] (TRINIDAD-2181) processsavestate and processrestorestate not called in uixcollection

2011-12-19 Thread Yuan Gao (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-2181: --- Status: Patch Available (was: Open) processsavestate and processrestorestate not called

[jira] [Updated] (TRINIDAD-2181) processsavestate and processrestorestate not called in uixcollection

2011-12-19 Thread Yuan Gao (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-2181: --- Status: Open (was: Patch Available) processsavestate and processrestorestate not called

[jira] [Updated] (TRINIDAD-2181) processsavestate and processrestorestate not called in uixcollection

2011-12-19 Thread Yuan Gao (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-2181: --- Status: Patch Available (was: Open) processsavestate and processrestorestate not called

[jira] [Updated] (TRINIDAD-2181) processsavestate and processrestorestate not called in uixcollection

2011-12-19 Thread Yuan Gao (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-2181: --- Status: Open (was: Patch Available) processsavestate and processrestorestate not called

[jira] [Commented] (TRINIDAD-2181) processsavestate and processrestorestate not called in uixcollection

2011-12-19 Thread Yuan Gao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172751#comment-13172751 ] Yuan Gao commented on TRINIDAD-2181: attached the fix for trinidad trunk

[jira] [Created] (TRINIDAD-2079) PartialPageUtils: add partial-response message when writing the noop/ ppr message to client

2011-04-05 Thread Yuan Gao (JIRA)
-2079 Project: MyFaces Trinidad Issue Type: Bug Reporter: Yuan Gao Today in PartialPageUtils, when we write a noop/ ppr response to the client, we put the noop as the root node. On the client side we are actually expecting a structure like this: partial-response

[jira] [Created] (TRINIDAD-2070) log a warning message to warn the developers if rowkey is set but not unset at the end of the request

2011-03-24 Thread Yuan Gao (JIRA)
/browse/TRINIDAD-2070 Project: MyFaces Trinidad Issue Type: Bug Reporter: Yuan Gao For uixcollections, we need to set the row key to operate on a specific row, after that we need to unset the row key. If we leave the row key there, it could cause all sorts

[jira] [Updated] (TRINIDAD-2070) log a warning message to warn the developers if rowkey is set but not unset at the end of the request

2011-03-24 Thread Yuan Gao (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-2070: --- Status: Patch Available (was: Open) log a warning message to warn the developers if rowkey

Re: propose a new utility API in PartialPageUtils to complate the response

2011-03-15 Thread Yuan Gao
Thanks for the comment. Yes. The caller will call responseComplete(). Thanks, -Yuan On 3/14/2011 4:09 PM, Scott O'Bryan wrote: So the caller would do the responseComplete after rendering the noop, right? If so, that looks MUCH better to me.. +1 On Mar 14, 2011, at 5:06 PM, Yuan

[jira] Updated: (TRINIDAD-2061) add a utility method in PartialPageUtils to send a noop/ ppr response

2011-03-15 Thread Yuan Gao (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-2061: --- Status: Patch Available (was: Open) add a utility method in PartialPageUtils to send a noop

Re: propose a new utility API in PartialPageUtils to complate the response

2011-03-14 Thread Yuan Gao
hi, Andy, I like your comments. As for the names, how about renderNoopAndCompleteResponse()? Thanks, -Yuan On 3/13/2011 7:48 AM, Andy Schwartz wrote: Hi Bernd - I am a bit hesitant about the names as well. Three possible options: 1.

Re: propose a new utility API in PartialPageUtils to complate the response

2011-03-14 Thread Yuan Gao
hi, I agree that we are trying to do too much in a method. Also talked with Blake about it. How about we leave the script and redirect to the caller, in this method we only do the noop writing? We don't do the complete response either. How do you like this then? /** * This method

[jira] Created: (TRINIDAD-2061) add a utility method in PartialPageUtils to complete the ppr response

2011-03-11 Thread Yuan Gao (JIRA)
Issue Type: Bug Reporter: Yuan Gao Just discussed with Blake. What we are trying to do is to add a new utility method (API) in PartialPageUtils. /** * This method completes the PPR request and writes a noop/ to the response. * it also handles script and redirect

propose a new utility API in PartialPageUtils to complate the response

2011-03-11 Thread Yuan Gao
hi, I'd like to propose a new utility API to complete the PPR response. Talked with Blake and we suggest to put it in PartialPageUtils. Here is the JIRA: https://issues.apache.org/jira/browse/TRINIDAD-2061 Please review. Thanks, -Yuan

[jira] Updated: (TRINIDAD-1977) for complex change objects, when applying changes, we should modify content instead of replacing the object

2011-01-31 Thread Yuan Gao (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-1977: --- Status: Patch Available (was: Open) for complex change objects, when applying changes, we

[jira] Updated: (TRINIDAD-1977) for complex change objects, when applying changes, we should modify content instead of replacing the object

2011-01-31 Thread Yuan Gao (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-1977: --- Status: Open (was: Patch Available) for complex change objects, when applying changes, we

[jira] Created: (TRINIDAD-1977) for complex change objects, when applying changes, we should modify content instead of replacing the object

2010-12-10 Thread Yuan Gao (JIRA)
://issues.apache.org/jira/browse/TRINIDAD-1977 Project: MyFaces Trinidad Issue Type: Bug Components: Components Reporter: Yuan Gao Today when we apply component changes, if there is an existing object there, we will simply replace the object with our new change

[jira] Created: (TRINIDAD-1949) SessionChangeManager failed to apply changes with page incluldes

2010-11-01 Thread Yuan Gao (JIRA)
false in _isStateRestored(). In the long term, we might have better solutions like asking all page fragments to restore their states. Reporter: Yuan Gao -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

[jira] Updated: (TRINIDAD-1949) SessionChangeManager failed to apply changes with page incluldes

2010-11-01 Thread Yuan Gao (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao updated TRINIDAD-1949: --- Status: Patch Available (was: Open) SessionChangeManager failed to apply changes with page

Re: [jira] Resolved: (TRINIDAD-1935) ChangeManager shouldn't persist changes for stamped components

2010-10-17 Thread Yuan Gao
-- Key: TRINIDAD-1935 URL: https://issues.apache.org/jira/browse/TRINIDAD-1935 Project: MyFaces Trinidad Issue Type: Bug Affects Versions: 1.2.12-core Reporter: Yuan Gao Assignee: Blake Sullivan

[jira] Reopened: (TRINIDAD-1935) ChangeManager shouldn't persist changes for stamped components

2010-10-16 Thread Yuan Gao (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Gao reopened TRINIDAD-1935: The previous fix caused problem with table customization. So now the column width and order

[jira] Created: (TRINIDAD-1939) SessionChangeManager should restore attribute lock after session failover

2010-10-11 Thread Yuan Gao (JIRA)
Issue Type: Bug Components: Components Affects Versions: 1.2.12-core Reporter: Yuan Gao The issue is in SessionChangeManager, we have an attribute lock, as this: private transient final Object _attrRebuildLock = new Object(); And we synchronize on this object

Re: [jira] Created: (TRINIDAD-1935) ChangeManager shouldn't persist changes for stamped components

2010-10-07 Thread Yuan Gao
Andrew, Blake and I talked about it. We like Andrew's suggestion but decided that we will wait until a requirement /use case comes in. For now we will keep the implementation. Thanks, -Yuan On 10/5/2010 3:15 PM, Andrew Robinson wrote: On Tue, Oct 5, 2010 at 2:53 PM, Yuan Gao (JIRA)dev

[jira] Created: (TRINIDAD-1935) ChangeManager shouldn't persist changes for stamped components

2010-10-05 Thread Yuan Gao (JIRA)
: Bug Affects Versions: 1.2.12-core Reporter: Yuan Gao Today ChangeManager will persist changes to the component no matter if the component is a repeated component inside an UIXIterator or not. This is not good since if it's persisted, then the next time when the component

Re: proposed API change on ChangeManager

2010-04-13 Thread Yuan Gao
hi, Simon, Thanks for the vote. Please see my comments inline. On 4/9/2010 8:01 PM, Simon Lessard wrote: +0, see below for the why. Blake, Let see if I understand the issue correctly. We have: - Detect a row key change (can happen if the rowKey is the PK and the PK changes during the

Re: proposed API change on ChangeManager

2010-04-09 Thread Yuan Gao
for our use case and would introduce backward compatibility issues. I could change my opinion, but I'd like a detailed use case as of why this cannot be just an implementation detail before I do. Regards, ~ Simon On Wed, Apr 7, 2010 at 5:17 PM, Yuan Gao yuan@oracle.com mailto:yuan

proposed API change on ChangeManager

2010-04-07 Thread Yuan Gao
hi, For JIRA 1761 (https://issues.apache.org/jira/browse/TRINIDAD-1761), we propose to add this API to the ChangeManager interface: /** * Replace an AttributeComponentChange if it's present. * * @param facesContext * @param uiComponent * @param attributeComponentChange *