[Fwd: Re: [orchestra] ConnectionManagerDataSource.isWrapperFor]

2007-08-19 Thread simon
Forwarded Message From: simon [EMAIL PROTECTED] To: MyFaces Development dev@myfaces.apache.org Subject: Re: [orchestra] ConnectionManagerDataSource.isWrapperFor Date: Sat, 18 Aug 2007 14:08:24 +0200 On Sat, 2007-08-18 at 13:55 +0200, Mario Ivankovits wrote: Hi

Re: [Fwd: Re: [orchestra] ConnectionManagerDataSource.isWrapperFor]

2007-08-19 Thread Mario Ivankovits
Hi! Hi! In ConnectionManagerDataSource, method isWrapperFor currently returns false. Perhaps it should throw UnsupportedOperationException instead? And what about a solution using reflection? Maybe the most correct solution could be: Yes, I agree that using reflection is

[orchestra] ConnectionManagerDataSource.isWrapperFor

2007-08-18 Thread simon
Hi, In ConnectionManagerDataSource, method isWrapperFor currently returns false. Perhaps it should throw UnsupportedOperationException instead? I think it could be misleading if some user code asks whether this object is a wrapper then gets false returned. Yes the primary reason for this method

Re: [orchestra] ConnectionManagerDataSource.isWrapperFor

2007-08-18 Thread Mario Ivankovits
Hi! In ConnectionManagerDataSource, method isWrapperFor currently returns false. Perhaps it should throw UnsupportedOperationException instead? And what about a solution using reflection? Maybe the most correct solution could be: public Object unwrap(Class iface) throws SQLException {