Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Martin Marinschek
Hi guys, let me weigh in on the filter question: please, no filter! @prefix suffix mappings: you can get the registered mappings in previous servlet versions: parsing the web.xml in servlet 3.0: via the API http://download.oracle.com/javaee/6/api/javax/servlet/ServletRegistration.html the

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Jakob Korherr
Hi Martin, Thank you so much for your mail! This is exactly my point of view about the ResourceHandler. However, Leonardo in I kinda got into a fight about it and unfortunately, I do not have time for that right now! Leonardo, please reconsider my reasoning from the previous mails of this

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
Hi 2011/6/30 Martin Marinschek mmarinsc...@apache.org: Hi guys, let me weigh in on the filter question: please, no filter! @prefix suffix mappings: you can get the registered mappings in previous servlet versions: parsing the web.xml in servlet 3.0: via the API

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
Hi Jakob 2011/6/30 Jakob Korherr jakob.korh...@gmail.com: Hi Martin, Thank you so much for your mail! This is exactly my point of view about the ResourceHandler. However, Leonardo in I kinda got into a fight about it and unfortunately, I do not have time for that right now! For me this is

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Jakob Korherr
[...] The new alternative proposed is similar. This alternative is not new! My first version of the AdvancedResourceHandler (before you started committing) already did exactly this! (However, assuming /faces/* as mapping if the page was accessed via suffix mapping, but making it configurable

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
2011/6/30 Jakob Korherr jakob.korh...@gmail.com: [...] The new alternative proposed is similar. This alternative is not new! My first version of the AdvancedResourceHandler (before you started committing) already did exactly this! (However, assuming /faces/* as mapping if the page was

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Jakob Korherr
Hm, you're not getting it. This To do it correctly we need to detect if this is a servlet 3.0 container and do the necessary stuff, but we need to test what happen if a 2.5 or 2.4 web.xml file is deployed on a 3.0 container. Additionally, we need to take care about do not call 3.0 code in 2.5

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
2011/6/30 Jakob Korherr jakob.korh...@gmail.com: Hm, you're not getting it. This To do it correctly we need to detect if this is a servlet 3.0 container and do the necessary stuff, but we need to test what happen if a 2.5 or 2.4 web.xml file is deployed on a 3.0 container. Additionally, we

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Gerhard Petracek
hi @ all, what jakob is talking about makes a lot of sense to me. @jakob: please don't fork it. imo we should continue with the approach started by jakob + the addition mentioned by martin. after finishing that we can think about further improvements (if needed at all). @leo: do you feel we

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
2011/6/30 Gerhard Petracek gerhard.petra...@gmail.com: hi @ all, what jakob is talking about makes a lot of sense to me. @jakob: please don't fork it. imo we should continue with the approach started by jakob + the addition mentioned by martin. after finishing that we can think about

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Gerhard Petracek
ok - so please start a vote about it. describe the topic and why you think something has to be changed (compared to the original commit in combination with the addition mentioned by martin). please write it very concisely! we won't get a lot of votes, if the description is too verbose. thx

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-30 Thread Leonardo Uribe
Hi Ok, I already send it. I hope it is clear the problem we are discussing about. @Jakob: do you have any other issue related to the current implementation done in myfaces-commons-resourcehandler that we need to take a decision? regards, Leonardo Uribe 2011/6/30 Gerhard Petracek

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-23 Thread Leonardo Uribe
Hi In the last days this enhancements were commited: -- Added GZIP compression to ExtendedResourceHandler and these params: /** * Enable or disable gzip compressions for resources served by this extended

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-14 Thread Jakob Korherr
Hi Leonardo, Because set prefix and suffix mapping for the same webapp could lead to inconsistencies. Which inconsistencies exactly? Please give an example, I can't really think of any! [...] If a page is rendered using suffix mapping, resource paths will use that and not prefix mapping,

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-14 Thread Leonardo Uribe
Hi Jakob 2011/6/14 Jakob Korherr jakob.korh...@gmail.com: Hi Leonardo, Because set prefix and suffix mapping for the same webapp could lead to inconsistencies. Which inconsistencies exactly? Please give an example, I can't really think of any! Let's take a look to

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-13 Thread Leonardo Uribe
Hi I committed on myfaces-commons-resourcehandler module on trunk an alternative solution for this issue. It is still not complete, so the idea is discuss it. See: https://issues.apache.org/jira/browse/MFCOMMONS-33 From previous discussion, on AdvancedResource handler we have: a. relative

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-13 Thread Jakob Korherr
Hi Leo, Overall this seems nice, thanks! However, I have some comments on your solution: 1) If I have to configure a Filter in web.xml I can just as good define a prefix mapping for the FacesServlet. I don't see why an additional Filter is better than an additional servlet-mapping. So why

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-06-13 Thread Leonardo Uribe
Hi Jakob 2011/6/13 Jakob Korherr jakob.korh...@gmail.com: Hi Leo, Overall this seems nice, thanks! However, I have some comments on your solution: 1) If I have to configure a Filter in web.xml I can just as good define a prefix mapping for the FacesServlet. I don't see why an additional

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-05-18 Thread Leonardo Uribe
Hi Jakob 2011/5/17 Jakob Korherr jakob.korh...@gmail.com: Hi Leo, Thanks! Some comments to your ideas: - Resource caching (just like myfaces core does!). This is already implemented and it actually goes one step further, because it uses GZIP compression too! I was thinking on do

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-05-17 Thread Jakob Korherr
Hi Leo, Thanks! Some comments to your ideas: - Resource caching (just like myfaces core does!). This is already implemented and it actually goes one step further, because it uses GZIP compression too! - Find a better name for advanced-resources.xml. It is ok, but I'll prefer a more

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-05-16 Thread Leonardo Uribe
Hi This stuff looks very promising. I think we can additionally implement the following ideas: - Relocate resources and replace library names. For example, if my custom component uses prototype library and I have to use other jsf component library that loads prototype.js with its custom library

Re: Advanced JSF 2 ResourceHandler for MyFaces commons

2011-03-08 Thread Jakob Korherr
Hi, I just committed the code, see r1079447. In addition, I created the following issue for reference in the jira: MFCOMMONS-29. Feel free to look at it, use it, change it,... - input is always welcome :) Regards, Jakob 2011/2/23 Jakob Korherr jakob.korh...@gmail.com: Hi guys, I developed

Advanced JSF 2 ResourceHandler for MyFaces commons

2011-02-23 Thread Jakob Korherr
Hi guys, I developed a custom JSF 2 ResourceHandler for one of my current projects and I want to donate it to MyFaces commons (JSF 2 branch). The features of this ResourceHandler include the following: - relative paths between resources (css files referencing images without using