Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content of a script, we create a CDATA element without checking if is nested at all

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Bruno Aranda
mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content of a script, we

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Jakob Korherr
: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content of a script, we create a CDATA element without

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
From: Bruno Arandabrunoara...@gmail.com mailto:brunoara...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Bruno Aranda
...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
           mailto:dev@myfaces.apache.org            Sent: Thu, July 22, 2010 5:26:35 PM            Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA            Further investigation of this incompatibility problem with            myfaces leads me to            the fact

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
@myfaces.apache.org            mailto:dev@myfaces.apache.org            Sent: Thu, July 22, 2010 5:26:35 PM            Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA            Further investigation of this incompatibility problem with            myfaces leads me to            the fact

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Bruno Aranda
@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
:35 PM            Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA            Further investigation of this incompatibility problem with            myfaces leads me to            the fact that in the HtmlResponseWriterImpl, when we write            the content

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
, strub From: Bruno Arandabrunoara...@gmail.com mailto:brunoara...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
of all this scanning/dynamic replacement? LieGrue, strub From: Bruno Arandabrunoara...@gmail.com mailto:brunoara...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Bruno Aranda
Arandabrunoara...@gmail.com mailto:brunoara...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
mailto:dev@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
of all this scanning/dynamic replacement? LieGrue, strub From: Bruno Arandabrunoara...@gmail.com mailto:brunoara...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Martin Marinschek
@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
replacement? LieGrue, strub From: Bruno Arandabrunoara...@gmail.com mailto:brunoara...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Mark Struberg
mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Jakob Korherr
' :) LieGrue, strub - Original Message From: Werner Punz werner.p...@gmail.com To: dev@myfaces.apache.org Sent: Fri, July 23, 2010 2:48:17 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA The honeymoon is over already, unfortunately, since we have a small boy of 19

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org mailto:dev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact

Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Bruno Aranda
Hi, Having problems with Primefaces again I have realised that something was working with Mojarra, but not with MyFaces. Again, is the ResponseWriter.startCDATA stuff which Primefaces invokes directly on its main phase listener. However, reading the javadocs:

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Bruno Aranda
https://issues.apache.org/jira/browse/MYFACES-2835 On 22 July 2010 12:48, Bruno Aranda brunoara...@gmail.com wrote: Hi, Having problems with Primefaces again I have realised that something was working with Mojarra, but not with MyFaces. Again, is the ResponseWriter.startCDATA stuff which

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Jakob Korherr
Hi Bruno, Please take a look at MYFACES-2831. This seems to be the same problem! Regards, Jakob 2010/7/22 Bruno Aranda brunoara...@gmail.com Hi, Having problems with Primefaces again I have realised that something was working with Mojarra, but not with MyFaces. Again, is the

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Jakob Korherr
Sorry, had to reopen it. Please take a look at the JIRA. Regards, Jakob 2010/7/22 Jakob Korherr jakob.korh...@gmail.com Hi Bruno, Please take a look at MYFACES-2831. This seems to be the same problem! Regards, Jakob 2010/7/22 Bruno Aranda brunoara...@gmail.com Hi, Having problems

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Matthias Wessendorf
sounds right. does blame say more why it does not do nothing? It is also kinda strange since the TCK was successfully executed for 2.0.0 and 2.0.1; -Matthias On Thu, Jul 22, 2010 at 1:48 PM, Bruno Aranda brunoara...@gmail.com wrote: Hi, Having problems with Primefaces again I have realised

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Matthias Wessendorf
so, maybe there are now regressions? hrm. have you done some testing? -M On Thu, Jul 22, 2010 at 2:07 PM, Matthias Wessendorf mat...@apache.org wrote: sounds right. does blame say more why it does not do nothing? It is also kinda strange since the TCK was successfully executed for 2.0.0

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Matthias Wessendorf
On Thu, Jul 22, 2010 at 2:14 PM, Matthias Wessendorf mat...@apache.org wrote: so, maybe there are now regressions? hrm. have you done some testing? Ah, the discussion is on the JIRA.. please run tests, before committing ;-) -M On Thu, Jul 22, 2010 at 2:07 PM, Matthias Wessendorf

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Bruno Aranda
yeah, sorry, my problem was running only the API tests :) Bruno On 22 July 2010 13:48, Matthias Wessendorf mat...@apache.org wrote: On Thu, Jul 22, 2010 at 2:14 PM, Matthias Wessendorf mat...@apache.org wrote: so, maybe there are now regressions? hrm. have you done some testing? Ah,

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Bruno Aranda
As you can see in my black box tests with Mojarra, the behaviour is different in both implementations. In the base ResponseWriter class, they don't do anything in the startCDATA method and throw an undocumented exception in the endCDATA. In both implementations of the base class, they throw an

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Bruno Aranda
Just clicked on sent and Werner had answered in the JIRA issue explaining the partial approach... Cheers, Bruno On 22 July 2010 15:12, Bruno Aranda brunoara...@gmail.com wrote: As you can see in my black box tests with Mojarra, the behaviour is different in both implementations. In the base

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Bruno Aranda
Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content of a script, we create a CDATA element without checking if is nested at all. That is a problem, because if we use the standard response writer and

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Mark Struberg
, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content of a script, we create a CDATA element without checking if is nested at all

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Bruno Aranda
@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content of a script, we create a CDATA element

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Werner Punz
: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content of a script, we create a CDATA element without checking

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Bruno Aranda
this scanning/dynamic replacement? LieGrue, strub From: Bruno Arandabrunoara...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org Sent: Thu, July 22, 2010 5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Werner Punz
: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content of a script, we create a CDATA element without

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-22 Thread Werner Punz
5:26:35 PM Subject: Re: Fixing ResponseWriter.startCDATA/endCDATA Further investigation of this incompatibility problem with myfaces leads me to the fact that in the HtmlResponseWriterImpl, when we write the content of a script, we create a CDATA element without checking if is nested at all