Move AddResource et al to tomahawk?

2006-03-03 Thread Mario Ivankovits
Hi! I know this is not the best timing, but I would like to ask anyway. Also I havent looked at it in every detail, so I dont know if there is any technical reason for not doing so. The question is: Can we move all the AddResource stuff from shared to tomahawk? In fact I talk about the whole

Re: Move AddResource et al to tomahawk?

2006-03-03 Thread Dennis Byrne
The same goes for org.apache.myfaces.shared.webapp.filter.WelcomeFileFilter. Hello Mario, WelcomeFileFilter was moved to commons already. http://issues.apache.org/jira/browse/MYFACES-1112 Are you saying this is back in impl ? Dennis Byrne

Re: Move AddResource et al to tomahawk?

2006-03-03 Thread Manfred Geiler
+1 Everything that is not in spec (ie MyFaces Extensions) and not needed by impl should be moved to tomahawk IMO. This way shared module will slim down. The less we have in shared the less we have dependencies between impl, shared and tomahawk. And the less will be the pain with our new project

Re: Move AddResource et al to tomahawk?

2006-03-03 Thread Mario Ivankovits
Hi Dennis! The same goes for org.apache.myfaces.shared.webapp.filter.WelcomeFileFilter. WelcomeFileFilter was moved to commons already. From impl to commons to tomahawk ... ;-) A long journey for sure :-) Are you saying this is back in impl ? not impl, to tomahawk! --- Mario

Re: Move AddResource et al to tomahawk?

2006-03-03 Thread Mario Ivankovits
Dennis Byrne schrieb: The same goes for org.apache.myfaces.shared.webapp.filter.WelcomeFileFilter. http://issues.apache.org/jira/browse/MYFACES-1112 JavaScriptDetectorFilter stayed in impl because it depends on ServletExternalContextImpl . Does this mean we cant move the

Re: Move AddResource et al to tomahawk?

2006-03-03 Thread Volker Weber
Hi, Mario Ivankovits wrote: Hi! I know this is not the best timing, but I would like to ask anyway. Also I havent looked at it in every detail, so I dont know if there is any technical reason for not doing so. The question is: Can we move all the AddResource stuff from shared to

Re: Move AddResource et al to tomahawk?

2006-03-03 Thread Dennis Byrne
BTW, shouldnt it be easily possible to get rid of the dependency to ServletExternalContextImpl? Its used just to set a session attribute, no? I think you are correct. If you don't do this soon (yourself), go ahead and reopen the issue and I'll take a look at it. Dennis Byrne

Re: Move AddResource et al to tomahawk?

2006-03-03 Thread Mario Ivankovits
Hi! BTW, shouldnt it be easily possible to get rid of the dependency to ServletExternalContextImpl? Its used just to set a session attribute, no? I think you are correct. If you don't do this soon (yourself), go ahead and reopen the issue and I'll take a look at it. I think I

Re: Move AddResource et al to tomahawk?

2006-03-03 Thread Manfred Geiler
I think moving to tomahawk is ok by now. Manfred On 3/3/06, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! BTW, shouldnt it be easily possible to get rid of the dependency to ServletExternalContextImpl? Its used just to set a session attribute, no? I think you are correct. If you