Re: New faces.js/ts code ready for merge

2022-11-02 Thread Werner Punz
Bug is fixed, I also added 3 unit tests to cover this part of the spec on unit test level on our side. Please test, if everything is ok we can start to merge. Cheers and happy evening Werner Am Mi., 2. Nov. 2022 um 10:31 Uhr schrieb Werner Punz : > HI I just got a small bug report in via a

Re: New faces.js/ts code ready for merge

2022-11-02 Thread Werner Punz
HI I just got a small bug report in via a comment, I must have missed this morning (thanks for pointing me towards it) I just need to fix this (it is a small protocol part which is rarely used which needs implementation) I also will add the missing test. Once I am done with it I will wait a

Re: New faces.js/ts code ready for merge

2022-11-02 Thread Bernd Bohmann
Thanks Werner please go ahead. I will do some testing in the next 2 weeks as well. I think minor issues can be solved after the merge Regards Bernd On Wed, Nov 2, 2022 at 9:35 AM Werner Punz wrote: > > Hello > > I am back from my vacation, following. In my opinion the code is ready for >

New faces.js/ts code ready for merge

2022-11-02 Thread Werner Punz
Hello I am back from my vacation, following. In my opinion the code is ready for merge and the target has been RC3 which would be, now. Given I still have one pending review, did anyone test already, are there any objections to do so? I just wanted to ask before I go ahead with it. Werner PS: