Re: Pending issues before release myfaces core 2.0.1

2010-07-14 Thread Werner Punz
Ok I worked until 1am to get this all fixed. I fixed the issue and 3 others I found while fixing this one, (most of them minor, one big one) I now am again done... I hope I did not break anything, but my tests run through. The navigation now works as expected and also the Webkit support now

Re: Pending issues before release myfaces core 2.0.1

2010-07-14 Thread Werner Punz
Am 14.07.10 20:20, schrieb Leonardo Uribe: Ok, I'll start the release procedure tonight. I need to revert some changes done on MYFACES-2744 UIData.getClientId() should not append rowIndex, instead use UIData.getContainerClientId(), because for now the position on jsr-314-open list is include it

Re: Pending issues before release myfaces core 2.0.1

2010-07-14 Thread Martin Marinschek
Hi Leonardo, we actually discussed this on the EG today: I believe we should include the clientId fix immediately. This is an issue we solve in the implementation - that´s it. best regards, Martin On Wed, Jul 14, 2010 at 8:20 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi Werner Ok, I'll

Re: Pending issues before release myfaces core 2.0.1

2010-07-13 Thread Werner Punz
Am 13.07.10 07:49, schrieb Leonardo Uribe: Hi Werner This seems to be an undocumented feature. I didn't knew @form exists. It doesn't appear on the draft of jsf 2.0 rev A. Anyway, we have to implement it and tell to EG that is not documented. regards, Leonardo Hi Leonardo, sorry for the

Re: Pending issues before release myfaces core 2.0.1

2010-07-13 Thread Leonardo Uribe
Hi Werner Ok, now I understand. Right now I'm working on enhance myfaces test, but I'll dedicate some time to this one as well. Leonardo 2010/7/13 Werner Punz werner.p...@gmail.com Am 13.07.10 07:49, schrieb Leonardo Uribe: Hi Werner This seems to be an undocumented feature. I didn't

Re: Pending issues before release myfaces core 2.0.1

2010-07-13 Thread Jakob Korherr
Hi Leo, If you don't have time for it, let me know. Then I will take a look at it! Regards, Jakob 2010/7/13 Leonardo Uribe lu4...@gmail.com Hi Werner Ok, now I understand. Right now I'm working on enhance myfaces test, but I'll dedicate some time to this one as well. Leonardo 2010/7/13

Re: Pending issues before release myfaces core 2.0.1

2010-07-13 Thread Werner Punz
Hi no need anymore, I have found the root of the issue, somewhere along the full page refresh the view state is lost, the issue is within the realm of jsf.js. I am going to fix the issue tomorrow morning. Please do not release before I have fixed it, after that I will have no more issues

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Jakob Korherr
Hi Leo, There is one issue that should by all means be included in the release: MYFACES-2753. Frankly I did not have much time to look at it yet, but I am going to today. Regards, Jakob 2010/7/11 Werner Punz werner.p...@gmail.com Am 11.07.10 00:31, schrieb Leonardo Uribe: Hi I think we

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Werner Punz
Ok I am done here. My scripts are 2.0.1 ready, if someone has tests on jsf.js please run them (IBM guys), I have some homegrown test but neither access to the TCK nor to the tests the IBM guys are running on them. Werner Am 11.07.10 07:38, schrieb Werner Punz: Am 11.07.10 00:31, schrieb

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Leonardo Uribe
Hi 2010/7/12 Jakob Korherr jakob.korh...@gmail.com Hi Leo, There is one issue that should by all means be included in the release: MYFACES-2753. Frankly I did not have much time to look at it yet, but I am going to today. I have checked MYFACES-2753 and I don't think it is possible to

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Jakob Korherr
Hi Leo, Actually I've been working on it the whole day and it seems to be a minor fix. I will propose a patch soon ;) Regards, Jakob 2010/7/12 Leonardo Uribe lu4...@gmail.com Hi 2010/7/12 Jakob Korherr jakob.korh...@gmail.com Hi Leo, There is one issue that should by all means be

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Werner Punz
Hi Leo from my side all issues additionally reported are fixed now, however an old/new one has reared its ugly head https://issues.apache.org/jira/browse/MYFACES-2811 I thought I had fixed it a while ago, by introducing cdata escapes via a double buffer on the partial response writer impl. I

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Michael Concini
Werner, I'm rebuilding off the latest from SVN as I write this and will handle our WebSphere merging and kick off our tests once it has completed. I should have results by mid-afternoon if all goes well. Regards, Mike On 7/12/2010 5:05 AM, Werner Punz wrote: Ok I am done here. My scripts

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Werner Punz
Excellnt Mike, thanks a lot. Werner Am 12.07.10 16:29, schrieb Michael Concini: Werner, I'm rebuilding off the latest from SVN as I write this and will handle our WebSphere merging and kick off our tests once it has completed. I should have results by mid-afternoon if all goes well.

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Michael Concini
Results just came back. Looks good. On 7/12/2010 2:50 PM, Werner Punz wrote: Excellnt Mike, thanks a lot. Werner Am 12.07.10 16:29, schrieb Michael Concini: Werner, I'm rebuilding off the latest from SVN as I write this and will handle our WebSphere merging and kick off our tests once it

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Werner Punz
Ah superb, thanks for running the tests. If anything crawls up please post it asap, I wont be able to do any commits the after friday. Werner Am 12.07.10 21:40, schrieb Michael Concini: Results just came back. Looks good. On 7/12/2010 2:50 PM, Werner Punz wrote: Excellnt Mike, thanks a

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Leonardo Uribe
Hi Ok, Since we don't have any bug left, I'll start the release procedure on Tuesday night. regards, Leonardo Uribe 2010/7/12 Werner Punz werner.p...@gmail.com I meant after thurstday, the upcoming week :-) Werner Am 12.07.10 22:00, schrieb Werner Punz: Ah superb, thanks for running

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Werner Punz
Hi Leo, how about this one https://issues.apache.org/jira/browse/MYFACES-2809 seems severe enough for me I ran into it yesterday while doing some prototyping and testing on the ppred navigation and so far it does not work in our impl, while Mojarra behaves correctly. Werner Am 12.07.10

Re: Pending issues before release myfaces core 2.0.1

2010-07-12 Thread Leonardo Uribe
Hi Werner This seems to be an undocumented feature. I didn't knew @form exists. It doesn't appear on the draft of jsf 2.0 rev A. Anyway, we have to implement it and tell to EG that is not documented. regards, Leonardo

Pending issues before release myfaces core 2.0.1

2010-07-10 Thread Leonardo Uribe
Hi I think we have fixed a lot of issues and we are ready to start a release of myfaces core 2.0.1. If you have any issues to solve before release, this is a good time to say it. best regards, Leonardo Uribe

Re: Pending issues before release myfaces core 2.0.1

2010-07-10 Thread Werner Punz
Am 11.07.10 00:31, schrieb Leonardo Uribe: Hi I think we have fixed a lot of issues and we are ready to start a release of myfaces core 2.0.1. If you have any issues to solve before release, this is a good time to say it. best regards, Leonardo Uribe Hi I have a small issue (not a