Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-23 Thread Bruno Aranda
The thing is that it was an error in the spec for jsf 1.1, followed by the ri and myfaces. This has been fixed in the spec for jsf 1.2 (after we found the mistake in 1.1). Regards, Bruno On 2/22/06, Adam Winer [EMAIL PROTECTED] wrote: I'm puzzled here - is the TCK *really* asserting that this

Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-23 Thread Bruno Aranda
BTW, this is MYFACES-778 [1] Bruno [1] http://issues.apache.org/jira/browse/MYFACES-778 On 2/23/06, Bruno Aranda [EMAIL PROTECTED] wrote: The thing is that it was an error in the spec for jsf 1.1, followed by the ri and myfaces. This has been fixed in the spec for jsf 1.2 (after we found the

Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-22 Thread Bruno Aranda
We used the convertedId javax.faces.DoubleTime, due to an error in the spec (or the javadoc) for JSF 1.1. In JSF 1.2 this has been fixed, but I suggest to use the wrong converterId in 1.1 to pass the TCK and to have the same behaviour than the RI... Regards, Bruno On 2/22/06, [EMAIL PROTECTED]

Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-22 Thread Mario Ivankovits
Bruno Aranda schrieb: We used the convertedId javax.faces.DoubleTime, due to an error in the spec (or the javadoc) for JSF 1.1. In JSF 1.2 this has been fixed, but I suggest to use the wrong converterId in 1.1 to pass the TCK and to have the same behaviour than the RI... Ups, sorry! I just

Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-22 Thread Matthias Wessendorf
As far as I remember, we ran into some issue with the right field... Can you remove it (the right one) and add some javadoc on that. JSF 1.2 has been fixed. I think there is a Jira ticket on that... On 2/22/06, Mario Ivankovits [EMAIL PROTECTED] wrote: Bruno Aranda schrieb: We used the

Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-22 Thread Mario Ivankovits
Hi! As far as I remember, we ran into some issue with the right field... Can you remove it (the right one) and add some javadoc on that. JSF 1.2 has been fixed. I think there is a Jira ticket on that... Ok, I reverted my change - even if its really odd to have to do it ;-) --- Mario

Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-22 Thread Dennis Byrne
Ups, sorry! I just thought it is a easy change as the field CONVERTER_ID will never be used. Do the TCK test directly check this field? This comes up often. Is there any way to incorporate the TCK into the build process? Dennis Byrne

Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-22 Thread Adam Winer
I'm puzzled here - is the TCK *really* asserting that this converter ID is the wrong value? This is clearly a bug in the RI, and the TCK should be asserting the correct value, not covering up the RI bug much less forcing MyFaces to have the same bug! -- Adam On 2/22/06, Dennis Byrne [EMAIL