Hi Andrzej, On Thu, Sep 26, 2019 at 07:24:54PM +0200, Andrzej Kaczmarek wrote: > This looks very good! I was thinking if it would be possible to reference > other targets (i.e. artifacts) from scripts but with the latest addition of > shared folder this does not seem to be a problem since it can be also > shared with another newt build invoked from script and we can copy/write > data there. I did not yet check how this work in practice but will give it > a try and perhaps then I'll have some extra ideas.
Thanks for taking a look! > > post_cmds (run after the build). > > > > ### EXAMPLE > > > > Example (apps/blinky/pkg.yml): > > > > pkg.pre_cmds: > > scripts/pre_build1.sh: 100 > > scripts/pre_build2.sh: 200 > > > > pkg.post_cmds: > > scripts/post_build.sh: 100 > > > > I assume these are relative to package root so perhaps we could assume > there is scripts/ subdir and execute from there by default? Just the same > as we have src/ and include/. I'm reluctant to use an implicit path here. I think it is good to be explicit so that there is no confusion about where a script is located. We use an implicit "targets" path, but I feel like that is easier to justify because it saves the user from constantly typing the same thing. I don't think this custom command feature will be used very often at all, so I am not sure an implicit path would add much in the way of convenience. It's easy to add an implicit path later, but impossible to remove it. Unless you have a strong opinion on this, I suggest we give the feature some time without the implicit path and make the decision later. Thanks, Chris
