Re: Convenience header: mynewt.h

2018-03-27 Thread Christopher Collins
FYI- I have filed a PR implementing this change: https://github.com/apache/mynewt-core/pull/969 Chris On Wed, Mar 21, 2018 at 10:47:14AM -0700, Christopher Collins wrote: > Hello all, > > I was thinking about adding a new header to the core repo that just > includes the (more or less) mandatory

Re: Convenience header: mynewt.h

2018-03-21 Thread Vipul Rahane
Sounds good. +1 - Vipul > On Mar 21, 2018, at 3:45 PM, Wayne Keenan wrote: > > +1 > > Sent from my iPhone > >> On 21 Mar 2018, at 20:15, aditi hilbert wrote: >> >> +1 >> >> aditi >> >>> On Mar 21, 2018, at 10:47 AM, Christopher Collins

Re: Convenience header: mynewt.h

2018-03-21 Thread Wayne Keenan
+1 Sent from my iPhone > On 21 Mar 2018, at 20:15, aditi hilbert wrote: > > +1 > > aditi > >> On Mar 21, 2018, at 10:47 AM, Christopher Collins wrote: >> >> Hello all, >> >> I was thinking about adding a new header to the core repo that just >> includes

Re: Convenience header: mynewt.h

2018-03-21 Thread aditi hilbert
+1 aditi > On Mar 21, 2018, at 10:47 AM, Christopher Collins wrote: > > Hello all, > > I was thinking about adding a new header to the core repo that just > includes the (more or less) mandatory headers: > >* syscfg/syscfg.h >* sysinit/sysinit.h >* os/os.h >

Re: Convenience header: mynewt.h

2018-03-21 Thread Fabien Lepoutre
+1 On Wed, Mar 21, 2018 at 12:12 PM, Miguel Azevedo wrote: > +1 > > On Wed, Mar 21, 2018 at 4:47 PM, Fabio Utzig wrote: > > +1 > > > > On Wed, Mar 21, 2018, at 2:47 PM, Christopher Collins wrote: > >> Hello all, > >> > >> I was thinking about adding a

Re: Convenience header: mynewt.h

2018-03-21 Thread Miguel Azevedo
+1 On Wed, Mar 21, 2018 at 4:47 PM, Fabio Utzig wrote: > +1 > > On Wed, Mar 21, 2018, at 2:47 PM, Christopher Collins wrote: >> Hello all, >> >> I was thinking about adding a new header to the core repo that just >> includes the (more or less) mandatory headers: >> >> *

Convenience header: mynewt.h

2018-03-21 Thread Christopher Collins
Hello all, I was thinking about adding a new header to the core repo that just includes the (more or less) mandatory headers: * syscfg/syscfg.h * sysinit/sysinit.h * os/os.h * defs/error.h The rule of thumb would be: just include "mynewt.h" in every file. I think this would