[GitHub] skystar-p opened a new pull request #61: [NEMO-20] RESTful APIs to Access Job State and Metric

2018-07-02 Thread GitBox
skystar-p opened a new pull request #61: [NEMO-20] RESTful APIs to Access Job State and Metric URL: https://github.com/apache/incubator-nemo/pull/61 JIRA: [NEMO-20: RESTful APIs to Access Job State and Metric](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-20) **Major chan

[GitHub] seojangho opened a new pull request #62: [NEMO-71] Add LocationShareAssignmentPass and Example Application

2018-07-02 Thread GitBox
seojangho opened a new pull request #62: [NEMO-71] Add LocationShareAssignmentPass and Example Application URL: https://github.com/apache/incubator-nemo/pull/62 JIRA: [NEMO-71: Add LocationShareAssignmentPass and Example Application](https://issues.apache.org/jira/projects/NEMO/issues/NEMO

[GitHub] seojangho commented on issue #62: [NEMO-71] Add LocationShareAssignmentPass and Example Application

2018-07-02 Thread GitBox
seojangho commented on issue #62: [NEMO-71] Add LocationShareAssignmentPass and Example Application URL: https://github.com/apache/incubator-nemo/pull/62#issuecomment-401712182 Let #61 be merged before reviewing this PR. This

[GitHub] shpark opened a new pull request #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
shpark opened a new pull request #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63 JIRA: [NEMO-124: Support DoFn#output(tag, output)](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-124) **Major changes:** - Support Pa

[GitHub] wynot12 opened a new pull request #64: [NEMO-104] Move /tests/client into /client/test

2018-07-02 Thread GitBox
wynot12 opened a new pull request #64: [NEMO-104] Move /tests/client into /client/test URL: https://github.com/apache/incubator-nemo/pull/64 JIRA: [NEMO-104: Move /tests/client into /client/tests](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-104) **Major changes:** -

[GitHub] johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63#discussion_r199433142 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/OutputCollectorImpl.j

[GitHub] johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63#discussion_r199432811 ## File path: common/src/main/java/edu/snu/nemo/common/ir/vertex/executionproperty/AdditionalOutputProperty.j

[GitHub] johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63#discussion_r199432427 ## File path: examples/beam/src/main/java/edu/snu/nemo/examples/beam/AdditionalOutputs.java ## @@ -

[GitHub] johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63#discussion_r199429645 ## File path: examples/beam/src/main/java/edu/snu/nemo/examples/beam/AdditionalOutputs.java ## @@ -

[GitHub] johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63#discussion_r199431396 ## File path: common/src/main/java/edu/snu/nemo/common/ir/vertex/executionproperty/AdditionalOutputProperty.j

[GitHub] johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63#discussion_r199431461 ## File path: common/src/main/java/edu/snu/nemo/common/ContextImpl.java ## @@ -25,14 +25,16 @@ */

[GitHub] johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
johnyangk commented on a change in pull request #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63#discussion_r199430715 ## File path: compiler/frontend/beam/src/main/java/edu/snu/nemo/compiler/frontend/beam/NemoPipelineVisitor.ja

[GitHub] shpark commented on issue #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
shpark commented on issue #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63#issuecomment-401747693 Thanks for you review! I've renamed classes and arguments updated comments -

[GitHub] shpark edited a comment on issue #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
shpark edited a comment on issue #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63#issuecomment-401747693 Thanks for your review! I've renamed classes and arguments updated comments

[GitHub] wynot12 opened a new pull request #65: [NEMO-106] Move /tests/compiler into /compiler/test

2018-07-02 Thread GitBox
wynot12 opened a new pull request #65: [NEMO-106] Move /tests/compiler into /compiler/test URL: https://github.com/apache/incubator-nemo/pull/65 JIRA: [NEMO-106: Move /tests/compiler into /compiler/test](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-106) **Major changes:

[GitHub] johnyangk closed pull request #63: [NEMO-124] Support DoFn#output(tag, output)

2018-07-02 Thread GitBox
johnyangk closed pull request #63: [NEMO-124] Support DoFn#output(tag, output) URL: https://github.com/apache/incubator-nemo/pull/63 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[GitHub] johnyangk opened a new pull request #66: 54 fetch fail

2018-07-02 Thread GitBox
johnyangk opened a new pull request #66: 54 fetch fail URL: https://github.com/apache/incubator-nemo/pull/66 JIRA: [NEMO-##: TITLE](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-##) **Major changes:** - **Minor changes to note:** - **Tests for the cha

[GitHub] johnyangk closed pull request #66: 54 fetch fail

2018-07-02 Thread GitBox
johnyangk closed pull request #66: 54 fetch fail URL: https://github.com/apache/incubator-nemo/pull/66 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork

[GitHub] johnyangk opened a new pull request #67: [NEMO-54] Handle remote data fetch failures due to executor removal

2018-07-02 Thread GitBox
johnyangk opened a new pull request #67: [NEMO-54] Handle remote data fetch failures due to executor removal URL: https://github.com/apache/incubator-nemo/pull/67 JIRA: [NEMO-54: Handle remote data fetch failures due to executor removal](https://issues.apache.org/jira/projects/NEMO/issues/

[GitHub] seojangho commented on a change in pull request #67: [NEMO-54] Handle remote data fetch failures due to executor removal

2018-07-02 Thread GitBox
seojangho commented on a change in pull request #67: [NEMO-54] Handle remote data fetch failures due to executor removal URL: https://github.com/apache/incubator-nemo/pull/67#discussion_r199696813 ## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/task/Paren

[GitHub] johnyangk commented on issue #67: [NEMO-54] Handle remote data fetch failures due to executor removal

2018-07-02 Thread GitBox
johnyangk commented on issue #67: [NEMO-54] Handle remote data fetch failures due to executor removal URL: https://github.com/apache/incubator-nemo/pull/67#issuecomment-402029995 Thanks @seojangho. I've addressed your comment. ---

[GitHub] wonook closed pull request #64: [NEMO-104] Move /tests/client into /client/test

2018-07-02 Thread GitBox
wonook closed pull request #64: [NEMO-104] Move /tests/client into /client/test URL: https://github.com/apache/incubator-nemo/pull/64 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[Proposal] Adding editorconfig

2018-07-02 Thread JaeHyeon
Editorconfig(https://editorconfig.org/) is a config file that contains file format defining coding style, such as `trim_trailing_whitespace` option to remove trailing whitespace of the code, which is redundant. Also, options can be applied seperately between different file formats. For example, we