Re: Manipulating System Classpath with NetBeans (OpenJFX assumes classes can be loaded by FindClass)

2021-04-06 Thread Matthias Bläsing
Hi Antonio, Am Dienstag, den 06.04.2021, 23:24 +0200 schrieb antonio: > In which module is System.loadLibrary being invoked? Does that module > depend on any other module that exports the class The JPMS module is the UNNAMED module (we load OpenJFX on the classpath), for NetBeans modules the mo

Re: [External] : Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Geertjan Wielenga
Here's the Beta 2: https://ci-builds.apache.org/job/Netbeans/job/netbeans-TLP/job/netbeans/job/release124/4/ Before we sign everything and start a voting thread, please check the convenience binary in the above to verify that it now solves the problem? Gj On Tue, Apr 6, 2021 at 7:04 PM Martin Ba

Re: Manipulating System Classpath with NetBeans (OpenJFX assumes classes can be loaded by FindClass)

2021-04-06 Thread antonio
D'oh, If they're calling that from a native thread then they're probably missing a call to "jvm->AttachCurrentThread(...)" / "jvm->DetachCurrentTrhead(...)" somewhere too. https://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html "Attaching to the VM The JNI interface

Re: Manipulating System Classpath with NetBeans (OpenJFX assumes classes can be loaded by FindClass)

2021-04-06 Thread antonio
Hi Matthias, In which module is System.loadLibrary being invoked? Does that module depend on any other module that exports the class "com/sun/webkit/FileSystem"? Is that class exposed in a public API? I think that's the way forward. Cheers, Antonio El 6/4/21 a las 22:36, Matthias Bläsing es

[DISCUSS] [CND] Clank

2021-04-06 Thread antonio
Hi all, It seems the CND cluster is using a library called Clank (cnd/libs.clank). This seems to be a Java wrapper around clang, which was presented at "2017 European LLVM Developers Meeting" [1] Quoting: "The Java port of native Clang. The goal was to get the Java code as close to the orig

Manipulating System Classpath with NetBeans (OpenJFX assumes classes can be loaded by FindClass)

2021-04-06 Thread Matthias Bläsing
Hi NetBeans modules system experts, I'm trying to fix OpenJFX in NetBeans without changing the native code of OpenJFX. I observed, that OpenJFX on NetBeans fails with a segfault when a "normal" Webpage (https://netbeans.apache.org) is loaded. I could it track down to this code: https://github.com

Re: [External] : Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Martin Balin
I’ve seen Neil prepared PR release124 with Svata commit. I think that’s all for the moment for Beta2 Thanks’ Martin On 6 Apr 2021, at 17:34, Geertjan Wielenga mailto:geertjan.wiele...@googlemail.com.INVALID>> wrote: I've merged it, but now it's in master. I believe it needs to be in release124

Re: [External] : Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Martin Balin
Will be prepared, master -> release124 Martin On 6 Apr 2021, at 17:34, Geertjan Wielenga mailto:geertjan.wiele...@googlemail.com.INVALID>> wrote: I've merged it, but now it's in master. I believe it needs to be in release124 branch, too. Can you do that? Gj On Tue, Apr 6, 2021 at 5:30 PM Mart

Re: Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Geertjan Wielenga
I think we should add nothing beyond the one specific pr for which we're doing the second beta. Gj On Tue, Apr 6, 2021 at 5:44 PM Neil C Smith wrote: > On Tue, 6 Apr 2021 at 16:37, Geertjan Wielenga > wrote: > > > > Yes, how to get the pull request I merged into master to be in > release124? >

Re: Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Neil C Smith
On Tue, 6 Apr 2021 at 16:37, Geertjan Wielenga wrote: > > Yes, how to get the pull request I merged into master to be in release124? https://github.com/apache/netbeans/pull/2866 Needs a PR with base as release124 from master. Same as we did during 12.3 (and will do for 12.4 after freeze) from d

Re: Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Geertjan Wielenga
Yes, how to get the pull request I merged into master to be in release124? Gj On Tue, Apr 6, 2021 at 5:35 PM Neil C Smith wrote: > On Tue, 6 Apr 2021 at 16:12, Geertjan Wielenga > wrote: > > In light of events today, and especially this: > > > > https://github.com/apache/netbeans/pull/2864 > >

Re: Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Neil C Smith
On Tue, 6 Apr 2021 at 16:12, Geertjan Wielenga wrote: > In light of events today, and especially this: > > https://github.com/apache/netbeans/pull/2864 Events today? Just that? > I propose we (i.e., Neil and I) put together Beta 2 (which we had not > planned for but again to support VSNetBeans)

Re: [External] : Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Geertjan Wielenga
I've merged it, but now it's in master. I believe it needs to be in release124 branch, too. Can you do that? Gj On Tue, Apr 6, 2021 at 5:30 PM Martin Balin wrote: > Hi, > Thanks’ for considering Beta rebuild for this. I support Beta 2. > It will definitely make live of NetBeans in VSCode easier

Re: [External] : Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Martin Balin
Hi, Thanks’ for considering Beta rebuild for this. I support Beta 2. It will definitely make live of NetBeans in VSCode easier. Martin On 6 Apr 2021, at 17:12, Geertjan Wielenga mailto:geert...@apache.org>> wrote: Hi all, In light of events today, and especially this: https://urldefense.com/v3

Apache NetBeans 12.4 Beta 2?

2021-04-06 Thread Geertjan Wielenga
Hi all, In light of events today, and especially this: https://github.com/apache/netbeans/pull/2864 I propose we (i.e., Neil and I) put together Beta 2 (which we had not planned for but again to support VSNetBeans) and that we use that for voting purposes. How does this sound -- or is that not

Re: [External] : Re: 12.4 Beta 1 is available

2021-04-06 Thread Martin Balin
Hi, I’ve found the issue with Gradle experimental new option in 12.4 Beta1, right after I’ve sent +1 vote there ;-) As Laszlo wrote in his announcement for new feature "Gradle Project Loading Changes, Call for Test/Review” on Mar 29th “...my aim is to deliver the code with the feature switched o

Fwd: [NOTICE] Upcoming changes to project web sites hosted via Git

2021-04-06 Thread antonio
Hi all, We'll need to modify the current mechanism for updating the NetBeans website. Deadline is June the 1st. Maybe it's a good time to revamp/redesign the site and/or even review the current publishing mechanism. IIRC we had some fancy desktop designs (no mobile) without any SCSS counterp

Re: [DISCUSS] github: Disable squash-and-merge button

2021-04-06 Thread Neil C Smith
On Tue, 6 Apr 2021, 08:15 antonio, wrote: > c) Otherwise we committers can squash using the command line with the > detailed instructions that Matthias suggested on 2019-12-12 ([1]). > > Am I understading this correctly? > Ideally not from step 14. Instead, git push -f to the pull request, then

Re: [DISCUSS] github: Disable squash-and-merge button

2021-04-06 Thread antonio
Hi, So, if I understand correctly: a) It's ok to use the squash-and-merge button if contributors have proper github/email addresses in their github profile (is this so? or do we want to disable it completely?). b) Otherwise we prefer that contributors squash themselves (git rebase -i) and u