Thanks for all of your work on merging the PRs and closing the relevant JIRA
issues.
Josh Juneau
juneau...@gmail.com
http://jj-blogger.blogspot.com
https://www.apress.com/us/search?query=Juneau
> On Jul 3, 2019, at 5:16 AM, Neil C Smith wrote:
>
> On Wed, 3 Jul 2019 at 10:13, Neil C Smith wr
On Wed, Jul 3, 2019 at 1:32 PM Neil C Smith wrote:
> On pending PRs the following look like possible NB11.1 candidates
> although are not marked as such - any thoughts?
>
> https://github.com/apache/netbeans/pull/1325
> https://github.com/apache/netbeans/pull/1342
FWIW, I think the two above ar
On Wed, 3 Jul 2019 at 13:03, Neil C Smith wrote:
>
> On Wed, 3 Jul 2019 at 13:00, Eric Barboni wrote:
> > Is it possible to consider this one for 11.1. As the ecosystem of maven
> > plugins/archetype is now ready. This may help.
> > Should I tag the PR ?
> >
> > https://github.com/apache/netb
On Wed, 3 Jul 2019 at 13:00, Eric Barboni wrote:
> Is it possible to consider this one for 11.1. As the ecosystem of maven
> plugins/archetype is now ready. This may help.
> Should I tag the PR ?
>
> https://github.com/apache/netbeans/pull/1324
OK, looking now. Missed it because the NB11.1 l
19 11:09
À : dev
Objet : Re: 11.1 beta-3 status
On Tue, 2 Jul 2019 at 23:00, Geertjan Wielenga wrote:
>
> PS: Sorry, wasn't aware you requested to be added as reviewer to the
> nb11.1 tagged PRs, would have done so if I had known, can still do so,
> if you like. I think everythi
On Wed, 3 Jul 2019 at 12:44, Geertjan Wielenga wrote:
> Agreed, and all by or approved by jlahoda, so as safe as can be.
My thoughts exactly! :-)
Created the sync PR - https://github.com/apache/netbeans/pull/1353
Full list of changes from beta2 to beta3 there. Hopefully nothing
missing!
Time f
Agreed, and all by or approved by jlahoda, so as safe as can be.
Gj
On Wed, 3 Jul 2019 at 13:32, Neil C Smith wrote:
> On pending PRs the following look like possible NB11.1 candidates
> although are not marked as such - any thoughts?
>
> https://github.com/apache/netbeans/pull/1325
> https://g
On pending PRs the following look like possible NB11.1 candidates
although are not marked as such - any thoughts?
https://github.com/apache/netbeans/pull/1325
https://github.com/apache/netbeans/pull/1342
https://github.com/apache/netbeans/pull/1352
Best wishes,
Neil
On Wed, 3 Jul 2019 at 11:30, Geertjan Wielenga wrote:
> I think both those two PRs you list can be merged at this point — and
> rolled back if needed prior to the vc which (I believe) is the next one
> after beta-3.
Both are merged. Although I preferred to wait for Travis to go green,
which it d
Yes, will do re stale branches.
I think both those two PRs you list can be merged at this point — and
rolled back if needed prior to the vc which (I believe) is the next one
after beta-3.
Gj
On Wed, 3 Jul 2019 at 12:16, Neil C Smith wrote:
> On Wed, 3 Jul 2019 at 10:13, Neil C Smith wrote:
>
On Wed, 3 Jul 2019 at 10:13, Neil C Smith wrote:
> Looking through and merging now.
OK, all bar two merged to master, and relevant JIRA issues marked resolved.
The two pending are -
https://github.com/apache/netbeans/pull/1285
https://github.com/apache/netbeans/pull/1338
The first is still wai
On Tue, 2 Jul 2019 at 23:01, Laszlo Kishalmi wrote:
> I'm sorry, my bad (as I had a free weekend to form a few PR-s).
Not a bad! :-)
Looking through and merging now. Unfortunately, having been away
since last beta, I'm somewhat behind on merging for this one - no
travels between now and release
On Tue, 2 Jul 2019 at 23:00, Geertjan Wielenga wrote:
>
> PS: Sorry, wasn't aware you requested to be added as reviewer to the nb11.1
> tagged PRs, would have done so if I had known, can still do so, if you
> like. I think everything tagged as nb11.1 is really important to include in
> 11.1, have
I'm sorry, my bad (as I had a free weekend to form a few PR-s).
On 7/2/19 2:00 PM, Neil C Smith wrote:
On Tue, 2 Jul 2019 at 20:06, Geertjan Wielenga wrote:
I reckon we can save him time and merge them ourselves, if we or anyone
hasn't yet at the time he gets to it, he'll do the remaining ones
PS: Sorry, wasn't aware you requested to be added as reviewer to the nb11.1
tagged PRs, would have done so if I had known, can still do so, if you
like. I think everything tagged as nb11.1 is really important to include in
11.1, have tried to keep them to a minimum though.
On Tue, Jul 2, 2019 at 1
Makes sense, thanks!
Gj
On Tue, Jul 2, 2019 at 11:01 PM Neil C Smith wrote:
> On Tue, 2 Jul 2019 at 20:06, Geertjan Wielenga
> wrote:
> > I reckon we can save him time and merge them ourselves, if we or anyone
> > hasn't yet at the time he gets to it, he'll do the remaining ones that
> are
> >
On Tue, 2 Jul 2019 at 20:06, Geertjan Wielenga wrote:
> I reckon we can save him time and merge them ourselves, if we or anyone
> hasn't yet at the time he gets to it, he'll do the remaining ones that are
> marked for nb11.1.
I've just had a quick look over and seems we have quite a few new ones
I reckon we can save him time and merge them ourselves, if we or anyone
hasn't yet at the time he gets to it, he'll do the remaining ones that are
marked for nb11.1.
Gj
On Tue, Jul 2, 2019 at 9:04 PM Laszlo Kishalmi
wrote:
> BTW. Shall we merge the approved PR-s or let Neil have the final decis
BTW. Shall we merge the approved PR-s or let Neil have the final decision?
On 7/2/19 10:55 AM, Geertjan Wielenga wrote:
Very awesome. :-)
Gj
On Tue, Jul 2, 2019 at 7:47 PM Neil C Smith wrote:
Hi,
On Tue, 2 Jul 2019, 18:27 Geertjan Wielenga, wrote:
With Neil doing beta-3 tomorrow, there
Very awesome. :-)
Gj
On Tue, Jul 2, 2019 at 7:47 PM Neil C Smith wrote:
> Hi,
>
> On Tue, 2 Jul 2019, 18:27 Geertjan Wielenga, wrote:
>
> > With Neil doing beta-3 tomorrow, there are a few important PRs marked
> with
> > nb11.1 in the queue:
> >
>
> Thanks. Literally just back home. Will look
Hi,
On Tue, 2 Jul 2019, 18:27 Geertjan Wielenga, wrote:
> With Neil doing beta-3 tomorrow, there are a few important PRs marked with
> nb11.1 in the queue:
>
Thanks. Literally just back home. Will look through and merge things as
required tomorrow morning, and aim to get beta done by close of p
Hi all,
With Neil doing beta-3 tomorrow, there are a few important PRs marked with
nb11.1 in the queue:
https://github.com/apache/netbeans/pulls
I'm leaving these to you to merge, Neil. Unless I'm mistaken in that
impression -- i.e., it's for you to make the final call on whether these
should be
22 matches
Mail list logo
