RE: CI - the final migration (is complete!)

Many thanks for that, Eric -Message d'origine- De : Neil C Smith Envoyé : lundi 5 décembre 2022 14:51 À : Michael Bien Cc : dev@netbeans.apache.org Objet : Re: CI - the final migration (is complete!) Hi, On Mon, 5 Dec 2022 at 07:41, Michael Bien wrote: > > we lost the

Re: CI - the final migration (is complete!)

Hi, On Mon, 5 Dec 2022 at 07:41, Michael Bien wrote: > > we lost the ability to restart travis jobs. So we pretty much have to > merge this now so that the tests remain still usable. > > Planning to merge this today unless someone gives their -1 to this. > Would be good to get a review with a sec

Re: CI - the final migration (is complete!)

we lost the ability to restart travis jobs. So we pretty much have to merge this now so that the tests remain still usable. Planning to merge this today unless someone gives their -1 to this. Would be good to get a review with a second set of eyes though. -mbien On 24.11.22 00:30, Michael Bi

Re: CI - the final migration (is complete!)

Hello again, Just do follow up on this thread: thanks to Svata for finding and fixing an issue in the nb-javac ant task, the LSP test can now also run on github CI. This means all jobs have been migrated! PR is ready to review: https://github.com/apache/netbeans/pull/4817 I added also a ne

Re: CI - the final migration

Not sure this is the answer, but adding a no parameter constructor in NodeChangedParams seems to allow a lot of the unit tests to pass. I made rootId = -1 (it's suppose to be NonNull) and nodeId = null but I question that). I'm sure expert eyes may be able to see something else on this. Eric Br

Re: CI - the final migration

Last one and then let I'll let it be... Running ProjectViewTest.testEmptyPackageRemains() test, I get errors like the below. Could the Groovy aspect associated with Open Gradle Project Loading issues with NetBeans 16 RC-3 #4923 ( https://github.com/apache/netbeans/issues/4923 ) also coming into

Re: CI - the final migration

For the Html4J UI could that be related to this: LSP: Html4J UI modified work over LSP. #4040 https://github.com/apache/netbeans/pull/4040 For the Records not sure if it's in the release (it was merged into master but not for the build I think) there were changes in the Utils.java file as part of

Re: CI - the final migration

Opening the java.lsp.server project (from master) in Netbeans, in the Utils.java file the switch/case statements references "RECORD" and "RECORD_COMPONENT" enums. Assume these are in regardings to Records added in Java 14? Would this break some portion of the build if using an older java version?

Re: CI - the final migration

Not an expert on this but thoughts I'd note some observations from the log just in case it may help. - Don't think this is really a concern but there unable to find revision info -do-set-buildnumber: 1322

Re: CI - the final migration

Awesome Svata! On 05.11.22 20:28, Svata Dedic wrote: Hi, please temporarily disable the java.lsp.server test in the main suite, no need yet since the job is still on travis. I will take the #4921 over next week. if you could use #4921 as template and take a look where the issue is I can

Re: CI - the final migration

Hi, please temporarily disable the java.lsp.server test in the main suite, I will take the #4921 over next week. Great job with the migration ! -Svata On 05. 11. 22 19:18, Michael Bien wrote: Hi devs, at first we weren't sure if we should migrate all travis jobs to github, then we weren't

CI - the final migration

Hi devs, at first we weren't sure if we should migrate all travis jobs to github, then we weren't sure if we actually can without using up all of apache's resources. Well, those fears/concerns don't matter anymore since we have to finish migration till the end of this year when travis support