Re: Janitor cleans other platform apps caches

2024-08-24 Thread Patrik Karlström
Ok, I just created https://github.com/apache/netbeans/pull/7693 /Patrik Den tors 22 aug. 2024 kl 20:15 skrev Patrik Karlström < pata.karlst...@gmail.com>: > Thanks, I will try. > > Den tors 22 aug. 2024 kl 20:12 skrev Michael Bien : > >> if you open a PR, please base it on the "delivery" branch.

Re: Janitor cleans other platform apps caches

2024-08-22 Thread Patrik Karlström
Thanks, I will try. Den tors 22 aug. 2024 kl 20:12 skrev Michael Bien : > if you open a PR, please base it on the "delivery" branch. There is a > chance to get fixes like this into NB 23 still if they are reviewed in > time. > > -mbien > > > On 22.08.24 16:04, Patrik Karlström wrote: > > I was cu

Re: Janitor cleans other platform apps caches

2024-08-22 Thread Michael Bien
if you open a PR, please base it on the "delivery" branch. There is a chance to get fixes like this into NB 23 still if they are reviewed in time. -mbien On 22.08.24 16:04, Patrik Karlström wrote: I was curious to see if the janitor is supposed to clean abandoned cache dirs for other apps tha

Re: Janitor cleans other platform apps caches

2024-08-22 Thread Michael Bien
Hi Patrik, this looks indeed like it should check the cacheDir - possibly a copy/paste mistake from the block above. would you like to open a PR for this? best regards, -mbien On 22.08.24 16:04, Patrik Karlström wrote: I was curious to see if the janitor is supposed to clean abandoned ca

Janitor cleans other platform apps caches

2024-08-22 Thread Patrik Karlström
I was curious to see if the janitor is supposed to clean abandoned cache dirs for other apps than the current one so I had a look at the code and while doing so I found this line. https://github.com/apache/netbeans/blob/c1ee059fa5772440986a5e51384c20fcfbcd04ce/platform/janitor/src/org/netbeans/mod