RE: SVG Loader visibility in Plugins

2020-03-18 Thread Eirik Bakke
Re: SVG Loader visibility in Plugins On Tue, 17 Mar 2020 at 23:37, Eirik Bakke wrote: > My personal policy is to do everything through GitHub PRs, except > trivial changes in code that I originally wrote myself. (I wrote the > SVG loader module in this case.) IMO we should not be do

Re: SVG Loader visibility in Plugins

2020-03-18 Thread Neil C Smith
On Tue, 17 Mar 2020 at 23:37, Eirik Bakke wrote: > My personal policy is to do everything through GitHub PRs, except trivial > changes in code that I originally wrote myself. (I wrote the SVG loader > module in this case.) IMO we should not be doing straight push to the repo whether inside or o

Re: SVG Loader visibility in Plugins

2020-03-18 Thread Patrik Karlström
he/netbeans/commit/3e4fe382e66f547c50438856081d163a831e73fb > > -Original Message- > From: Eric Barboni > Sent: Tuesday, March 17, 2020 7:38 PM > To: dev@netbeans.apache.org > Subject: RE: SVG Loader visibility in Plugins > > Synchronization PR is created. > > We are under merge w

RE: SVG Loader visibility in Plugins

2020-03-17 Thread Eirik Bakke
, 2020 7:38 PM To: dev@netbeans.apache.org Subject: RE: SVG Loader visibility in Plugins Synchronization PR is created. We are under merge windows close rules. We are supposed not to merge to master. Best Regards Eric -Message d'origine- De : Neil C Smith Envoyé : mercredi 18 mars

RE: SVG Loader visibility in Plugins

2020-03-17 Thread Eric Barboni
Synchronization PR is created. We are under merge windows close rules. We are supposed not to merge to master. Best Regards Eric -Message d'origine- De : Neil C Smith Envoyé : mercredi 18 mars 2020 00:04 À : dev Objet : Re: SVG Loader visibility in Plugins On Tue, 17 Mar 202

RE: SVG Loader visibility in Plugins

2020-03-17 Thread Eirik Bakke
e.) There was a discussion thread about this some years ago (subject "Code contribution process"). Do we have a more recent policy somewhere? -- Eirik -Original Message- From: Neil C Smith Sent: Tuesday, March 17, 2020 7:04 PM To: dev Subject: Re: SVG Loader visibility in Plu

Re: SVG Loader visibility in Plugins

2020-03-17 Thread Neil C Smith
On Tue, 17 Mar 2020, 22:01 Eirik Bakke, wrote: > It's a new, optional module. Yes, we should probably hide it from the > Plugins list; I've done this now [1]. > Direct commit to the repo?! Neil

RE: SVG Loader visibility in Plugins

2020-03-17 Thread Eirik Bakke
20 3:54 PM To: dev@netbeans.apache.org Subject: SVG Loader visibility in Plugins I noticed in my 11.3 based platform application a new 'SVG Loader' plugin. Is that one ment to be visible or would it be ok to add AutoUpdate-Show-In-Client: false to https://github.com/apache/netbeans/

SVG Loader visibility in Plugins

2020-03-17 Thread Patrik Karlström
I noticed in my 11.3 based platform application a new 'SVG Loader' plugin. Is that one ment to be visible or would it be ok to add AutoUpdate-Show-In-Client: false to https://github.com/apache/netbeans/blob/master/platform/openide.util.ui.svg/manifest.mf ? Since I'm not using that one I have exc