[GitHub] incubator-netbeans pull request #63: [NETBEANS-54] Module Review csl.api

GitHub user junichi11 opened a pull request: https://github.com/apache/incubator-netbeans/pull/63 [NETBEANS-54] Module Review csl.api - no external library - checked Rat report: update the license header in csl.api/src/org/netbeans/modules/csl/editor/semantic/Bundle.properties.

[GitHub] incubator-netbeans pull request #61: Repair build failure due to binary hash...

Github user ikysil closed the pull request at: https://github.com/apache/incubator-netbeans/pull/61 ---

Re: New pattern for license converter tool

FWIW, I've changed the tool to accept license headers in the second comment in the file, and changed the limit where the comment must start to 300. This seems to cover about 63 additional files. For the examples-readme.txt, the comment/header detection in such files is tricky. I think the reason

[GitHub] incubator-netbeans pull request #62: [NETBEANS-54] Module Review hibernate

GitHub user ikysil opened a pull request: https://github.com/apache/incubator-netbeans/pull/62 [NETBEANS-54] Module Review hibernate - external binary contains DTDs for Hibernate 3.0 configuration files - changed license headers for files reported by Rat - replacing the

[GitHub] incubator-netbeans pull request #49: [NETBEANS-54] Add license header to bin...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/49 ---

Re: Permissions to edit List of Modules to Review

Done. Gj On Wed, Oct 4, 2017 at 11:19 AM, Illya Kysil wrote: > Hi, > > Could you please add permissions to edit List of Modules to Review for user > ikysil. > https://cwiki.apache.org/confluence/display/NETBEANS/ > List+of+Modules+to+Review > > Thank you in advance > -- >

[GitHub] incubator-netbeans pull request #16: [NETBEANS-54] Module Review db.dataview

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/16 ---

Permissions to edit List of Modules to Review

Hi, Could you please add permissions to edit List of Modules to Review for user ikysil. https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review Thank you in advance -- Illya Kysil -- For a successful technology, reality must take precedence over public relations, for

[GitHub] incubator-netbeans pull request #24: [NETBEANS-54] Module Review db.sql.visu...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/24 ---

[GitHub] incubator-netbeans pull request #50: [NETBEANS-54] Module review diff

Github user matthiasblaesing closed the pull request at: https://github.com/apache/incubator-netbeans/pull/50 ---

[GitHub] incubator-netbeans issue #56: [NETBEANS-54] Module Review editor.errorstripe

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/56 Looks good. ---

[GitHub] incubator-netbeans issue #57: [NETBEANS-54] Module Review parsing.api

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/57 Looks good. ---

[GitHub] incubator-netbeans issue #58: [NETBEANS-54] Module Review parsing.nb

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/58 Looks good. ---

[GitHub] incubator-netbeans issue #60: [NETBEANS-54] Module Review spellchecker

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/60 Looks good. ---

[GitHub] incubator-netbeans issue #61: Repair build failure due to binary hash not ma...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/61 This was already fixed by @jlahoda in 743564d016ca29ee65bc96a631b0ef72d762ad34 ---

[GitHub] incubator-netbeans pull request #61: Repair build failure due to binary hash...

GitHub user ikysil opened a pull request: https://github.com/apache/incubator-netbeans/pull/61 Repair build failure due to binary hash not matching the updated coor… …dinates. [downloadbinaries] Downloading:

[GitHub] incubator-netbeans pull request #60: [NETBEANS-54] Module Review spellchecke...

GitHub user emilianbold opened a pull request: https://github.com/apache/incubator-netbeans/pull/60 [NETBEANS-54] Module Review spellchecker You can merge this pull request into a Git repository by running: $ git pull https://github.com/emilianbold/incubator-netbeans

[GitHub] incubator-netbeans pull request #58: [NETBEANS-54] Module Review parsing.nb

GitHub user emilianbold opened a pull request: https://github.com/apache/incubator-netbeans/pull/58 [NETBEANS-54] Module Review parsing.nb You can merge this pull request into a Git repository by running: $ git pull https://github.com/emilianbold/incubator-netbeans

[GitHub] incubator-netbeans pull request #57: [NETBEANS-54] Module Review parsing.api

GitHub user emilianbold opened a pull request: https://github.com/apache/incubator-netbeans/pull/57 [NETBEANS-54] Module Review parsing.api - No external binaries. - Updated licenses in arch.xml - No additional problems found. You can merge this pull request into a

Re: New pattern for license converter tool

Great! Another similar one is in api.visual/examples-readme.txt. Gj On Wed, Oct 4, 2017 at 5:36 AM, Jan Lahoda wrote: > I think there are two problem with these files: > -the tool only looks for the first comment, and the headers in these files > are in the second comment,

Re: New pattern for license converter tool

I think there are two problem with these files: -the tool only looks for the first comment, and the headers in these files are in the second comment, so the tool won't find it. -the tool only looks for comments that begin in the first 100 characters from the beginning (a safety feature, as a few

New pattern for license converter tool

Hi all, Yesterday at JavaOne, some of us got together to work on the Modules Review and found a new pattern that needs to be handled in the converter tool. The pattern can be found in several hundred files, so we can clean these all up at the same time by twesking the tool for this. Here are

[GitHub] incubator-netbeans pull request #44: Testcases related fixes

Github user rtaneja1 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/44#discussion_r142642889 --- Diff: autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java --- @@ -50,7 +49,7 @@ protected

Podling Report Reminder - October 2017

Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 18 October 2017, 10:30 am PDT. The report for your podling will

[GitHub] incubator-netbeans pull request #44: Testcases related fixes

Github user rtaneja1 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/44#discussion_r142635629 --- Diff: autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java --- @@ -50,7 +49,7 @@ protected

[GitHub] incubator-netbeans pull request #44: Testcases related fixes

Github user rtaneja1 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/44#discussion_r142635505 --- Diff: autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java --- @@ -50,7 +49,7 @@ protected

[GitHub] incubator-netbeans pull request #44: Testcases related fixes

Github user emilianbold commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/44#discussion_r142631994 --- Diff: autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java --- @@ -50,7 +49,7 @@ protected

[GitHub] incubator-netbeans pull request #44: Testcases related fixes

Github user rtaneja1 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/44#discussion_r142630474 --- Diff: autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java --- @@ -50,7 +50,7 @@ protected

[GitHub] incubator-netbeans pull request #56: [NETBEANS-54] Module Review editor.erro...

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/56 [NETBEANS-54] Module Review editor.errorstripe - No external binaries. - Updated licenses in two layer.xml files. - Two unit tests failed:

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/47 I agree the hash is useful (among other things) to verify that the jar from the central is the same. But it is unfortunately not the same in this case. Seems the jar on

[GitHub] incubator-netbeans pull request #55: [NETBEANS-54] Module Review editor.comp...

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/55 [NETBEANS-54] Module Review editor.completion - No external libraries. - Updated licenses in apichanges.xml and a Bundle.properties file as per rat report. - Tests passing.

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/47 You know, I was just thinking how super useful it is to have the hash when switching to Maven Central since at least you know it's the same JAR. How could they differ for the

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/47 @jlahoda I'm sorry... Would you please do that? ---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/47 Please note that this changes fail the build, because the jar from maven central has a different hash. The hash on the central is: DA3584329A263616E277E15462B387ADDD1B208D I