Re: [MODULE REVIEW] - o.eclipse.jgit - Questions

2017-10-10 Thread John McDonnell
That's perfect - Its sort of inline with what I was thinking and had locally but just the 'nosignature' part and the different hash's was confusing me. Thanks for the explaination! John On 11 October 2017 at 06:35, Antonio wrote: > > > On 11/10/17 00:59, John McDonnell wrote: 2.

[GitHub] incubator-netbeans issue #116: [NETBEANS-54] Module Review libs.smack

2017-10-10 Thread vieiro
Github user vieiro commented on the issue: https://github.com/apache/incubator-netbeans/pull/116 So we have a "/home/travis/build/apache/incubator-netbeans/nbbuild/templates/projectized.xml:225: Could not find file /home/travis/build/apache/incubator-netbeans/libs.smack/external/smac

Re: [MODULE REVIEW] - o.eclipse.jgit - Questions

2017-10-10 Thread Antonio
On 11/10/17 00:59, John McDonnell wrote: 2. There's 1 external dependency here: B580E446B543A8DD2F5AA368B07F9C4C9C2E7029 org.eclipse.jgit-3.6.2.201501210735-r_nosignature.jar I'm not sure about the nosignature part, but I can find[1] this version which I guess is the same one, but when I chan

Re: [Mentors] Exclude .template files?

2017-10-10 Thread Junichi Yamamoto
Hi, Regarding comments of PR #52[1], I can understand both opinions. I want to know Apache's rule in those template cases. We just follow it. Personally, I don't think that users want to see it. BTW, templates[2] (e.g. apache20-license.txt) of licenses are shown also in project properties(Right-c

[VOTE] Build #17 as HTML/Java API release 1.5

2017-10-10 Thread Jaroslav Tulach
Hi. Release is dead, long live the release! I believe I have addressed the biggest problems of my previous attempt to release Apache NetBeans HTML/Java API 1.5 and it is time to try once again. Here is the build with source ZIP, MD5 and SHA1 signatures. https://builds.apache.org/view/Incubator%

Re: [Mentors] Exclude .template files?

2017-10-10 Thread Emilian Bold
The discussion from https://github.com/apache/incubator-netbeans/pull/52 should be moved to this thread. > emilianbold commented 7 hours ago • edited > > @matthiasblaesing: so far I have been excluding template files from Rat. They > are user visible as far as I can tell and I don't believe it's

[GitHub] incubator-netbeans pull request #117: [NETBEANS-54] Modeule Review j2ee.pers...

2017-10-10 Thread juneau001
GitHub user juneau001 opened a pull request: https://github.com/apache/incubator-netbeans/pull/117 [NETBEANS-54] Modeule Review j2ee.persistence - JPA external library (Java EE) is used for test entity classes, along with junit - checked Rat report: everything has been relicense

[GitHub] incubator-netbeans issue #52: [NETBEANS-54] Module review xml modules

2017-10-10 Thread emilianbold
Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/52 I really believe this should be discussed on dev@. There are two email threads, one started by me and one by @junichi11 for mentors (which haven't replied). We are not running

[RESULT]: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Jaroslav Tulach
>> Anton Epple : 10.10.17 @ 9:46 << > -1 > I’ll have to change my vote. The new implementation of JSON.java makes use > of ClassValue: > https://docs.oracle.com/javase/7/docs/api/java/lang/ClassValue.html > > Classvalue is not available on Android (or iOS). This prevents porting of > HTML/Java 1.5

Re: How do I assign bug to myself?

2017-10-10 Thread Jaroslav Tulach
thanks. -jt Dne 10. 10. 2017 19:31 napsal uživatel "John McDonnell" < mcdonnell.j...@gmail.com>: > @Jaroslav, this is fixed now, seems I found the option when browsing. > > Because of the way the permissions are based only about Bertrand > Delacretaz, Geertjan Wielenga, Hermien Pellissier, Jiri P

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

2017-10-10 Thread dschoorl
Github user dschoorl commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 I added notice file for jcip-annotations instead of a jcip-license file. I changed the jsr305 license file based on the info in http://wiki.netbeans.org/DevFaqExternalLibraries as pointed

Re: [MODULE REVIEW] - o.eclipse.jgit - Questions

2017-10-10 Thread John McDonnell
>> 1. >> >> The RAT report currently lists: >> >>AL >> /home/jenkins/jenkins-slave/workspace/incubator-netbeans-linux/o.eclipse.jgit/build.xml >>AL >> /home/jenkins/jenkins-slave/workspace/incubator-netbeans-linux/o.eclipse.jgit/external/binaries-list >>AL >> /home/jenkins/jenkins-slave

[GitHub] incubator-netbeans issue #52: [NETBEANS-54] Module review xml modules

2017-10-10 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/52 I get the feeling, that we are running in circles: - Junichi established, that there are templates that already today carry a license header (just the wrong one) (In the I

[GitHub] incubator-netbeans issue #114: [NETBEANS-54] Module Review css.lib

2017-10-10 Thread rosslamont
Github user rosslamont commented on the issue: https://github.com/apache/incubator-netbeans/pull/114 Sorry - should I also add the patch to the rat exclusions? What would the comment be? ---

[GitHub] incubator-netbeans issue #114: [NETBEANS-54] Module Review css.lib

2017-10-10 Thread rosslamont
Github user rosslamont commented on the issue: https://github.com/apache/incubator-netbeans/pull/114 Done. ---

Re: [MODULE REVIEW] - o.eclipse.jgit - Questions

2017-10-10 Thread Antonio
On 10/10/17 22:31, John McDonnell wrote: Hi, So I took on a what I thought would be a quick and simple module to get into this and I have a few questions: Module: https://github.com/apache/incubator-netbeans/tree/master/o.eclipse.jgit 1. The RAT report currently lists: AL /home/jenk

[GitHub] incubator-netbeans issue #116: [NETBEANS-54] Module Review libs.smack

2017-10-10 Thread vieiro
Github user vieiro commented on the issue: https://github.com/apache/incubator-netbeans/pull/116 Note: This project (Apache license) didn't seem to have any notice file. ---

[GitHub] incubator-netbeans pull request #116: [NETBEANS-54] Module Review libs.smack

2017-10-10 Thread vieiro
GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/116 [NETBEANS-54] Module Review libs.smack - Updated maven coordinates. - Passing tests. No license headers missing. - Still awaiting for travis beers. You can merge this pull r

[GitHub] incubator-netbeans issue #114: [NETBEANS-54] Module Review css.lib

2017-10-10 Thread rosslamont
Github user rosslamont commented on the issue: https://github.com/apache/incubator-netbeans/pull/114 My apologies, I assumed tests were part of the default build. Curious: shouldn't travis be running unit tests and picking that up? I will revert the test changes and look into

[GitHub] incubator-netbeans issue #52: [NETBEANS-54] Module review xml modules

2017-10-10 Thread emilianbold
Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/52 @matthiasblaesing: so far I have been excluding template files from Rat. They are user visible as far as I can tell and I don't believe it's good for NetBeans to have that. Maybe there

[MODULE REVIEW] - o.eclipse.jgit - Questions

2017-10-10 Thread John McDonnell
Hi, So I took on a what I thought would be a quick and simple module to get into this and I have a few questions: Module: https://github.com/apache/incubator-netbeans/tree/master/o.eclipse.jgit 1. The RAT report currently lists: AL /home/jenkins/jenkins-slave/workspace/incubator-netbeans

[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces

2017-10-10 Thread vieiro
Github user vieiro commented on the issue: https://github.com/apache/incubator-netbeans/pull/113 It would be nice getting a pair of beers in case of build success! :-D ---

[GitHub] incubator-netbeans pull request #115: [NETBEANS-54] Module Review libs.jvyam...

2017-10-10 Thread vieiro
GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/115 [NETBEANS-54] Module Review libs.jvyamlb - Version 0.2.7 is not available in maven.central - Downgraded to 0.2.6 to see how it behaves in travis build - See issue #82 https:/

Re: How do I assign bug to myself?

2017-10-10 Thread John McDonnell
For simplicities sake, I've made the group 'jira-users' as contributors, since anyone should be able to assign themselves a ticket, not just committers since we'll want others from the community to pick up defects and submit PR's as fixes for these issues. I think this is how they have it on the J

[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces

2017-10-10 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/113 Your wish was already granted - the travis configuration was added to the repository literally hours ago. That's the reason I saw that. :-) ---

[GitHub] incubator-netbeans issue #52: [NETBEANS-54] Module review xml modules

2017-10-10 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/52 @emilianbold @junichi11 given that the html module has a GPLv2/wCPE+CDDL license http://mail-archives.apache.org/mod_mbox/incubator-netbeans-dev/201710.mbox/%3CCAEF8jVfgn

[GitHub] incubator-netbeans pull request #112: [NETBEANS-54] Module Review libs.lucen...

2017-10-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/112 ---

Re: How do I assign bug to myself?

2017-10-10 Thread Matthias Bläsing
Hi, Am Dienstag, den 10.10.2017, 18:31 +0100 schrieb John McDonnell: > @Jaroslav, this is fixed now, seems I found the option when browsing. > > Because of the way the permissions are based only about Bertrand > Delacretaz, Geertjan Wielenga, Hermien Pellissier, Jiri Prox, Jiri > Kovalsky, Svatop

[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces

2017-10-10 Thread vieiro
Github user vieiro commented on the issue: https://github.com/apache/incubator-netbeans/pull/113 Should be ready now. Sorry for the trouble. It would be nice getting a travis warning in case of build failure. ---

[GitHub] incubator-netbeans issue #114: [NETBEANS-54] Module Review css.lib

2017-10-10 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/114 Sorry, but this breaks the unittests. In these the CSS structure is parsed and the result is compared with a reference file. I would do this: - revert the changes to the

[GitHub] incubator-netbeans issue #113: [NETBEANS-54] Module Review libs.xerces

2017-10-10 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/113 Please recheck this as this breaks the build. My local build breaks different than the protocol from travis, but reproducible. To check yourself, please run in the repository:

[GitHub] incubator-netbeans issue #83: [NETBEANS-54] Module Review libs.bytelist

2017-10-10 Thread vieiro
Github user vieiro commented on the issue: https://github.com/apache/incubator-netbeans/pull/83 Just for the records, the issue is https://issues.apache.org/jira/browse/NETBEANS-81 ---

Re: How do I assign bug to myself?

2017-10-10 Thread John McDonnell
@Jaroslav, this is fixed now, seems I found the option when browsing. Because of the way the permissions are based only about Bertrand Delacretaz, Geertjan Wielenga, Hermien Pellissier, Jiri Prox, Jiri Kovalsky, Svatopluk Dedic and myself - and yes, now Jaroslav. Theres about 42-43 people on the

Re: How do I assign bug to myself?

2017-10-10 Thread Geertjan Wielenga
Yes, will take a look, I think everyone who is a committer should be given the same rights. Gj On Tue, 10 Oct 2017 at 18:20, John McDonnell wrote: > Sorry for the double post, > > But looking at the Issue Permissions it seems only users with the > following permissions can be assigned issues: >

Re: How do I assign bug to myself?

2017-10-10 Thread John McDonnell
Sorry for the double post, But looking at the Issue Permissions it seems only users with the following permissions can be assigned issues: Project Role (Contributors) Project Role (Committers) Project Role (Administrators) Project Role (PMC) I'm not sure, maybe its Geertjan who can change your p

Re: How do I assign bug to myself?

2017-10-10 Thread John McDonnell
Hi, I was able to assign it to myself (and un-assign it), but I don't see your username in the list of names when it comes to assigning it to you either - which is strange... John On 10 October 2017 at 18:05, ehsavoie wrote: > Hi, > I think Geertjan as project lead has the rights to enble you t

Re: How do I assign bug to myself?

2017-10-10 Thread ehsavoie
Hi, I think Geertjan as project lead has the rights to enble you to change the assignee on the project. No more rights than you ;) Emmanuel -- Emmanuel Hugonnet http://www.ehsavoie.com http://twitter.com/ehsavoie On Tue, Oct 10, 2017 at 5:35 PM, Jaroslav Tulach wrote: > Hi, > I am tryin

[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

2017-10-10 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 I had to check on personal jenkins to see what I get from junit report. I hope the mutliple commit and rebase were not notified. The report are by clusters in a rat folder in cas

How do I assign bug to myself?

2017-10-10 Thread Jaroslav Tulach
Hi, I am trying to fix https://issues.apache.org/jira/browse/NETBEANS-83 and I'd like to change the assignee to myself. However I can't. Why? It would help if people working on issues to update their status/assignee. -jt

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Geertjan Wielenga
Tried again and the build succeeds. When the problem occurs with the test, it seems like the build hangs, but when I click the terminal window the build continues, takes quite a long time, and after lots of things happening the build completes. Gj On Mon, Oct 9, 2017 at 9:29 AM, Geertjan Wieleng

Re: [build] what's mc-repo.googlecode.com ?

2017-10-10 Thread Bertrand Delacretaz
Hi, Thanks Jaroslav for looking at this! If the http://mc-repo.googlecode.com requirement can be dropped that's a Good Thing IMO. On Tue, Oct 10, 2017 at 2:46 PM, Jaroslav Tulach wrote: > ...the NetBeans maven repository at > http://bits.netbeans.org/maven2/ shall now be responsibility of Apach

Re: [build] what's mc-repo.googlecode.com ?

2017-10-10 Thread Jaroslav Tulach
Thanks for taking look guys. 2017-10-10 12:24 GMT+02:00 Emilian Bold : > What's also odd is that the parent pom has dependencies on NetBeans > RELEASE80 binaries. > This is compile time only (provided) dependency. The HTML/Java API is using using java.util.ServiceLoader discovery mechanism and a

[GitHub] incubator-netbeans issue #114: [NETBEANS-54] Module Review css.lib

2017-10-10 Thread geertjanw
Github user geertjanw commented on the issue: https://github.com/apache/incubator-netbeans/pull/114 Looks great and makes sense not to do anything with that patch and .txt data file. Thanks for this review, great. ---

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Jaroslav Tulach
On úterý 10. října 2017 11:12:48 CEST Emilian Bold wrote: > Since when is a NetBeans library, part of the NetBeans Platform, supposed > to provide iOS and Android compatibility? Since one of the implementation of the Fn.Presenter works on Android and another on iOS. In addition to that there are

[GitHub] incubator-netbeans pull request #114: [NETBEANS-54] Module Review css.lib

2017-10-10 Thread rosslamont
GitHub user rosslamont opened a pull request: https://github.com/apache/incubator-netbeans/pull/114 [NETBEANS-54] Module Review css.lib Added or replaced licenses: - CssTokenId.java - NoteType.java - TokenAcceptorsTest.java - itabbar.css.testfile - all css fi

Re: [build] what's mc-repo.googlecode.com ?

2017-10-10 Thread Emilian Bold
What's also odd is that the parent pom has dependencies on NetBeans RELEASE80 binaries. --emi On Tue, Oct 10, 2017 at 12:33 PM, Bertrand Delacretaz < bdelacre...@apache.org> wrote: > Hi, > > The org.netbeans.html release that was recently prepared refers to, > and downloads lots of stuff from a

[build] what's mc-repo.googlecode.com ?

2017-10-10 Thread Bertrand Delacretaz
Hi, The org.netbeans.html release that was recently prepared refers to, and downloads lots of stuff from a Maven repository at http://mc-repo.googlecode.com Why is that? Getting binaries from strange places is scary. -Bertrand

Re: Podling Report Reminder - October 2017

2017-10-10 Thread Bertrand Delacretaz
On Tue, Oct 10, 2017 at 11:15 AM, Geertjan Wielenga wrote: > ...Didn't think of turning the report into a community thing, I think that's a > great idea, we should I think try to do that next time... Yeah, I think discussing a report draft here helps people reflect on progress, and lowers the rep

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Bertrand Delacretaz
On Tue, Oct 10, 2017 at 11:13 AM, Geertjan Wielenga wrote: > ...maybe all that > needs to be done is updating license headers to Apache and then everything > else, including dealing with GPL binaries, can be done in subsequent > releases If it's GPL dependencies which are not optional I think

[release] adding a DEPENDENCIES file? (was: [VOTE] Release Apache NetBeans HTML/Java API version 1.5)

2017-10-10 Thread Bertrand Delacretaz
On Sun, Oct 8, 2017 at 1:41 PM, Jaroslav Tulach wrote: > ...the build seems to deliver releasable ZIP file: > https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-html4j-release/16/artifact/incubating-netbeans-html4j-1.5.zip > It's md5sum is a45bda33200c208d0d837b0746a7dcce.

Re: Podling Report Reminder - October 2017

2017-10-10 Thread Geertjan Wielenga
Yes, I filled it out based on all the various things that have happened. Didn't think of turning the report into a community thing, I think that's a great idea, we should I think try to do that next time. Gj On Tue, 10 Oct 2017 at 09:03, Bertrand Delacretaz wrote: > On Wed, Oct 4, 2017 at 1:01

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Geertjan Wielenga
Yes, one thing a lot of us are assuming is that everything must be perfect for it to be released. In Apache, that's not the case, but then the question becomes what the minimum requirement of the first release should be -- i.e., maybe all that needs to be done is updating license headers to Apache

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Bertrand Delacretaz
Hi, On Tue, Oct 10, 2017 at 10:57 AM, Jaroslav Tulach wrote: > ... > https://issues.apache.org/jira/browse/NETBEANS-83 > The issue will have to be fixed before new attempt to release 1.5 is made... If that's easy that's cool, but note that during incubation it's perfectly fine to have releases w

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Jaroslav Tulach
Thanks for testing this Geertjan, can you please report a bug (component platform - HTML4J) and add stacktrace of your stalled build in there? Thanks. -jt PS: Why I cannot assign JIRA bugs (like NETBEANS-83) to myself? On pondělí 9. října 2017 9:29:26 CEST Geertjan Wielenga wrote: > I have tes

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Jaroslav Tulach
On úterý 10. října 2017 9:46:18 CEST Anton Epple wrote: > I’ll have to change my vote. The new implementation of JSON.java makes use > of ClassValue: > https://docs.oracle.com/javase/7/docs/api/java/lang/ClassValue.html > > Classvalue is not available on Android (or iOS). This prevents porting of

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Bertrand Delacretaz
On Mon, Oct 9, 2017 at 3:34 AM, John D. Ament wrote: > ...You may want to review the content under > http://www.apache.org/dev/#releases as well... http://www.apache.org/dev/release-publishing.html in particular has good information about how to prepare the release. I also often mention http://

Re: Release, not graduation and md5 was: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Bertrand Delacretaz
On Mon, Oct 9, 2017 at 5:36 AM, John D. Ament wrote: > ...I can't follow any of those links. The fact that they come > through across multiple lines just makes the email harder to follow... Yes, those urldefense links are not usable on a public list. It looks like John has provided the required

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Bertrand Delacretaz
On Sun, Oct 8, 2017 at 1:41 PM, Jaroslav Tulach wrote: > ...It's md5sum is a45bda33200c208d0d837b0746a7dcce. ... While md5 is still commonly used, it is broken today [1] so we should generally move away from it. -Bertrand [1] https://natmchugh.blogspot.ch/2014/10/how-i-created-two-images-with-

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Emilian Bold
Since when is a NetBeans library, part of the NetBeans Platform, supposed to provide iOS and Android compatibility? Actually, why is this even part of the NetBeans Platform? --emi On Tue, Oct 10, 2017 at 10:46 AM, Anton Epple wrote: > -1 > I’ll have to change my vote. The new implementation

Re: Podling Report Reminder - October 2017

2017-10-10 Thread Bertrand Delacretaz
On Wed, Oct 4, 2017 at 1:01 PM, wrote: > ...This should be appended to the Incubator Wiki page at: > https://wiki.apache.org/incubator/October2017 ... I see that someone fleshed up that report, thanks! It would have been good to mention the draft here so as to make the report a community thing

Re: [MENTORS] Information abot Voting process (was: Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5)

2017-10-10 Thread Bertrand Delacretaz
Hi, On Sun, Oct 8, 2017 at 8:59 PM, Matthias Bläsing wrote: > ... * What are the requirements for a positive vote?... The Apache voting process is described at https://www.apache.org/foundation/voting.html The goal is to *build consensus*, not necessarily vote on every decision. Votes are gener

Re: [VOTE] Release Apache NetBeans HTML/Java API version 1.5

2017-10-10 Thread Anton Epple
-1 I’ll have to change my vote. The new implementation of JSON.java makes use of ClassValue: https://docs.oracle.com/javase/7/docs/api/java/lang/ClassValue.html Classvalue is not available on Android (or iOS). This prevents porting of HTML/Java 1.5 to Android (and iOS). Please consider to roll b