Github user vieiro commented on the issue:
https://github.com/apache/incubator-netbeans/pull/131
Should be ready now.
---
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/153
@mclay Thank you for working on it. However, if you come from @emilianbold
's repo (https://github.com/emilianbold/incubator-netbeans), you should send
your PR there. i.e. not `apache:m
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/117
@matthiasblaesing What should we do about the external binary
(https://github.com/apache/incubator-netbeans/tree/master/j2ee.persistence/external)?
---
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/117#discussion_r144731244
--- Diff: j2ee.persistence/test/unit/data/invalid_persistence.xml ---
@@ -1,8 +1,27 @@
-http://www.apache.org/licenses/LICENSE-2.0
Github user mcdonnell-john commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/124#discussion_r144731085
--- Diff:
o.apache.tools.ant.module/src/org/apache/tools/ant/module/resources/Project.xml_
---
@@ -1,4 +1,22 @@
+
GitHub user lbruun opened a pull request:
https://github.com/apache/incubator-netbeans/pull/154
NETBEANS-87 - incorrect warning displayed
Fixes NETBEANS-87
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lbruun/incubator-netbeans
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/135
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/125
---
Github user vieiro commented on the issue:
https://github.com/apache/incubator-netbeans/pull/131
Definitely, expect this whithin 24-48h from now. Sorry & thanks for the
link.
---
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/131
There are a few files were you added the ALv2 at the end of the file. As
most license scanners expect it at the top, it would be good to retain that
assumption. So could you upda
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/151
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/138
---
Hey,
one think I'd really like to see is the ability to close PRs on github
and/or add labels to PRs. I just noticed, that I revisited the same PR
for the third time, because I could not close it.
Maybe gitbox could help there?
Greetings
Matthias
Am Samstag, den 14.10.2017, 14:46 +0200 schrie
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/123
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/115
---
Github user matthiasblaesing commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/124#discussion_r144725205
--- Diff:
o.apache.tools.ant.module/src/org/apache/tools/ant/module/resources/Project.xml_
---
@@ -1,4 +1,22 @@
+
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/149
---
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/150
I squashed the changes together. The binaries differ in the sigining
information:
https://try.diffoscope.org/verbgtdavxyv.html
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/150
---
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/73
@varaghar sorry - the fix for this file was merged via a bigger changeset,
that tackled to problem for all build.xml files. Would you please close this
PR? Thank you!
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/7
---
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/7
Merged - thank you!
---
Github user matthiasblaesing commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/104#discussion_r144722875
--- Diff: libs.osgi/external/binaries-list ---
@@ -14,5 +14,5 @@
# KIND, either express or implied. See the License for the
#
> El 15 oct 2017, a las 15:52, Emilian Bold escribió:
>
> PS: Using Maven also helps because http://hg.netbeans.org/binaries/ will
> disappear in the (near) future.
>
>
Ah! This clarifies the question in my previous email: it’s not just about
identifying the procedence & legal status of thir
> El 15 oct 2017, a las 15:50, Emilian Bold escribió:
>
> It's part of the Apache IP clearance. We need to know our dependencies. A
> binary JAR won't do, specifically because we patch stuff too. We can't just
> go through classes and add small license headers when we imports lots and
> lots of
Github user mclay commented on the issue:
https://github.com/apache/incubator-netbeans/pull/153
https://github.com/emilianbold/incubator-netbeans/issues/145
---
Github user geertjanw commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/104#discussion_r144721265
--- Diff: libs.osgi/external/binaries-list ---
@@ -14,5 +14,5 @@
# KIND, either express or implied. See the License for the
# specifi
GitHub user mclay opened a pull request:
https://github.com/apache/incubator-netbeans/pull/153
[NETBEANS-54] Module Review maven.osgi
Cleanup NetBeans license header for module maven.osgi #145
You can merge this pull request into a Git repository by running:
$ git pull https://
Github user geertjanw commented on the issue:
https://github.com/apache/incubator-netbeans/pull/7
Is anything more needed to be done here or can this one be merged?
---
PS: Using Maven also helps because http://hg.netbeans.org/binaries/ will
disappear in the (near) future.
--emi
On Sun, Oct 15, 2017 at 4:50 PM, Emilian Bold
wrote:
> >So, what's the point of adding maven coordinates for external binaries?
> Is this some requirement of the code donation? Or is
>So, what's the point of adding maven coordinates for external binaries? Is
this some requirement of the code donation? Or is this an effort to try to
achieve some kind of "repeteable build" mechanism? (I've arrived late to
the party, so I surely missed the thread where this was discussed).
It's p
Github user geertjanw commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/145#discussion_r144720315
--- Diff:
apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/action/actionListener.javx
---
@@ -1,41 +1,22 @@
-<#--
On 15/10/17 13:30, Emilian Bold wrote:
Should I downgrade binaries to previous versions and leave this for a
future enhancement?
No, don't downgrade binaries. We are not beholden to Maven Central.
I've already have downgraded to previous versions, as Yarda suggested.
So, what's the po
I've noticed this in another email:
Do note that Eclipse doesn't really use Maven Central but
> https://repo.eclipse.org/content/groups/releases/
>
Take a look there too.
I guess if this repo is the canonical source for those JARs we should use
it.
We have the hash to make sure it's the right
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/121
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/148
---
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/122
Merged - I added a commit that fixes the unittests, that were broken by the
added license headers. Reason was: In the unittests offsets into the example
files were used, and thes
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/122
---
Hi all,
Modules "o.eclipse.core.**" contain binaries that are either hard or
impossible to find in Maven central. Some times the versions are not
exactly equal, and I'm not sure if we should downgrade to a previous
version or upgrade to a newest one. We're talking of old binaries
(2012/2013
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/145#discussion_r144712225
--- Diff:
apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/action/actionListener.javx
---
@@ -1,41 +1,22 @@
-<#--
40 matches
Mail list logo
