[GitHub] jlahoda commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache.

2017-10-19 Thread GitBox
jlahoda commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-338107686 Matthias, do you want to first push the tests fix? No problem for me to rebase, check and merge after that.

[GitHub] matthiasblaesing closed pull request #160: [NETBEANS-54] Module Review maven.model

2017-10-19 Thread GitBox
matthiasblaesing closed pull request #160: [NETBEANS-54] Module Review maven.model URL: https://github.com/apache/incubator-netbeans/pull/160 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

Re: VERSION.txt - what is it and can it be removed?

2017-10-19 Thread Jaroslav Tulach
>> Matthias Bläsing : 19.10.17 @ 19:18 << > Hello all, > > while looking into PR 124 I noticed, that VERSION.txt was excluded from > Rat and now I'm wondering whether or not that is a good idea. > > There are validations, that ensure that a VERSION.txt is there, but no > usage of the files. > >

VERSION.txt - what is it and can it be removed?

2017-10-19 Thread Matthias Bläsing
Hello all, while looking into PR 124 I noticed, that VERSION.txt was excluded from Rat and now I'm wondering whether or not that is a good idea. There are validations, that ensure that a VERSION.txt is there, but no usage of the files. So are they garbage and can be removed or why do these exist

Re: Filter mailing list messages

2017-10-19 Thread Michael Nascimento
Don't think so. Simply create a rule to delete from:g...@apache.org and you should be good. Regards, Michael On Thu, Oct 19, 2017 at 3:01 PM, Charles Bedon wrote: > Hello, > > Is there any way (at mailing list config level) to filter the the type > of messages to be received? I ask this because

[GitHub] matthiasblaesing closed pull request #73: [NETBEANS-54] Module Review profiler.j2se

2017-10-19 Thread GitBox
matthiasblaesing closed pull request #73: [NETBEANS-54] Module Review profiler.j2se URL: https://github.com/apache/incubator-netbeans/pull/73 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

Filter mailing list messages

2017-10-19 Thread Charles Bedon
Hello, Is there any way (at mailing list config level) to filter the the type of messages to be received? I ask this because I'm receiving a ton of GitBox notifications about pull requests and the associated comments I'm not interested on. Also, I think it'd be nice if the mailing list admin coul

[GitHub] rasa-app opened a new pull request #166: [NETBEANS-54] Module Review java.j2seplatform

2017-10-19 Thread GitBox
rasa-app opened a new pull request #166: [NETBEANS-54] Module Review java.j2seplatform URL: https://github.com/apache/incubator-netbeans/pull/166 [NETBEANS-54] Module Review java.j2seplatform -no external library -change licence header from Oracle to Apache: java.j2seplatf

[GitHub] emilianbold commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-19 Thread GitBox
emilianbold commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-337929818 I see that external/j2ee.persistence-external-resources.zip files have the standard CDDL + GPL w/ CPE dual license. So, even

[GitHub] juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

2017-10-19 Thread GitBox
juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-337919345 @matthiasblaesing I will look into addressing this situation soon and I will be in touch if I run into any issues. Thanks for

[RESULT]: [VOTE] Build #19 as HTML/Java API release 1.5

2017-10-19 Thread Jaroslav Tulach
Hi NetBeans supporters, thanks for your votes and testing over last 72 hours. I can announce that there was dozen of +1 votes (including one from our mentor Bertrand) and no negative vote. Hear the result: The NetBeans incubator community is ready to release: HTML/Java API 1.5 sources. I am going

[GitHub] junichi11 opened a new pull request #165: [NETBEANS-54] Module Review java.j2semodule

2017-10-19 Thread GitBox
junichi11 opened a new pull request #165: [NETBEANS-54] Module Review java.j2semodule URL: https://github.com/apache/incubator-netbeans/pull/165 Exclude module-info.java.template from rat This is an automated message from the

[GitHub] junichi11 opened a new pull request #164: [NETBEANS-54] Module Review debugger.jpda.ui

2017-10-19 Thread GitBox
junichi11 opened a new pull request #164: [NETBEANS-54] Module Review debugger.jpda.ui URL: https://github.com/apache/incubator-netbeans/pull/164 - no external library - checked Rat report: add the license header to genfiles.properties and README.txt - skimmed through the module, did

Re: Merging of pull requests is possible again.

2017-10-19 Thread Geertjan Wielenga
PS: for those, like me, who had upstream set to git:// git.apache.org/incubator-netbeans.git, please note that upstream can be moved to gitbox.apache.org/repos/asf/incubator-netbeans.git or github.com /apache/incubator-netbeans.git. On Thu, Oct 19, 2017 at 10:02 AM, Geertjan Wielenga < geertjan.wi

Merging of pull requests is possible again.

2017-10-19 Thread Geertjan Wielenga
Hi all! GitBox has been set up -- everything we were able to do before can be done still including now for the first time merging from GitHub, if you have set everything up: https://issues.apache.org/jira/browse/INFRA-15271 https://gitbox.apache.org/setup/ There's only around 2000 more files to

[GitHub] geertjanw commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache.

2017-10-19 Thread GitBox
geertjanw commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-337828459 All questions on this have been answered -- should this be merged or should matthiasblaesing comment about

[GitHub] geertjanw commented on issue #156: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource

2017-10-19 Thread GitBox
geertjanw commented on issue #156: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/156#issuecomment-337827796 It appears this branch has conflicts. Can you investigate? --

[GitHub] geertjanw closed pull request #155: Renamed VerifyFileTest class to exclude it from TestSuite run as it depends on deleted resource

2017-10-19 Thread GitBox
geertjanw closed pull request #155: Renamed VerifyFileTest class to exclude it from TestSuite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/155 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is d

[GitHub] geertjanw commented on issue #155: Renamed VerifyFileTest class to exclude it from TestSuite run as it depends on deleted resource

2017-10-19 Thread GitBox
geertjanw commented on issue #155: Renamed VerifyFileTest class to exclude it from TestSuite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/155#issuecomment-337827606 Makes sense and am merging this. --

[GitHub] geertjanw commented on issue #106: Removed failing test UpdateFromNbmTest

2017-10-19 Thread GitBox
geertjanw commented on issue #106: Removed failing test UpdateFromNbmTest URL: https://github.com/apache/incubator-netbeans/pull/106#issuecomment-337827371 Makes sense and am merging this. This is an automated message from th

[GitHub] geertjanw closed pull request #106: Removed failing test UpdateFromNbmTest

2017-10-19 Thread GitBox
geertjanw closed pull request #106: Removed failing test UpdateFromNbmTest URL: https://github.com/apache/incubator-netbeans/pull/106 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] geertjanw commented on issue #44: Testcases related fixes

2017-10-19 Thread GitBox
geertjanw commented on issue #44: Testcases related fixes URL: https://github.com/apache/incubator-netbeans/pull/44#issuecomment-337827113 Merged it. This is an automated message from the Apache Git Service. To respond to the

[GitHub] geertjanw closed pull request #44: Testcases related fixes

2017-10-19 Thread GitBox
geertjanw closed pull request #44: Testcases related fixes URL: https://github.com/apache/incubator-netbeans/pull/44 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reques

[GitHub] geertjanw commented on a change in pull request #44: Testcases related fixes

2017-10-19 Thread GitBox
geertjanw commented on a change in pull request #44: Testcases related fixes URL: https://github.com/apache/incubator-netbeans/pull/44#discussion_r145621717 ## File path: autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java ##