[GitHub] junichi11 closed pull request #202: [NETBEANS-54] Module Review queries

2017-10-29 Thread GitBox
junichi11 closed pull request #202: [NETBEANS-54] Module Review queries URL: https://github.com/apache/incubator-netbeans/pull/202 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] junichi11 closed pull request #201: Remove an unused line

2017-10-29 Thread GitBox
junichi11 closed pull request #201: Remove an unused line URL: https://github.com/apache/incubator-netbeans/pull/201 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reques

Re: [nbusers] Re: how to contact apache regarding gmane?

2017-10-29 Thread thufir
Hello list admin, for gmane to continue with the various netbeans lists, as described below, they need some additional information.  Who would have the subscription information they need, please? thanks, Thufir On 2017-10-26 05:17 AM, Thufir wrote: geertjan, To take on that task I need

Re: Centralized external-binary versions?

2017-10-29 Thread Antonio
On 29/10/17 22:45, Antonio wrote: So I'm afraid we'll have to use repos at eclipse nexus. I'll concentrate on that in the coming days. Will keep you posted. See PR#204 for an example: we could use an "eclipse//" prefix (or a set of prefixes) in the external/binaries_list to download binari

[GitHub] vieiro opened a new pull request #204: Using an eclipse repository for downloads

2017-10-29 Thread GitBox
vieiro opened a new pull request #204: Using an eclipse repository for downloads URL: https://github.com/apache/incubator-netbeans/pull/204 - Modified DownloadBinaries.java to use an eclipse// prefix in a maven coordinate. - Added a maven coordinate to the netbinox module.

Re: Centralized external-binary versions?

2017-10-29 Thread Antonio
Hi, There's no need to modify any dependencies, all should be ok. Sorry for the misunderstanding. The main problem is that many libraries cannot be found in Maven central. I thought we could use the latest binaries that are indeed in Maven central, but after some experiments that's going to

Re: Centralized external-binary versions?

2017-10-29 Thread Matthias Bläsing
Hey Antonio, Am Sonntag, den 29.10.2017, 10:48 +0100 schrieb Antonio: > Currently NetBeans modules define themselves the exact version of > third-party binaries, for instance: > > netbinox depends on org.eclipse.osgi_3.9.1.v20140110-1610 > and > o.eclipse.core.runtime depends on org.eclipse.core

Re: Centralized external-binary versions?

2017-10-29 Thread Antonio Vieiro
Ok. Then let’s go ahead. Expect a PR for netbinox/o.eclipse.equinox.*/o.eclipse.core.* in a few days. Probably upgraded to the latest Eclipse 4.7 binaries. I imagine this is going to require some thorough testing. Cheers, Antonio > El 29 oct 2017, a las 12:11, Geertjan Wielenga > escribió:

Re: Centralized external-binary versions?

2017-10-29 Thread Geertjan Wielenga
Thanks for thinking up this idea and to me it is a good one and makes sense. Gj On Sunday, October 29, 2017, Antonio wrote: > Hi all, > > Currently NetBeans modules define themselves the exact version of > third-party binaries, for instance: > > netbinox depends on org.eclipse.osgi_3.9.1.v20140

Centralized external-binary versions?

2017-10-29 Thread Antonio
Hi all, Currently NetBeans modules define themselves the exact version of third-party binaries, for instance: netbinox depends on org.eclipse.osgi_3.9.1.v20140110-1610 and o.eclipse.core.runtime depends on org.eclipse.core.runtime-3.7.0 Would it be a good idea to specify the exact versions of

Re: Do not use java.net.URL as keys in Maps

2017-10-29 Thread Lars Bruun-Hansen
Thank you for this. Much appreciated. I for one wasn't aware of this. I had to look into the JDK source because I refused to believe you :-) You are right. I've done some basic grepping for "Map[:space:]*<[:space:]*URL" on the NetBeans source code and as I feared this pattern appears all over th