Can pull requests be accepted without ICLA?

2017-11-24 Thread Junichi Yamamoto
Hello, Now, there are some PRs for bugs(Not [NETBEANS-54] Module Review) in GitHub. Some authors may not sign ICLA. Can we merge them without ICLA? Thanks, Junichi

[GitHub] dtrebbien commented on issue #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions

2017-11-24 Thread GitBox
dtrebbien commented on issue #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions URL: https://github.com/apache/incubator-netbeans/pull/253#issuecomment-346915890 Hello @junichi11, I have not signed the ICLA. From a cursory review of the ICLA, I don't like i

[GitHub] junichi11 commented on issue #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions

2017-11-24 Thread GitBox
junichi11 commented on issue #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions URL: https://github.com/apache/incubator-netbeans/pull/253#issuecomment-346910164 @dtrebbien Just one question: Did you send an ICLA[1]? If no, you should send it :) [1] https://www.a

[GitHub] junichi11 closed pull request #288: Fix the license header template for NetBeans modules

2017-11-24 Thread GitBox
junichi11 closed pull request #288: Fix the license header template for NetBeans modules URL: https://github.com/apache/incubator-netbeans/pull/288 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] junichi11 closed pull request #290: Add .gitattributes file to repo

2017-11-24 Thread GitBox
junichi11 closed pull request #290: Add .gitattributes file to repo URL: https://github.com/apache/incubator-netbeans/pull/290 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

Re: IDE release

2017-11-24 Thread Emilian Bold
If you know db was just an example then you should have understood my message disregarding the particular example. Note that *not releasing* a module is not the same as *removing* a module. I'm confident you will take care of everything. --emi ​ > Original Message >Subject: Re

Re: How to import Netbeans into Netbeans?

2017-11-24 Thread John McDonnell
Maybe something didn't clone correctly? I've updated my local just there and opened the core.network project with and without the required projects checkbox being ticked and didn't have any issues. Regards John On 24 November 2017 at 19:27, Martin Dindoffer wrote: > Hi everyone, > > Is the Apa

[GitHub] dtrebbien commented on a change in pull request #287: Fix 271823 False positive of "Non-null method returns null"

2017-11-24 Thread GitBox
dtrebbien commented on a change in pull request #287: Fix 271823 False positive of "Non-null method returns null" URL: https://github.com/apache/incubator-netbeans/pull/287#discussion_r153026627 ## File path: java.hints/src/org/netbeans/modules/java/hints/bugs/NPECheck.java ###

[GitHub] dtrebbien commented on a change in pull request #287: Fix 271823 False positive of "Non-null method returns null"

2017-11-24 Thread GitBox
dtrebbien commented on a change in pull request #287: Fix 271823 False positive of "Non-null method returns null" URL: https://github.com/apache/incubator-netbeans/pull/287#discussion_r153026637 ## File path: java.hints/src/org/netbeans/modules/java/hints/bugs/NPECheck.java ###

[GitHub] dtrebbien opened a new pull request #292: Two fixes for the "Create Subclass" suggestion

2017-11-24 Thread GitBox
dtrebbien opened a new pull request #292: Two fixes for the "Create Subclass" suggestion URL: https://github.com/apache/incubator-netbeans/pull/292 - "Create Subclass" would think that the caret was out of range in cases like: ```java public/*{*/ class Te^st { } ``

How to import Netbeans into Netbeans?

2017-11-24 Thread Martin Dindoffer
Hi everyone, Is the Apache Netbeans repo supposed to be a netbeans-ready ant project? How should I import the incubator-netbeans into the netbeans? It builds just fine with simple 'ant' command. But when I open it in the ide, all I get is a freeform project "main" with just a build.xml resolved

Re: IDE release

2017-11-24 Thread Matthias Bläsing
Hey, Am Freitag, den 24.11.2017, 02:57 -0500 schrieb Emilian Bold: > There is no such 'resolution'. nb-javac is the only module important > enough to have a first-run/jit installer and we have received a go- > ahead from LEGAL. The go-ahead was *not* for all (L)GPL modules we > might also have in

RE: The IDE build should only hit Apache infra

2017-11-24 Thread Eric Barboni
Hi Emilian, Would it be possible to have the related discussion or legals in the respective ticket ? Sound that some of the ticket maybe invalid later on if netbeans infra move to apache. Regards Eric -Message d'origine- De : Emilian Bold [mailto:emilian.b...@protonmail.ch] Envoyé

Re: Xmas IDE Release Plan Proposal (was Re: Kanban / Scrum / Boards)

2017-11-24 Thread John McDonnell
New Kanban Board setup for the tasks/tickets relating to a Java 9 IDE release: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=219 It's currently empty, for ANY tickets that should be worked on related to this Release can we put in a label 'Java9-IDE' as the filter for the board u

[GitHub] sdedic commented on issue #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions

2017-11-24 Thread GitBox
sdedic commented on issue #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions URL: https://github.com/apache/incubator-netbeans/pull/253#issuecomment-346810951 Looks OK This is an automated message from the

[GitHub] sdedic commented on a change in pull request #287: Fix 271823 False positive of "Non-null method returns null"

2017-11-24 Thread GitBox
sdedic commented on a change in pull request #287: Fix 271823 False positive of "Non-null method returns null" URL: https://github.com/apache/incubator-netbeans/pull/287#discussion_r152951231 ## File path: java.hints/src/org/netbeans/modules/java/hints/bugs/NPECheck.java ##

[GitHub] sdedic commented on a change in pull request #287: Fix 271823 False positive of "Non-null method returns null"

2017-11-24 Thread GitBox
sdedic commented on a change in pull request #287: Fix 271823 False positive of "Non-null method returns null" URL: https://github.com/apache/incubator-netbeans/pull/287#discussion_r152950895 ## File path: java.hints/src/org/netbeans/modules/java/hints/bugs/NPECheck.java ##

[GitHub] sdedic commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting

2017-11-24 Thread GitBox
sdedic commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting URL: https://github.com/apache/incubator-netbeans/pull/173#issuecomment-346803477 I would also prefer to add an user option for the behaviour. Usage of { depends on group's code

[GitHub] lbruun commented on issue #290: Add .gitattributes file to repo

2017-11-24 Thread GitBox
lbruun commented on issue #290: Add .gitattributes file to repo URL: https://github.com/apache/incubator-netbeans/pull/290#issuecomment-346803291 @junichi11. Nice catch. I can add `*.form` but chances are slim that they will ever be anything Unix-style. The NetBeans IDE will always use Uni

The IDE build should only hit Apache infra

2017-11-24 Thread Emilian Bold
Hello, I've posted a few issues about using Apache infra or just removing / disabling modules that won't work under the current Apache legal/infra configuration: * Plugin Portal: https://issues.apache.org/jira/browse/NETBEANS-163 * Usage statistics / gesture collector / error reporter: https://

[GitHub] Chris2011 commented on issue #289: [NETBEANS-126] Replace with trademark free icons

2017-11-24 Thread GitBox
Chris2011 commented on issue #289: [NETBEANS-126] Replace with trademark free icons URL: https://github.com/apache/incubator-netbeans/pull/289#issuecomment-346781985 @neilcsmith-net it was only a suggestionto use a font (they use SVG files too) to get them, convert them to PNG, if we can'