Re: Can pull requests be accepted without ICLA?

2017-11-25 Thread Emilian Bold
It's good to have an ICLA but we might miss valuable contributions by being too bureaucratic. In my view simple PRs don't need an ICLA. This include basic fixes, documentation tweaks, simple features, etc. Don't ask users to expressly send a signed scanned ICLA file. Remember to mention a PGP

Re: JDK & JavaFX versions

2017-11-25 Thread Emilian Bold
I believe we already use Java 8 in NetBeans sources. I remember adding a patch with streams. JavaFX doesn't exist on some platforms like the Raspberry PI ARM builds so I'm not certain it's good to rely on right now. "Pretty soon" though OracleJDK will merge into OpenJDK so I assume this means m

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread Antonio
That's because you're not running the annotation processors. But before digging into that, how are you going to build the patched external binaries NetBeans requires to run? Have you given a thought to that? Cheers, Antonio El 26/11/17 a las 02:28, William L. Thomson Jr. escribió: On Sat, 2

Re: Newbie On Board!!!

2017-11-25 Thread Antonio
Welcome, Ioannis, You may want to take a look at our wiki at Wiki https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65873923 Cheers, Antonio El 26/11/17 a las 00:02, Ioannis Torounoglou escribió: Hello everybody!!! I'm new here willing to help! I don't know where to start a

[GitHub] junichi11 commented on issue #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions

2017-11-25 Thread GitBox
junichi11 commented on issue #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions URL: https://github.com/apache/incubator-netbeans/pull/253#issuecomment-346981556 Hello @dtrebbien, I asked about it via ML, just in case :) https://lists.apache.org/thread.html/73540

Re: Can pull requests be accepted without ICLA?

2017-11-25 Thread Junichi Yamamoto
Thanks a lot for your answers! It seems that iCLA is required in some projects (from Antonio's link). However, it seems that we can merge PRs without ICLA(from Matthias and Geertjan's comments). I thought that contributors should sign an iCLA. Because I needed an OCLA when I provided patches to (

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
On Sat, 25 Nov 2017 12:29:30 -0500 "William L. Thomson Jr." wrote: > > Presently stuck at > > java.lang.AssertionError: Has to be NbRepository: > org.openide.filesystems.Repository@3ab8ef5a > at org.netbeans.core.startup.Main.start(Main.java:281) > at > org.netbeans.core.startup.T

Newbie On Board!!!

2017-11-25 Thread Ioannis Torounoglou
Hello everybody!!! I'm new here willing to help! I don't know where to start and what to do! Any help will be great! J!

JDK & JavaFX versions

2017-11-25 Thread Antonio
Hi all, Would it be ok to use Java 8 for NetBeans sources? Or is there a maximum version? Can we count on JavaFX being installed for the IDE to run? AFAIK JavaFX is not a requirement but, should it be? Thanks, Antonio

[GitHub] lbruun commented on issue #293: [NETBEANS-161] edited some malformed/forgotten license headers

2017-11-25 Thread GitBox
lbruun commented on issue #293: [NETBEANS-161] edited some malformed/forgotten license headers URL: https://github.com/apache/incubator-netbeans/pull/293#issuecomment-346970296 I think all changes in this PR looks good. The reason why #282 didn't find these ones is because it delibe

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread Antonio
Upload one or more resulting jars, for we to review. Our pleasure helping out! :-) El 25/11/17 a las 22:39, William L. Thomson Jr. escribió: On Sat, 25 Nov 2017 22:33:17 +0100 Antonio wrote: Hi, Please upload the result somewhere so we can take a look by tomorrow. Upload what? My repo cha

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
On Sat, 25 Nov 2017 16:48:59 -0500 "William L. Thomson Jr." wrote: > I was missing openide.filesystems.compat8 > > With that I get new errors, proress!!! False alarm... That just caused an exception with asm missing. Once I added that, back to error... g :( java.lang.AssertionError: Has to

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
I was missing openide.filesystems.compat8 With that I get new errors, proress!!! On Sat, 25 Nov 2017 12:29:30 -0500 "William L. Thomson Jr." wrote: > > Presently stuck at > > java.lang.AssertionError: Has to be NbRepository: > org.openide.filesystems.Repository@3ab8ef5a > at org.netbean

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
On Sat, 25 Nov 2017 22:33:17 +0100 Antonio wrote: > Hi, > > Please upload the result somewhere so we can take a look by tomorrow. Upload what? My repo changes or the actual jars produced? I can push out changes. I can send link to live jars on my system. Either way. Thanks for the assistance a

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
On Sat, 25 Nov 2017 22:24:38 +0100 Antonio wrote: > > _ALL_ the files. This includes nested directories and their contents. > META-INF/services/* is key for NetBeans to run. There may be some > other files there as well. Keep the structure as is. I am copying them over as they exist in src/. J

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread Antonio
Hi, Please upload the result somewhere so we can take a look by tomorrow. Cheers, Antonio El 25/11/17 a las 22:29, William L. Thomson Jr. escribió: Fixed warning, but still fails. Thinking something is missing from /usr/share/netbeans-9/config/Modules/ Or its not seeing modules in /usr/share/

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
Fixed warning, but still fails. Thinking something is missing from /usr/share/netbeans-9/config/Modules/ Or its not seeing modules in /usr/share/netbeans-9/modules/ I put the auto files when they exist in /usr/share/netbeans-9/config/ModuleAutoDep/ Not sure but clearly something is missing or

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread Antonio
El 25/11/17 a las 22:09, William L. Thomson Jr. escribió: On Sat, 25 Nov 2017 22:03:06 +0100 Antonio wrote: El 25/11/17 a las 21:46, William L. Thomson Jr. escribió: Great thanks, but that is not needed as much as other stuff. Though I may need to know what modules I should link into a defa

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
On Sat, 25 Nov 2017 22:03:06 +0100 Antonio wrote: > El 25/11/17 a las 21:46, William L. Thomson Jr. escribió: > > Great thanks, but that is not needed as much as other stuff. Though > > I may need to know what modules I should link into a default minimal > > install. Still working on getting that

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread Antonio
El 25/11/17 a las 21:46, William L. Thomson Jr. escribió: Great thanks, but that is not needed as much as other stuff. Though I may need to know what modules I should link into a default minimal install. Still working on getting that started. No UI atm. Though I think I know why. Duplicate entr

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
On Sat, 25 Nov 2017 21:13:26 +0100 Antonio wrote: > > The problem when trying to compile NetBeans modules is handling > dependencies properly. You need to compile some modules before some > others. Yes but that works itself out. As I build one piece, it needs stuff from another. I just keep pac

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread Antonio
Hi, Some comments inlined below. El 25/11/17 a las 20:20, William L. Thomson Jr. escribió: On Sat, 25 Nov 2017 18:59:47 +0100 Antonio wrote: Hi, I'm afraid I'm confused. The subject of your email says "Packaging NetBeans 9 on Gentoo" but then you're not packaging NetBeans 9 on Gentoo, but

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
On Sat, 25 Nov 2017 18:59:47 +0100 Antonio wrote: > Hi, > > I'm afraid I'm confused. > > The subject of your email says "Packaging NetBeans 9 on Gentoo" but > then you're not packaging NetBeans 9 on Gentoo, but packaging > NetBeans in "abnormal ways" using the Gentoo packaging system. > > Why

Re: [nbdev] Re: Packaging Netbeans on Gentoo

2017-11-25 Thread William L. Thomson Jr.
On Sat, 25 Nov 2017 20:21:11 +0200 Emilian Bold wrote: > > I hope you pull it off. And I'm curious if you build becomes any > faster (meaning -- are Gentoo builds parallel with -j or something?). I will, I am determined like that. I am not sure if it will be faster. Yes Gentoo portage can merge m

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
On Sat, 25 Nov 2017 13:15:51 -0500 Emilian Bold wrote: > Antonio, he's not using our ant build system at all. Basically trying > to build NetBeans using only our sources and the Gentool build > scripts/-specific tools. > > It's extra work but doable in the end. Might be interesting if it > works

[GitHub] steffendietz commented on issue #293: [NETBEANS-161] edited some malformed/forgotten license headers

2017-11-25 Thread GitBox
steffendietz commented on issue #293: [NETBEANS-161] edited some malformed/forgotten license headers URL: https://github.com/apache/incubator-netbeans/pull/293#issuecomment-346957135 Maybe @lbruun can review this. :+1: This

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread Emilian Bold
Antonio, he's not using our ant build system at all. Basically trying to build NetBeans using only our sources and the Gentool build scripts/-specific tools. It's extra work but doable in the end. Might be interesting if it works. --emi ​ > Original Message >Subject: Re: Packagi

[GitHub] steffendietz opened a new pull request #293: [NETBEANS-161] edited some malformed/forgotten license headers

2017-11-25 Thread GitBox
steffendietz opened a new pull request #293: [NETBEANS-161] edited some malformed/forgotten license headers URL: https://github.com/apache/incubator-netbeans/pull/293 Hi, I found some files which had malformed license header introducers and thus weren't found by the script of #28

Re: Packaging Netbeans 9 on Gentoo

2017-11-25 Thread Antonio
Hi, I'm afraid I'm confused. The subject of your email says "Packaging NetBeans 9 on Gentoo" but then you're not packaging NetBeans 9 on Gentoo, but packaging NetBeans in "abnormal ways" using the Gentoo packaging system. Why are you packaging NetBeans in "abnormal ways"? What are these "ab

Packaging Netbeans 9 on Gentoo

2017-11-25 Thread William L. Thomson Jr.
Greetings all, Just starting a thread here since I did on the old mailing list. Just to recap for those who missed it. I am packaging Netbeans in abnormal ways using Gentoo packaging system. I am not using Netbeans ant build system. That was in use on Gentoo but is to cumbersome. This new approac

Re: How to import Netbeans into Netbeans?

2017-11-25 Thread Martin Dindoffer
The nbbuild project can be opened with no problems. The build-nozip target on the nbbuild runs OK, but I see no difference. This is how the netbeans project looks like when opened as a whole top level project: https://imgur.com/GIZTkBY The nbbuild project view: https://imgur.com/tph5uyA The Open P

[GitHub] matthiasblaesing commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-25 Thread GitBox
matthiasblaesing commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-346941988 Merged as "trivial fix" without an iCLA. Thanks for looking into this.

[GitHub] asfgit closed pull request #248: adding crlf characters for the failing tests in api.templates

2017-11-25 Thread GitBox
asfgit closed pull request #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

Re: Can pull requests be accepted without ICLA?

2017-11-25 Thread Geertjan Wielenga
Yes. The merging of a PR must be done by a committer, i.e., someone with iCLA, etc, but a PR can be provided by anybody, with or without committer status. Gj On Sat, 25 Nov 2017 at 05:07, Junichi Yamamoto wrote: > Hello, > > Now, there are some PRs for bugs(Not [NETBEANS-54] Module Review) in >

Re: Can pull requests be accepted without ICLA?

2017-11-25 Thread Matthias Bläsing
Hey, Am Samstag, den 25.11.2017, 12:21 +0100 schrieb Antonio: > I would prefer so. Otherwise the contributions should be rejected, IMHO. > > The Apache OFBiz, for example, introduced this policy in 2014, as per [1]. > > Signing the ICLA is very easy, and gives us the confidence that we won't >

Re: Can pull requests be accepted without ICLA?

2017-11-25 Thread Antonio
I would prefer so. Otherwise the contributions should be rejected, IMHO. The Apache OFBiz, for example, introduced this policy in 2014, as per [1]. Signing the ICLA is very easy, and gives us the confidence that we won't be sued in the future because someone is claiming intellectual rights ove

Re: How to import Netbeans into Netbeans?

2017-11-25 Thread John McDonnell
How about opening the nbbuild project? If that opens fine, attempt the 'build-nozip' target (its the same as what you've done from the command line but you never know...). That should build Apache NetBeans 9 ide from sources. From there I would then attempt to try opening up the 'core.network' f

Re: How to import Netbeans into Netbeans?

2017-11-25 Thread Martin Dindoffer
I've thought so as well. But I've cloned twice and deleted the Netbeans cache. Any ideas what could be the culprit? Ant 1.10.1 / Win 2017-11-24 22:58 GMT+01:00 John McDonnell : > Maybe something didn't clone correctly? > > I've updated my local just there and opened the core.network project > wit