[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

2017-10-13 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 parsing xml with file seems to be dangerous for encoding. #144 use InputSource. Seems to fix the issue on my new non UTF-8 image. ---

[GitHub] incubator-netbeans pull request #144: Use InputSource to parse xml avoid enc...

2017-10-13 Thread ebarboni
GitHub user ebarboni opened a pull request: https://github.com/apache/incubator-netbeans/pull/144 Use InputSource to parse xml avoid encoding issue Attempt to fix build due to encoding issue in #70 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

2017-10-13 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 Strange, I wipe and recreate a build base on apache/incubator-netbeans, on a private jenkins (it works). A difference I notice is that encoding on the apache H21,h24 node are iso

[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

2017-10-12 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 @JaroslavTulach #1 I want to merge the exclude from license review otherwise it's conflicting #2 I'm not commiter, I can only propose PR. (Commiter on other Apach

[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

2017-10-12 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 @jtulach or @JaroslavTulach , rebasing of build.xml is annoying. I you prefer I can do a PR only for the ant task will let you put the configuration in build.xml later on ? Let

[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

2017-10-11 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 @jtulach rebased again but rat task have more than only fileset from a PR by @matthiasblaesing ---

[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

2017-10-11 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 @JaroslavTulach I think the WIP is in now in a stable state. Unit report are done for unaprouverd license external library with no maven pattern

[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

2017-10-10 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 I had to check on personal jenkins to see what I get from junit report. I hope the mutliple commit and rebase were not notified. The report are by clusters in a rat folder in

[GitHub] incubator-netbeans pull request #70: WIP custom ant task to produce html rep...

2017-10-09 Thread ebarboni
Github user ebarboni commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/70#discussion_r143516562 --- Diff: nbbuild/build.xml --- @@ -1946,30 +1946,41 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the system in d

[GitHub] incubator-netbeans pull request #70: WIP custom ant task to produce html rep...

2017-10-09 Thread ebarboni
Github user ebarboni commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/70#discussion_r143476986 --- Diff: nbbuild/antsrc/org/netbeans/nbbuild/reporting/RatHtmlReportTask.java --- @@ -0,0 +1,295 @@ +/** + * Licensed to the Apache

[GitHub] incubator-netbeans pull request #70: WIP custom ant task to produce html rep...

2017-10-09 Thread ebarboni
Github user ebarboni commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/70#discussion_r143460566 --- Diff: nbbuild/antsrc/org/netbeans/nbbuild/reporting/ModuleInfo.java --- @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software

[GitHub] incubator-netbeans pull request #70: WIP custom ant task to produce html rep...

2017-10-09 Thread ebarboni
Github user ebarboni commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/70#discussion_r143460531 --- Diff: nbbuild/antsrc/org/netbeans/nbbuild/reporting/RatHtmlReportTask.java --- @@ -0,0 +1,295 @@ +/** + * Licensed to the Apache

[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

2017-10-06 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 build.xml revised. I do a full file xml formating within Netbeans, that was not a good idea. I do a partial formatting and add the exclusion. If merged, the ant task may be updated

[GitHub] incubator-netbeans pull request #70: WIP custom ant task to produce html rep...

2017-10-06 Thread ebarboni
GitHub user ebarboni opened a pull request: https://github.com/apache/incubator-netbeans/pull/70 WIP custom ant task to produce html report from Rat report and NetBeans clusters Hi, this is a more deep integration with Netbeans of the rat report. It filter the

[GitHub] incubator-netbeans pull request #12: properties for by module report

2017-10-03 Thread ebarboni
Github user ebarboni closed the pull request at: https://github.com/apache/incubator-netbeans/pull/12 ---

[GitHub] incubator-netbeans issue #12: properties for by module report

2017-10-03 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/12 closing this PR. Do not want to add false positive to the rat report ---

[GitHub] incubator-netbeans issue #12: properties for by module report

2017-10-02 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/12 @emilianbold , I sorry was trying to resync but this PR is on my master branch so I go back to a usable state. ---

[GitHub] incubator-netbeans issue #15: [NETBEANS-54] Module Review uihandler

2017-09-30 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/15 Done ---

[GitHub] incubator-netbeans issue #15: [NETBEANS-54] Module Review uihandler

2017-09-30 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/15 @matthiasblaesing thanks a lot for pointer on rebase. Hope its better now. ---

[GitHub] incubator-netbeans issue #12: properties for by module report

2017-09-30 Thread ebarboni
Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/12 I'm enhancing my skill on rebase :p, hope its ok now ---

[GitHub] incubator-netbeans-tools pull request #1: licence pattern addition to catch ...

2017-09-28 Thread ebarboni
GitHub user ebarboni opened a pull request: https://github.com/apache/incubator-netbeans-tools/pull/1 licence pattern addition to catch more file (at least one) Hi, this is additionnal pattern for more catch in license conversion. Detected in uihandler. You can merge this pull

[GitHub] incubator-netbeans pull request #15: [NETBEANS-54] Module Review uihandler

2017-09-26 Thread ebarboni
GitHub user ebarboni opened a pull request: https://github.com/apache/incubator-netbeans/pull/15 [NETBEANS-54] Module Review uihandler package.html was not updated by the tools You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-netbeans pull request #12: properties for by module report

2017-09-26 Thread ebarboni
GitHub user ebarboni opened a pull request: https://github.com/apache/incubator-netbeans/pull/12 properties for by module report Hi this is a little modification to allow rat target to report only one folder at a time. I was puzzled by the size of full rat report. Usage