[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

2017-10-01 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 Please have another look at this: - Please ignore the files covered in th "Problems to be solved centrally" of https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Mod

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

2017-10-01 Thread juneau001
Github user juneau001 commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 Thanks for the feedback and sorry for missing those "Problems to be solved centrally". ---

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

2017-10-01 Thread junichi11
Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 #21 was merged. So, it seems that this PR includes the commit for removing the license header for .form files. ---

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

2017-10-02 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 @juneau001 please rereview this changeset - now your PR would remove headers from .form files. While your at it: rebase your changes onto the current HEAD of master and squash the

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

2017-10-02 Thread juneau001
Github user juneau001 commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 @matthiasblaesing Thanks for the note. Very sorry for causing an issue, I thought that you wanted me to remove the license headers from the .form files, per the "Problems to be solved c

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

2017-10-03 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 The problem is that you added the license headers, that conflicted with the central change the @jlahoda kindly did (fixing a great many files). Now your changeset removes these he

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

2017-10-03 Thread matthiasblaesing
Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 Oh - and no reason for apologies! The work is appreciated. ---

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

2017-10-05 Thread juneau001
Github user juneau001 commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 Hi @matthiasblaesing is the code looking okay now? I've done what was mentioned. That is, I rebased changes on to master, reverted my changes to form files and genfiles.properties. Le