Re: [Mentors] Exclude .template files?

2017-10-10 Thread Junichi Yamamoto
Hi, Regarding comments of PR #52[1], I can understand both opinions. I want to know Apache's rule in those template cases. We just follow it. Personally, I don't think that users want to see it. BTW, templates[2] (e.g. apache20-license.txt) of licenses are shown also in project properties(Right-c

Re: [Mentors] Exclude .template files?

2017-10-10 Thread Emilian Bold
The discussion from https://github.com/apache/incubator-netbeans/pull/52 should be moved to this thread. > emilianbold commented 7 hours ago • edited > > @matthiasblaesing: so far I have been excluding template files from Rat. They > are user visible as far as I can tell and I don't believe it's

Re: [Mentors] Exclude .template files?

2017-10-09 Thread Junichi Yamamoto
Hi, > In fact this is already the case in the codebase. The review of the > hibernate module done by Illya Kysil revealed one such file: FYI: The templates of html module also have it. https://github.com/apache/incubator-netbeans/tree/master/html/src/org/netbeans/modules/html/templates I found

Re: [Mentors] Exclude .template files?

2017-10-08 Thread Matthias Bläsing
Hey, Am Sonntag, den 08.10.2017, 13:06 +0300 schrieb Emilian Bold: > I'll verify later how the header become invisible for the end user. If it's > true then we can add the license header, of course. > > > On Sun, Oct 8, 2017 at 12:53 PM, Junichi Yamamoto > wrote: > > > > > I'm confusing a bi

Re: [Mentors] Exclude .template files?

2017-10-08 Thread Emilian Bold
I'll verify later how the header become invisible for the end user. If it's true then we can add the license header, of course. --emi On Sun, Oct 8, 2017 at 12:53 PM, Junichi Yamamoto wrote: > Hello, > > I'm confusing a bit now. Does the license header have to be added to > template files? o

[Mentors] Exclude .template files?

2017-10-08 Thread Junichi Yamamoto
Hello, I'm confusing a bit now. Does the license header have to be added to template files? or Does not it have to be added? e.g. Could you please look at [1], [2]? I also attached screenshots in [1] and [3]. [1] https://github.com/apache/incubator-netbeans/pull/52/files/46357f5118e041b7da21f7