Re: First pull request on main-silver!

2017-01-01 Thread Wade Chandler
On Jan 1, 2017, at 03:28, Matthias Bläsing wrote: > Hello Wade, > > Am Samstag, den 31.12.2016, 23:26 -0500 schrieb Wade Chandler: >> Considering everyone involved has signed both, what is your concern >> which would differ if on hg.netbeans.org or any where else? This >> isn't inherently differe

Re: First pull request on main-silver!

2017-01-01 Thread Matthias Bläsing
Hello Wade, Am Samstag, den 31.12.2016, 23:26 -0500 schrieb Wade Chandler: > Considering everyone involved has signed both, what is your concern > which would differ if on hg.netbeans.org or any where else? This > isn't inherently different if someone added it to hg.netbeans.org > today were they

Re: First pull request on main-silver!

2016-12-31 Thread Emilian Bold
"Matthias Bläsing" > > wrote: > > > > Am Samstag, den 31.12.2016, 20:53 +0200 schrieb Emilian Bold: > > > Chris did the first pull request on main-silver: > > > https://github.com/emilianbold/main-silver/pull/1 > > > > > > We are st

Re: First pull request on main-silver!

2016-12-31 Thread Wade Chandler
er Oracle acquisition, so not sure the difference in this scenario to BZ patch submission. Wade On Dec 31, 2016 8:34 PM, "Matthias Bläsing" wrote: Am Samstag, den 31.12.2016, 20:53 +0200 schrieb Emilian Bold: > Chris did the first pull request on main-silver: > https://github.com/

Re: First pull request on main-silver!

2016-12-31 Thread Matthias Bläsing
Am Samstag, den 31.12.2016, 20:53 +0200 schrieb Emilian Bold: > Chris did the first pull request on main-silver: > https://github.com/emilianbold/main-silver/pull/1 > > We are still working on polishing it and I will have to manually > commit the > patch under my @netbeans.org I

Re: First pull request on main-silver!

2016-12-31 Thread Wade Chandler
Woot woot! Happy New Year! Wade On Dec 31, 2016 1:53 PM, "Emilian Bold" wrote: > Chris did the first pull request on main-silver: > https://github.com/emilianbold/main-silver/pull/1 > > We are still working on polishing it and I will have to manually commit the > pat

First pull request on main-silver!

2016-12-31 Thread Emilian Bold
Chris did the first pull request on main-silver: https://github.com/emilianbold/main-silver/pull/1 We are still working on polishing it and I will have to manually commit the patch under my @netbeans.org ID but this is very nice! Happy New Year! --emi