[GitHub] nifi-registry issue #1: NIFIREG-1 Initial project structure for NiFi Registr...

2017-07-11 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/1 This project structure is a work in progress to begin development and is expected to continue evolving as the project matures, but this should give enough for others to start collaborating

[GitHub] nifi-registry pull request #1: NIFIREG-1 Initial project structure for NiFi ...

2017-07-11 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi-registry/pull/1 NIFIREG-1 Initial project structure for NiFi Registry You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi-registry NIFIREG-1

[GitHub] nifi pull request #608: NIFI-2171 Removing list of groups from User

2016-07-06 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/608 NIFI-2171 Removing list of groups from User - Making FileAuthorizer not update the resource or action when updating an AccessPolicy - Adding corresponding READ policies during initial seeding and

[GitHub] nifi pull request #590: NIFI-2138 Making AccessPolicy have a single RequestA...

2016-06-28 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/590 NIFI-2138 Making AccessPolicy have a single RequestAction You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-2138 Alternatively you

[GitHub] nifi pull request #588: NIFI-2127 Adding support for managing the user-group...

2016-06-28 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/588 NIFI-2127 Adding support for managing the user-group relationship fro… …m the Group side You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende

[GitHub] nifi pull request #581: NIFI-1916 Improvements to FileAuthorizer to not pars...

2016-06-24 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/581 NIFI-1916 Improvements to FileAuthorizer to not parse flow when unnce… …ssary and to recreate missing authorizations.xml You can merge this pull request into a Git repository by running

[GitHub] nifi issue #579: NIFI-1554: Changing process for cluster detection

2016-06-24 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/579 +1 verified build passes contrib-check and was able to get into a secured NiFi instance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #579: NIFI-1554: Changing process for cluster detection

2016-06-24 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/579 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi pull request #578: NIFI-2113 Updating storm dependency to 1.0.1 and fix...

2016-06-24 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/578 NIFI-2113 Updating storm dependency to 1.0.1 and fixing package names This should only be merged to NiFi master, we will leave 0.x using storm 0.10.x. You can merge this pull request into a Git

[GitHub] nifi pull request #574: NIFI-1733 [REVIEW ONLY] Adding a Ranger implementati...

2016-06-24 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/574 NIFI-1733 [REVIEW ONLY] Adding a Ranger implementation of NiFi's Authorizer API This PR is not meant to be merged yet, as it currently is based on a SNAPSHOT dependency of Ranger, but wanted t

[GitHub] nifi issue #567: NIFI-1554: Continuing to incorporate component based author...

2016-06-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/567 +1 looks good, verified full build passes with contrib-check and the new integration test pass, ran the app a bit and verified basic functionality --- If your project is set up for it, you can reply

[GitHub] nifi issue #567: NIFI-1554: Continuing to incorporate component based author...

2016-06-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/567 Will start reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #566: NIFI-2061 Ensure nodes in a cluster use consistent a...

2016-06-23 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/566 NIFI-2061 Ensure nodes in a cluster use consistent authorizations - Added methods to AbstractPolicyBasedAuthorizer to generate and inherit a fingerprint - Updated StandardFlowSynchronizer to

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68075384 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68061144 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67779821 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java --- @@ -0,0 +1,290

[GitHub] nifi issue #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/543 Looks good to me +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-20 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 @rtempleton just merged this work as part of PR 542, thanks for the contribution! can we close this PR? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi pull request #542: NIFI-1895 for 0.x

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/542#discussion_r67718748 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java --- @@ -89,6 +89,25

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67700294 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/put/AbstractPutEventProcessor.java --- @@ -126,8 +127,9

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67698814 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java --- @@ -0,0 +1,270

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67698292 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java --- @@ -0,0 +1,270

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67696982 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/put/AbstractPutEventProcessor.java --- @@ -119,7 +119,24

[GitHub] nifi pull request #543: NIFI-1834 Create PutTCP Processor

2016-06-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/543#discussion_r67697377 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java --- @@ -0,0 +1,270

[GitHub] nifi issue #543: NIFI-1834 Create PutTCP Processor

2016-06-17 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/543 I think the intent behind this processor was to send data over a connection, but not to read anything back. Essentially doing what PutSyslog and PutSplunk are doing when in TCP mode. That

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-17 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 @rtempleton please take a look at https://github.com/apache/nifi/pull/542 I've incorporated your work there with some additional changes which I explained in the PR description. Let me kn

[GitHub] nifi pull request #542: NIFI-1895 for 0.x

2016-06-17 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/542 NIFI-1895 for 0.x This pull request contains @rtempleton 's work from PR 513, but rebased for the 0.x branch. In addition, there is another commit by me which adds a new proper

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-17 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 Reviewing and going to merge into 0.x and master if all looks good... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #518: NIFI-1901: Component based access control tests

2016-06-17 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/518 +1 looks good, verified a full build with contrib-check passes locally --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #535: NIFI-2041: Unable to refresh Controller Services when scope...

2016-06-16 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/535 +1 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi issue #524: NIFI-1781: UI updates

2016-06-13 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/524 +1 looks good, verified all issues fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #507: NIFI-1804 Adding ability for FileAuthorizer to automaticall...

2016-06-13 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/507 @mcgilman good call, I pushed a new commit that addresses your comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-09 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 Thats a great point about leveraging any changes they make to the Bytes class... I'm now thinking, what if we added simple methods to the HBaseClientService interface [1] that wrapped the cal

[GitHub] nifi issue #509: NIFI-1982: Use Compressed check box value.

2016-06-09 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/509 @ijokarumawak you can close this when you get a chance since it has been merged, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-06-09 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 Ryan, thanks for submitting this PR! Is it possible that we could remove the dependency on hbase-client here? The reason being is that the hbase processor bundle purposely didn&#

[GitHub] nifi issue #509: NIFI-1982: Use Compressed check box value.

2016-06-09 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/509 +1 looks good, will merge to 0.x... I am assuming this was only meant for 0.x and the same fix is in your other PR for http site-to-site --- If your project is set up for it, you can reply to this

[GitHub] nifi issue #503: NIFI-1978: Restore RPG yield duration.

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/503 @ijokarumawak I merged to 0.x but GitHub doesn't auto-close from that branch, can you close this PR when you have a chance? Thanks. --- If your project is set up for it, you can reply to this

[GitHub] nifi issue #503: NIFI-1978: Restore RPG yield duration.

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/503 +1 good find, verified the yield duration is maintained across restarts, will merge to 0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi issue #503: NIFI-1978: Restore RPG yield duration.

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/503 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi issue #499: NIFI-1052: Added "Ghost" Processors, Reporting Tasks, Contr...

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/499 +1 code looks good, build passes, tested a missing processor, controller service, and reporting task and the app still starts up, awesome stuff! Will merge into master shortly. --- If your project is

[GitHub] nifi issue #499: NIFI-1052: Added "Ghost" Processors, Reporting Tasks, Contr...

2016-06-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/499 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi issue #498: NIFI-1973 Allow ExecuteSQL to use flow file content as SQL ...

2016-06-07 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/498 +1 This looks good, will merge to master and 0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request #507: NIFI-1804 Adding ability for FileAuthorizer to autom...

2016-06-07 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/507 NIFI-1804 Adding ability for FileAuthorizer to automatically convert … …existing authorized-users.xml to new model You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi issue #489: NIFI-1951: Custom UIs

2016-06-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/489 +1 full build passed contrib-check, ran the app and verified custom UIs still work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi issue #473: NIFI-1916 Updating FileAuthorizer to extend AbstractPolicyB...

2016-06-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/473 @mcgilman updated the PR to address the thread-safety, a summary of the changes... - Created a single data structure to encapsulate all data structures used by the FileAuthorizer so there can be a

[GitHub] nifi issue #482: NIFI-1928: Remove registration

2016-06-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/482 +1 looks good, verified registration form no longer exists and access denied page is presented instead --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi issue #482: NIFI-1928: Remove registration

2016-06-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/482 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-01 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/483 Sorry that second line should have been something like: `split = session.putAttribute(split, "split.parent.uuid", parentUUID);` You wouldn't want to overwrite t

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-01 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/483 @trixpan if you want to add the UUDI of the original FlowFile you would get it from the attributes: `String parentUuid = originalFlowFile.getAttribute(CoreAttributes.UUID.key

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-01 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/483 @joewitt @trixpan I think the provenance linkage should already be happening automatically with the following line: `FlowFile split = session.create(originalFlowFile);` With that call

[GitHub] nifi pull request: NIFI-1916 Updating FileAuthorizer to extend Abs...

2016-05-27 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/473 NIFI-1916 Updating FileAuthorizer to extend AbstractPolicyBasedAuthor… …izer and adding intial loading of data users, groups, and policies - Implementing CRUD operations and unit tests for

[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...

2016-05-24 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/457#issuecomment-221268368 Going to merge this in since Joe was a +1... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...

2016-05-23 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/457#issuecomment-221068355 @joewitt good idea regarding the error handling, i made the suggested changes and and rebased so the commit should now reflect those changes --- If your project is set up

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-23 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-221046683 @mcgilman @jtstorck @alopresto pushed two new commits, the first contains minor changes to address some of Matt's comments, the second is an attempt at what Matt sugg

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-20 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/452#discussion_r64076734 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java --- @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1907 Moving lazy init of SSLContext...

2016-05-20 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/457 NIFI-1907 Moving lazy init of SSLContext... to StandardSiteToSiteClientConfig rather than the builder. Tested secure SiteToSite still working between two NiFi nodes, and now example Storm

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/452#discussion_r63760082 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java --- @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/452#discussion_r63759950 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java --- @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/452#discussion_r63760205 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/Group.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220121052 @alopresto The intent was for the relationship to be bi-directional, meaning you could add a user to a group by adding/updating a User with a new group id in the set of

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-17 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/452 NIFI-1884 Defining API for Users, Groups, and Policies This pull request introduces the concept of a MutableAuthorizer which is an interface that extends the recently introduced Authorizer. A

[GitHub] nifi pull request: NIFI-1858 Adding site-to-site reporting bundle

2016-05-17 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/436#issuecomment-219738116 Since @markap14 has already reviewed this and merged it into 0.x branch, I am going to merge this into master myself so we don't lose track of this. --- If your pr

[GitHub] nifi pull request: NIFI-1554: Introducing component level revision...

2016-05-17 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/448#issuecomment-219736438 +1 Full build passes with contrib-check, was able to create a flow with controller services working as expected. Ran into an issue importing a template with a controller

[GitHub] nifi pull request: NIFI-1742: Initial support for component level ...

2016-05-12 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/435#issuecomment-218813109 +1 Verified component level revisions working as expected, full build passes with contrib-check --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request: NIFI-1742: Initial support for component level ...

2016-05-12 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/435#issuecomment-218805610 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1858 Adding site-to-site reporting bundle

2016-05-12 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/436#issuecomment-218766817 @markap14 here is the corresponding PR for merging the site-to-site reporting bundle into master --- If your project is set up for it, you can reply to this email and

[GitHub] nifi pull request: NIFI-1858 Adding site-to-site reporting bundle

2016-05-12 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/436 NIFI-1858 Adding site-to-site reporting bundle PR for merging this into master. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-12 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/419#issuecomment-218765899 @markap14 thanks, going to close this PR and initiate a new one against master. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-12 Thread bbende
Github user bbende closed the pull request at: https://github.com/apache/nifi/pull/419 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-09 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/419#discussion_r62548156 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-09 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/419#discussion_r62505576 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request: NIFI-1858 Adding SiteToSiteProvenanceReportingT...

2016-05-06 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/419 NIFI-1858 Adding SiteToSiteProvenanceReportingTask You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-1858 Alternatively you can

[GitHub] nifi pull request: NIFI-1781: First pass through updating canvas f...

2016-05-06 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/417#issuecomment-217541758 +1 Looks good, was able to run the app secured and unsecured to verify basic functionality, and build passes contrib-check. --- If your project is set up for it, you can

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-05-03 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/384#issuecomment-216595481 Latest changes look good, I am a +1 again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-05-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61832445 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java --- @@ -52,15 +54,27

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-05-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61832456 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java --- @@ -52,15 +54,27

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-05-02 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/384#issuecomment-216246029 Latest commits look good, I am a +1 and going to merge to 0.x and master --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi pull request: NIFI-1554: Introduction of access controls on c...

2016-04-29 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/393#issuecomment-215872920 I'm a +1... reviewed and looks good, ran the application in secure and un-secure modes to verify functionality, passes contrib-check. --- If your project is set up f

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-29 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61614773 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java --- @@ -0,0 +1,322

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-28 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61502555 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ExecuteHiveQL.java --- @@ -152,8 +152,23

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-28 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/384#issuecomment-215498279 Overall this looks great @mattyb149 ! I was able to get the processors working against kerberized and non-kerberized Hive. I think if we address the one or two minor

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-27 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61343688 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ExecuteHiveQL.java --- @@ -0,0 +1,178

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-27 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61316112 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ExecuteHiveQL.java --- @@ -0,0 +1,178

[GitHub] nifi pull request: NIFI-981: Added ExecuteHiveQL and PutHiveQL pro...

2016-04-27 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/384#discussion_r61317929 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveJdbcCommon.java --- @@ -0,0 +1,272

[GitHub] nifi pull request: NIFI-1554: Introducing new REST endpoints to al...

2016-04-21 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/374#issuecomment-213121166 Pulled down the latest and tested again, all looks good now, app seems to function properly in standalone and clustered mode. I'm a +1 to merge this. --- If

[GitHub] nifi pull request: NIFI-1554: Introducing new REST endpoints to al...

2016-04-21 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/374#issuecomment-213101837 I was testing a 2 node cluster locally and noticed that the part in the toolbar that says Connected Nodes didn't show anything after it, but in the cluster view it s

[GitHub] nifi pull request: NIFI-1554: Introducing new REST endpoints to al...

2016-04-21 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/374#issuecomment-213080400 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1296[REVIEW_ONLY] initial commit of Kafka ...

2016-04-19 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/345#discussion_r60256873 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/AbstractKafkaProcessor.java

[GitHub] nifi pull request: NIFI-1296[REVIEW_ONLY] initial commit of Kafka ...

2016-04-19 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/345#discussion_r60256134 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumeKafka.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1551: Address issue working with Ports

2016-04-19 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/364#issuecomment-211945609 Looks good, verified the change fixes the problem with ports, will push to master --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi pull request: NIFI-1551: Address issue working with Ports

2016-04-19 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/364#issuecomment-211941635 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1783: Load Authorizer

2016-04-19 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/363#issuecomment-211937379 looks good, passes contrib-check, will push to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi pull request: NIFI-1783: Load Authorizer

2016-04-19 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/363#issuecomment-211931551 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

2016-04-19 Thread bbende
Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/361#issuecomment-211928987 @olegz new commit with the validation change and logger.isDebugEnabled() changes --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

2016-04-19 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/361#discussion_r60228292 --- Diff: nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

2016-04-19 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/361#discussion_r60227372 --- Diff: nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

2016-04-19 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/361#discussion_r60227347 --- Diff: nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

2016-04-19 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/361#discussion_r60227326 --- Diff: nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

2016-04-19 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/361#discussion_r60226578 --- Diff: nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

2016-04-18 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/361 NIFI-1778 Adding NiFiBolt to write back to NiFi from Storm - Adding example topology that creates a full loop between NiFi and Storm. - Bumping Storm to 0.10.0 There is an example topology

  1   2   >