[GitHub] nifi pull request: NIFI-989: Support size() operation in distribut...

2015-11-30 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/94#issuecomment-160670895 Ok, so we should wait for the Java 8 migration. We can reopen the PR at any time. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request: NIFI-989: Support size() operation in distribut...

2015-11-30 Thread joemeszaros
Github user joemeszaros closed the pull request at: https://github.com/apache/nifi/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI 945: New property (wrap as array) in avro2...

2015-10-22 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/88#issuecomment-150132380 Thanks for your help! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI 945: New property (wrap as array) in avro2...

2015-10-21 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/88#issuecomment-150033007 I can confirm the amendments, please find my inline comments at the referenced commit. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request: NIFI-988: PutDistributedMapCache processor

2015-10-21 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/92#issuecomment-150028829 Thanks for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request: NIFI 944: Support tab & special delimiter chars...

2015-10-20 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/87#issuecomment-149570327 Updated the code according to your comment. For your second issue: I do not think, that manual restriction of special characters is a good idea, because we

[GitHub] nifi pull request: NIFI-988: PutDistributedMapCache processor

2015-10-20 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/92#issuecomment-149458834 @markap14 Do you have any concern with this new processor? It is still open for a while and it would be grateful, if we could finish it by merging or closing the PR

[GitHub] nifi pull request: NIFI-1016: Use centralized priority attribute n...

2015-10-01 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/98 NIFI-1016: Use centralized priority attribute name in PriorityAttributePrioritizer There is a special enum, `CoreAttributes`, containing the core attribute names of a flow file, like `uuid`,`path

[GitHub] nifi pull request: NIFI-988: PutDistributedMapCache processor

2015-10-01 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/92#issuecomment-144703463 I think your answer is related to an other pull request #94 (NIFI-989). Let me share my opinion there, not in this PutDistributedMapCache PR. --- If your project is

[GitHub] nifi pull request: NIFI-988: PutDistributedMapCache processor

2015-09-30 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/92#issuecomment-144332289 @markap14 Did you get a proper answer for your cache related questions? If you do not have any concern with this new processor, it would be reasonable to implement the

[GitHub] nifi pull request: NIFI-988: PutDistributedMapCache processor

2015-09-25 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/92#issuecomment-143226518 I started to implement nifi-tools, including a very simple map cache client. You can find the project on my github page [here](https://github.com/joemeszaros/nifi

[GitHub] nifi pull request: NIFI-995: TestGetFile failed in case of NTFS pa...

2015-09-24 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/95 NIFI-995: TestGetFile failed in case of NTFS partition in Linux I cloned the NiFi source code to local directory on a NTFS partition in Linux, and was surprised, when one of the standard test case

[GitHub] nifi pull request: NIFI-989: Support size() operation in distribut...

2015-09-24 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/94 NIFI-989: Support size() operation in distributed map cache The distributed map cache server is a great tool for caching along with the cache client (DistributedMapCacheClientService), but after

[GitHub] nifi pull request: NIFI-988: PutDistributedMapCache processor

2015-09-24 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/92#issuecomment-142863157 Yes, you are correct. The PutDisributeMapCache processor relies on the existing DistributedMapCacheServer, which internally use

[GitHub] nifi pull request: NIFI-985: Custom log prefix for LogAttribute pr...

2015-09-24 Thread joemeszaros
Github user joemeszaros commented on a diff in the pull request: https://github.com/apache/nifi/pull/90#discussion_r40297509 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LogAttribute.java --- @@ -123,12

[GitHub] nifi pull request: NIFI-988: PutDistributedMapCache processor

2015-09-23 Thread joemeszaros
Github user joemeszaros commented on the pull request: https://github.com/apache/nifi/pull/92#issuecomment-142654373 I have several tracking event files, containing user interactions, e.g. user.x liked item.y in the following format: |UserId | Action | ItemId

[GitHub] nifi pull request: NIFI-988: PutDistributedMapCache processor

2015-09-23 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/92 NIFI-988: PutDistributedMapCache processor There is a standard controller service, called DistributedMapCacheServer, which provides a distributed cache, and an associated

[GitHub] nifi pull request: NIFI-985: Custom log prefix for LogAttribute pr...

2015-09-22 Thread joemeszaros
Github user joemeszaros commented on a diff in the pull request: https://github.com/apache/nifi/pull/90#discussion_r40128133 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LogAttribute.java --- @@ -79,6

[GitHub] nifi pull request: NIFI-985: Custom log prefix for LogAttribute pr...

2015-09-22 Thread joemeszaros
Github user joemeszaros commented on a diff in the pull request: https://github.com/apache/nifi/pull/90#discussion_r40088634 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LogAttribute.java --- @@ -79,6

[GitHub] nifi pull request: NIFI-985: Custom log prefix for LogAttribute pr...

2015-09-22 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/90 NIFI-985: Custom log prefix for LogAttribute processor When you have a data flow with a bunch of LogAttribute processors it is really hard to identify the right LogAttribute processor in the log

[GitHub] nifi pull request: NIFI-984: Bad class used for logging in TestDet...

2015-09-22 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/89 NIFI-984: Bad class used for logging in TestDetectDuplicate Using TestListenUDP instead of TestDetectDuplicate when creating the logger. You can merge this pull request into a Git repository by

[GitHub] nifi pull request: NIFI 945: New property (wrap as array) in avro2...

2015-09-10 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/88 NIFI 945: New property (wrap as array) in avro2json converter Create a new property (wrap as array) in ConvertAvroToJson, which determines how stream of records is exposed: either as a sequence

[GitHub] nifi pull request: New property (wrap as array) in avro2json conve...

2015-09-10 Thread joemeszaros
Github user joemeszaros closed the pull request at: https://github.com/apache/nifi/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI 944: Support tab & special delimiter chars...

2015-09-10 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/87 NIFI 944: Support tab & special delimiter chars in csv2avro converter The original ConvertCSVToAvro implementation was unable to process tab separated files, because "\t" as delim

[GitHub] nifi pull request: Support Tab & special delimiter chars in csv2av...

2015-09-10 Thread joemeszaros
Github user joemeszaros closed the pull request at: https://github.com/apache/nifi/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: New property (wrap as array) in avro2json conve...

2015-09-09 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/85 New property (wrap as array) in avro2json converter Create a new property (wrap as array) in ConvertAvroToJson, which determines how stream of records is exposed: either as a sequence of single

[GitHub] nifi pull request: Support Tab & special delimiter chars in csv2av...

2015-09-09 Thread joemeszaros
GitHub user joemeszaros opened a pull request: https://github.com/apache/nifi/pull/84 Support Tab & special delimiter chars in csv2avro converter The original ConvertCSVToAvro implementation was unable to process tab separated files, because "\t" as delimiter charact