[GitHub] nifi issue #556: NIFI-615 - Create a processor to extract WAV file character...

2016-06-22 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/556 I took @joewitt's comment to mean keeping the combined bundle and documenting that attributes are not stable and could change with version upgrades, which will apply to both bundles if we break them

[GitHub] nifi issue #556: NIFI-615 - Create a processor to extract WAV file character...

2016-06-22 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/556 Just pushed final cleanup, that should be it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #556: NIFI-615 - Create a processor to extract WAV file character...

2016-06-22 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/556 To wrap this up, should I add the failure provenance now or will that be a future change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68076407 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68073301 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68070698 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi issue #556: NIFI-615 - Create a processor to extract WAV file character...

2016-06-22 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/556 @JPercivall and @joewitt, I just pushed the updates. Have at it! * Code review cleanup. - Replace deprecated ProcessorLog with ComponentLog and deprecated ObjectHolder

[GitHub] nifi issue #556: NIFI-615 - Create a processor to extract WAV file character...

2016-06-22 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/556 I'm running contrib check and a functional test now. Should be pushed shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #280: NIFI-1118 Update SplitText Processor - add support for spli...

2016-06-22 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/280 Yes, this should be closed. Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #280: NIFI-1118 Update SplitText Processor - add support f...

2016-06-22 Thread jskora
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68044015 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/test/java/org/apache/nifi/processors/image/ExtractImageMetadataTest.java --- @@ -37,7

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68042865 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68042751 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68042689 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68041847 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r68039891 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-21 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r67965881 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-21 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r67965763 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi pull request #556: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-21 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/556#discussion_r67965642 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,311

[GitHub] nifi issue #556: NIFI-615 - Create a processor to extract WAV file character...

2016-06-21 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/556 I'm not sure why but only the main code commit, 236266c9e4ed89b4c78438f36408b5f6e0b0c488, applies to 1.0/master without problems. The other pom commits do not. It is easy enough to fix them

[GitHub] nifi issue #252: NIFI-615 - Create a processor to extract WAV file character...

2016-06-16 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/252 Ok, I think I've resolved the problems. The Tika conflict was fixed by udpating Tika and Metadata Extractor dependency versions and adjusting ExtractImageMetadata for new attribute names in the newer

[GitHub] nifi issue #252: NIFI-615 - Create a processor to extract WAV file character...

2016-06-16 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/252 Ironically, this boils down to a version dependency conflict between ExtractMediaMetadata which uses Tika 1.7 which uses Drew Noakes' Metadata-Extract 2.6.2 and the existing ExtractImageMetadata which

[GitHub] nifi issue #252: NIFI-615 - Create a processor to extract WAV file character...

2016-06-16 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/252 So, the problems you had with the JPG file are two separate issues. - The default `BodyContentHandler` passed to the parser can only handle 100,000 bytes, so any file larger than that produces

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67393537 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,276

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67387942 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,276

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67387964 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/test/java/org/apache/nifi/processors/media/TestExtractMediaMetadata.java --- @@ -0,0

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67385461 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,276

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67384364 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,276

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67383325 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,276

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-16 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/458 Ok, I think that last commit covers the review feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/458#discussion_r67341980 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java --- @@ -0,0 +1,499

[GitHub] nifi pull request #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/458#discussion_r67335539 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java --- @@ -0,0 +1,499

[GitHub] nifi pull request #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/458#discussion_r67335284 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java --- @@ -0,0 +1,499

[GitHub] nifi issue #252: NIFI-615 - Create a processor to extract WAV file character...

2016-06-15 Thread jskora
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/252 @JPercivall, I'll try to get this updated tomorrow morning. This was originally done in February, but I'm hoping the rebase won't be too bad. --- If your project is set up for it, you can reply

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-15 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67218396 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,276

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-15 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67218355 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,276

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-15 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67218079 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,276

[GitHub] nifi pull request #252: NIFI-615 - Create a processor to extract WAV file ch...

2016-06-15 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/252#discussion_r67215325 --- Diff: nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java --- @@ -0,0 +1,276

[GitHub] nifi pull request #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-01 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/458#discussion_r65487473 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java --- @@ -0,0 +1,414

[GitHub] nifi pull request #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-01 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/458#discussion_r65487334 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java --- @@ -0,0 +1,414

[GitHub] nifi pull request #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-01 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/458#discussion_r65486064 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java --- @@ -0,0 +1,414

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-30 Thread jskora
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/430 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-30 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/430#issuecomment-222580134 This as it was replaced by [Pull Request 478](https://github.com/apache/nifi/pull/478). --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-30 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/478 NIFI-1754 Rollback log messages should include the flowfile filename … …and UUID to assist in flow management. Incorporates debug logging into StandardProcessSession.rollback() to list Flowfile

[GitHub] nifi pull request: NIFI-786 AWS credential refactoring and enhance...

2016-05-23 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/244#issuecomment-221163835 This is really nice, it was great being able to just provide the AWS CLI profile and have setting automatically picked up. Great improvement, thanks James

[GitHub] nifi pull request: NIFI-786 AWS credential refactoring and enhance...

2016-05-20 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/244#issuecomment-220749583 I'm starting to review and test this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/430#discussion_r63405577 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlowDebugger.java --- @@ -0,0 +1,414

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/430#discussion_r63405091 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-14 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/430#discussion_r63279086 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-14 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/430#discussion_r63279016 --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/ProcessSession.java --- @@ -109,6 +109,19 @@ void rollback(boolean penalize

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-14 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/430#discussion_r63277496 --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java --- @@ -21,13 +21,19 @@ public abstract class AbstractProcessor extends

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-14 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/430#discussion_r63277482 --- Diff: nifi-api/pom.xml --- @@ -21,5 +21,12 @@ 0.7.0-SNAPSHOT nifi-api -jar +jar

[GitHub] nifi pull request: NIFI-1754 Rollback log messages should include ...

2016-05-10 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/430 NIFI-1754 Rollback log messages should include the flowfile filename and UUID * Add optional functionality for the Processor framework to maintain a count of flowfile rollbacks in a flowfile

[GitHub] nifi pull request: NIFI-1661 add random() function to expression l...

2016-04-21 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/322#issuecomment-213070365 @ckmcd this has been merged to the 1.0 and 0.x branches. Looks great and works well. I forgot to put "this closes" on the commit, could you please cl

[GitHub] nifi pull request: NIFI-615 - Create a processor to extract WAV fi...

2016-04-19 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/252#issuecomment-211868734 @joewitt On [NIFI-1717|https://issues.apache.org/jira/browse/NIFI-1717] and [NIFI-1718|https://issues.apache.org/jira/browse/NIFI-1718] Dmitry Goldenberg and I discussed

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

2016-04-18 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/238#issuecomment-211711893 I can, but it might not be until later this week. On Mon, Apr 18, 2016 at 11:26 PM, Joe Witt <notificati...@github.com> wrote: > Anyone in a good

[GitHub] nifi pull request: NIFI-1661 add random() function to expression l...

2016-04-17 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/322#issuecomment-211107429 This looks pretty good, but in testing I came across 2 problems that need to be addressed before it can be merged. 1. The example in the [expression language

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

2016-04-11 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/344#issuecomment-208593602 Reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

2016-04-11 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/344#discussion_r59292187 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/KafkaPublisherTest.java --- @@ -124,33 +112,9

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2016-03-20 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/280#discussion_r56322564 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java --- @@ -134,6 +168,28

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2016-03-19 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/280#issuecomment-197388774 I think the issues are all covered now and tests have been expanded to get all critical logic and edge cases. --- If your project is set up for it, you can reply

[GitHub] nifi pull request: NIFI-615 - Create a processor to extract WAV fi...

2016-03-19 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/252#issuecomment-198427593 I don't love all the attribute names, I might have come up with a cleaner taxonomy myself. But, letting Tika handle it leverages the work done on another active Apache

[GitHub] nifi pull request: NIFI-615 - Create a processor to extract WAV fi...

2016-03-19 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/252#issuecomment-198408663 @joewitt, the attribute names are created by Tika and seem to be based on the source file types. The core Tika module was already in the project and the Tika parsers

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2016-03-15 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/280 NIFI-1118 Update SplitText Processor - add support for split size limits and header line markers. * Add "Maximum Fragment Size" property. A new split file will be created if the

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2016-03-15 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/135#issuecomment-196847105 Cancelling this pull request, will followup with new PR for updated and current source branch. --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2016-03-15 Thread jskora
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-615 - Create a processor to extract WAV fi...

2016-02-29 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/252 NIFI-615 - Create a processor to extract WAV file characteristics. * Created new ExtractMediaMetadata processor using Apache Tika Detector and Parser. * Refactored nifi-image-bundle, nifi-image

[GitHub] nifi pull request: NIFI-840: Create ListS3 processor

2016-02-22 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/238#discussion_r53674055 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java --- @@ -0,0 +1,230

[GitHub] nifi pull request: NIFI-1545 Update AWS S3 IT tests for new proxy ...

2016-02-22 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/243 NIFI-1545 Update AWS S3 IT tests for new proxy properties Adjust integration tests ITDeleteS3Object, ITFetchS3Object, and ITPutS3Object to account for AWS new proxy properties. Correct typo

[GitHub] nifi pull request: Added support for using proxy for aws processor...

2016-02-09 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/209#discussion_r52362955 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java --- @@ -161,6 +180,12

[GitHub] nifi pull request: NIFI-1107 Multipart Uploads

2016-01-31 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/192#issuecomment-177583468 @joewitt I've been trying to get the multipart upload in for a while, my preference would be to incorporate the multipart as is and then update

[GitHub] nifi pull request: NIFI-1107 Multipart Uploads

2016-01-31 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/192#issuecomment-177570291 Just pushed commit that - cleans up property description, - validates that upload still exists in S3 before resuming from local state, and - verifies local

[GitHub] nifi pull request: NIFI-1193: Add support for storing data in Hive...

2016-01-28 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/147#issuecomment-176331346 I can also build master successfully now. Interestingly, it downloaded the hive-serde jar file from the Cloudera repository. Not sure why it didn't do

[GitHub] nifi pull request: NIFI-1107 Multipart Uploads

2016-01-27 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/192 NIFI-1107 Multipart Uploads Re-integrate Multipart Upload changes into PutS3Object. 1. add Multipart upload logic to allow resuming an upload after process/instance restart, 2. add local state

[GitHub] nifi pull request: NIFI-1107 - Integrate Multipart uploads into th...

2016-01-06 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/132#issuecomment-169329852 I'm closing this pull request since the general S3 changes have been incorporated by @trkurc. The remaining Multipart Upload functionality will be incorporated into a new

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2016-01-04 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/135#issuecomment-168806914 I just pushed changes that address these issues, including tests for these and a couple more edge conditions. It has been squashed (thanks @trkurc) into a single commit

[GitHub] nifi pull request: NIFI-1300 - Penalize flowfiles when message sen...

2015-12-17 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/145 NIFI-1300 - Penalize flowfiles when message send or commit exceptions occur and m… …ake commit exception handler route to failure instead of rolling back. Moved producer queue creation

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2015-12-01 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/135 NIFI-1118 Update SplitText Processor - add support for split size lim… …its and header line markers. 1) Add "Maximum Fragment Size" property. A new split file will be created i

[GitHub] nifi pull request: Nifi 631

2015-11-25 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/113#issuecomment-159769035 Closed by commit 226ac64ef95f3d755dfbb3d5288ba98052855473 and 4c4d62c61f7c828dbcb124090992b91d631cb22e. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request: Nifi 631

2015-11-25 Thread jskora
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1107 - Integrate Multipart uploads into th...

2015-11-24 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/132 NIFI-1107 - Integrate Multipart uploads into the PutS3Object processor. * Add nifi-ssl-context-service-nar to nifi-aws-nar pom. * Add nifi-ssl-context-service-api to nifi-aws-processors pom

[GitHub] nifi pull request: NIFI-1123 Adds expression language support to D...

2015-11-18 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/116#issuecomment-157970085 Do you need me to close the pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request: NIFI-1123 Adds expression language support to D...

2015-11-17 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/116#issuecomment-157484556 @apiri, the property value is compiled as a regex, any separators are in the context of the regex. I'm not sure I understand how the RegexValidator can evaluate

[GitHub] nifi pull request: NIFI-1123 Adds expression language support to D...

2015-11-17 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/116#issuecomment-157510163 @apiri, that makes sense regarding the framework. But, in the meantime, it would be an easy patch to add an exclusion list to UpdateAttributes to prevent the deletes

[GitHub] nifi pull request: NIFI-1107 - Create new PutS3ObjectMultipart pro...

2015-11-16 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/121#discussion_r44967382 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3ObjectMultipart.java --- @@ -0,0 +1,550

[GitHub] nifi pull request: NIFI-1123 Adds expression language support to D...

2015-11-16 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/116#issuecomment-157265254 Interesting. Before I enabled EL support, it had a REGULAR_EXPRESSION_VALIDATOR which would have caught those. Is there a way to validate a property that supports

[GitHub] nifi pull request: NIFI-1123 Adds expression language support to D...

2015-11-16 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/116#issuecomment-157272302 @trkurc, this is not a problem fix but an enhancement based on discussion that occurred on [NIFI-641|https://issues.apache.org/jira/browse/NIFI-641]. It seemed easy

[GitHub] nifi pull request: NIFI-1107 - Create new PutS3ObjectMultipart pro...

2015-11-12 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/121#discussion_r44714959 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3ObjectMultipart.java --- @@ -0,0 +1,550

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43743095 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43743209 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43744029 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43811658 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43822421 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread jskora
Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43823110 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: NIFI-631 Create ListFile and FetchFile processo...

2015-10-31 Thread jskora
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: New ListFile processor.

2015-10-29 Thread jskora
GitHub user jskora reopened a pull request: https://github.com/apache/nifi/pull/112 New ListFile processor. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-631 Alternatively you can review and apply

[GitHub] nifi pull request: New ListFile processor.

2015-10-29 Thread jskora
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/112 New ListFile processor. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-631 Alternatively you can review and apply these changes