Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/116#issuecomment-157452951
Yikes! @apiri the fact that the uuid attribute can be removed is a bug. I
created a ticket for this: https://issues.apache.org/jira/browse/NIFI-1182
I do agree
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/125#issuecomment-157140757
@naveenmadhire no trouble at all :) Looking forward to the new pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/127#issuecomment-157179517
@naveenmadhire - code looks good. Builds without problem, and testing on my
Kafka instance shows the expected results. Nice work! And thanks for the
contribution
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/123#issuecomment-157182575
@trkurc Personally, I have exactly 0 qualms about changing it to package
private. If I choose to take some random util class from a release of Apache
Tomcat
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/125#issuecomment-156770044
Naveen, thanks for contributing this back! Certainly a nice addition to the
GetKafka processor. The patch looks good, but I did have just a couple of small
points
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44422933
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -152,7 +152,8 @@ language governing permissions and limitations under
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421141
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -152,7 +152,8 @@ language governing permissions and limitations under
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421276
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetJMSQueue.java
---
@@ -24,73
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421520
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetJMSQueue.java
---
@@ -24,73
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/118#discussion_r44421395
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetJMSQueue.java
---
@@ -24,73
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/94#issuecomment-144783629
@joemeszaros the concern that I have with the notion of the
ExtendedDistributedMapCacheClient is that once that is released, it will have
the same caveats
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/92#issuecomment-144378199
@joemeszaros the concern that I have with the notion of the
ExtendedDistributedMapCacheClient is that once that is released, it will have
the same caveats
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/92#issuecomment-142647457
@joemeszaros Can you explain the use case here a little bit more? The
DistributedMapCache services were originally developed in order to be used in
the DetectDuplicate
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/92#issuecomment-142689586
OK so to make sure that I am understanding the use case. The idea is just
to use this processor to put data into this cache, so that other custom
processors can access
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/76#discussion_r37697819
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/OpenPGPKeyBasedEncryptor.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/76#discussion_r37697905
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/OpenPGPKeyBasedEncryptor.java
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/71#issuecomment-130315725
Ugh, sorry, @taftster you are absolutely right - in my head, I was thinking
that the @OnScheduled was creating a new HashMap each time, rather than
clearing on @OnStopped
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/71#discussion_r35453740
--- Diff:
nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/71#discussion_r35453796
--- Diff:
nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/71#issuecomment-124630695
No problem. Glad to have you jumping in on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/71#discussion_r35454101
--- Diff:
nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java
301 - 321 of 321 matches
Mail list logo
