Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/458
I don't mind even a little! Thanks @mosermw
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/458
It looks like the issues I had were addressed, but I won't have a chance to
dive in deeper until Saturday, maybe
---
If your project is set up for it, you can reply to this email and have your
Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/458
Not until this weekend
On Jun 15, 2016 4:30 PM, "Joe Percivall" wrote:
> @jskora <https://github.com/jskora> rebased and addressed comments,
> @trkurc <https
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/479#discussion_r66706187
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java
---
@@ -197,6 +198,30
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/479#discussion_r66699726
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java
---
@@ -197,6 +198,30
Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/480
@JPercivall - I'm +1 on this. Would you like to merge it in, or prefer I do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/479
I'll review this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/480
I will start reviewing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/478
looks good. if you don't mind, I'll amend the commit and throw a static on
that constant before pushing
---
If your project is set up for it, you can reply to this email and have
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/478#discussion_r65299383
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/458#discussion_r65234934
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java
---
@@ -0,0 +1,414
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/458#discussion_r65231483
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java
---
@@ -0,0 +1,414
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/458#discussion_r65231261
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java
---
@@ -0,0 +1,414
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/458#discussion_r65230520
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java
---
@@ -0,0 +1,414
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/458#discussion_r65230431
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java
---
@@ -0,0 +1,414
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/458
reviewing this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/478#discussion_r65223758
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/478#discussion_r65219394
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/478#discussion_r65196703
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/478
I've started reviewing this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/248#discussion_r64084293
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
---
@@ -111,8
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/418#issuecomment-217584745
@apiri - would you like to merge, or shall I?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/418#issuecomment-217584460
+1 - looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/305#issuecomment-202406795
@olegz - if you work out the intellij problems, try to ensure what the fix
was is memorialized on the wiki or dev list
---
If your project is set up for it, you can
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/292#issuecomment-199137191
Thanks for following up, @pvillard31 . I think maybe building with other
default locales may be worth exploring to add to travis-ci (tagging @apiri who
may know if that&#
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/292#issuecomment-199051348
@pvillard31 - can you try this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/292
NIFI-1656 Added locale support to ConvertAvroSchema and fixed locale â¦
â¦problems in unit tests
See:
https://issues.apache.org/jira/browse/NIFI-1656
You can merge this pull request into a
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198997621
So, likely needs a processor change to add a default locale and some
ability to override it
---
If your project is set up for it, you can reply to this email and have
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198986806
@pvillard31 - I was able to replicate the errors in the txt file you
included by adding \r's to the file (windows line endings). The other errors
are on tests that ha
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198971642
Did you clone the code with autocrlf? Does the schema in src/test/resources
have line endings?
---
If your project is set up for it, you can reply to this email and have
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/291#issuecomment-198969736
Pierre, what environment are you running on?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-197323770
@olegz: A sample app would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56596211
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java
---
@@ -0,0 +1,448
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-197617908
@olegz : checkstyle fails when I build with your latest commit
``
[INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @
nifi-spring-processors
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-198171253
@olegz, I think @joewitt is still looking, but I think the code looks good,
I put it through the paces using several applications. I'm +1
---
If your project is s
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/291
NIFI-1651 unit tests work on windows. removed contributor name/package from
data and schema
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-198134497
@olegz - there are a bunch of trailing whitespace and whitespace on blank
lines in the xml and properties files. checkstyle doesn't complain as it checks
the java
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56447125
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java
---
@@ -0,0 +1,392
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56440539
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java
---
@@ -0,0 +1,392
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/271#issuecomment-197119997
@oleg: changes look good. do you have a recommendation for building a
sample "application" for testing other than adapting what is in the unit tests?
---
If yo
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/278#issuecomment-197021816
This makes shutdown work in cywin, but not for the right reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user trkurc closed the pull request at:
https://github.com/apache/nifi/pull/278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/278#discussion_r56214991
--- Diff:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -1131,6 +1135,22 @@ public void run() {
this.loggingFutures
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/278
NIFI-1047 Added additional method to get processId, fixed tools.jar path
for cygwin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trkurc/nifi
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/276#issuecomment-196619738
whoa, something went screwy when I merged this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user trkurc closed the pull request at:
https://github.com/apache/nifi/pull/276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/277
NIFI-1481 fixed a couple bugs in bash script for cygwin and when JAVA_HOME
not set
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trkurc/nifi
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56105950
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/bootstrap/SpringContextDelegate.java
---
@@ -0,0
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56105879
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/resources/docs/org.apache.nifi.spring.SpringContextProcessor/additionalDetails.html
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56104556
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextFactory.java
---
@@ -0,0 +1,139
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56104123
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextFactory.java
---
@@ -0,0 +1,139
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56103351
--- Diff:
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/resources/docs/org.apache.nifi.spring.SpringContextProcessor/additionalDetails.html
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/271#discussion_r56102458
--- Diff: nifi-nar-bundles/pom.xml ---
@@ -54,7 +54,8 @@
nifi-scripting-bundle
nifi-elasticsearch-bundle
nifi-amqp-bundle
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/276
NIFI-1047 Added additional method to get processId, fixed tools.jar path
for cygwin
Uses ugly internal classes, but works on windows
You can merge this pull request into a Git repository by running
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-196564618
So, after discussion with @apiri, we removed the env batch script because
it did not work due to limitations of bootstrap, and reworked nifi.sh to build
the classpath for
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-196400346
@apiri - I tried last night to get the pid to get Windows to work. I could
not. I say we shelve the env batch script (remove it for now from the patch
set).
On
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-196112326
@apiri - I attached a patch to the ticket, which should be the last two
commits off my branch https://github.com/trkurc/nifi/commits/NIFI-1481
---
If your project is set
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-196104511
@apiri: how would you think it best to review the changes I made based on
your reviews? Another PR? A patch on the ticket?
---
If your project is set up for it, you can
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-196092752
@apiri - cygwin is proving to be a challenge, and not necessarily due to
the changes in this patch.
On my setup, the ':' separator on this line seem
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-196080641
After an out of band discussion with @markap14, seems that windows pids
might be challenging to get, so maybe we should leave the Windows env batch
script out for 0.6.0
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-195862994
Also, @jvwing I fixed that misspelling of unknown when I was hacking on
RunNiFi
---
If your project is set up for it, you can reply to this email and have your
reply
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-195862019
(See the section labeled "Processing quotation marks ". ). So bizarre.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-195861949
@PuspenduBanerjee sadly, no, no it is not.
https://technet.microsoft.com/en-us/library/bb490880.aspx
---
If your project is set up for it, you can reply to this email and
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-195861254
push my changes up to a fork, in case anyone was interested
(https://github.com/trkurc/nifi/commit/5ebf228a9ba5c5ce9f12189988920f94923e6210
from https://github.com/trkurc
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-195861175
The pid is not being recorded in the nifi.pid file after I run RunNiFi with
start or run, haven't been able to diagnose why yet. @markap14 may have an idea.
---
If
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-195861132
I discovered the same issue with the pid on windows 10. My fix was to use
quotes a bit differently on the cmd.exe line (cmd.exe /C ""%JAVA_EXE%"
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-195342717
@apiri @PuspenduBanerjee I can take a whack at those windows fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/235#issuecomment-195092832
@JPercivall - code looks good, just need to contrib-check, do some quick
manual testing and merge
---
If your project is set up for it, you can reply to this email and
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/218#issuecomment-187771732
I looked it over and gave it a try, I don't have any substantive comments
yet, this was queued behind getting 0.5.1 out. I think this is a good candidate
for
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/240#issuecomment-186926703
Will start reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/235#discussion_r53414564
--- Diff:
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestInferAvroSchema.java
---
@@ -51,6 +51,7
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/235#issuecomment-185679941
reviewing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/234#issuecomment-185541846
applies clean to support/nifi-0.5.x and master. running through a test
release:prepare and release:perform to verify correct behavior with those
plugins
---
If your
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/234#issuecomment-185538294
reviewing now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/222#discussion_r53268977
--- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/.gitignore
---
@@ -0,0 +1 @@
+/lib/
--- End diff --
why is this necessary
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/225#issuecomment-185514088
reviewing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/227#issuecomment-185507765
reviewing now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/226#issuecomment-185507421
Merged in! Thanks for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/226#issuecomment-184679651
I will review this one!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/218#discussion_r52849296
--- Diff: nifi-bootstrap/pom.xml ---
@@ -41,5 +41,12 @@
org.apache.nifi
nifi-expression-language
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/221#discussion_r52837465
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java
---
@@ -426,60 +423,65
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/221
NIFI-1513: fixed some easy to fix errors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trkurc/nifi NIFI-1513
Alternatively you can review and
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/206#issuecomment-181135049
I'll merge this one in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/208#issuecomment-181134203
+1 I will merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user trkurc opened a pull request:
https://github.com/apache/nifi/pull/207
NIFI-1485: Updated 'header' section of NiFi NOTICE files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trkurc/nifi NIFI-1485
Alterna
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/206#issuecomment-180928291
@apiri - +1, works great. Only bit of weirdness, if the old state file was
chmod 0400'ed (i.e., only read access) when I launched nifi, it was still
deleted
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/206#issuecomment-180922873
logic looks like it should cover all conditions, tests are reasonable,
doing some tests
---
If your project is set up for it, you can reply to this email and have your
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/204#issuecomment-180323145
@PuspenduBanerjee - yes, I started reviewing, but realized I needed an
assist. added comments to the jira.
---
If your project is set up for it, you can reply to this
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/202#issuecomment-179579922
@taftster - code readability is subjective, I prefer actually prefer what
is in the PR. The String.format makes it an order of magnitude slower based on
my initial tests
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/202#issuecomment-179413462
@PuspenduBanerjee - not missing anything, I should be able to merge in your
patch tonight
---
If your project is set up for it, you can reply to this email and have your
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/202#issuecomment-179209898
I am not able to verify right now (no compiler at hand), but I like this
approach. Do you plan to update the PR?
---
If your project is set up for it, you can reply to
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/202#issuecomment-178965345
> But, do you think that should be accounted against the manageability of
the method in context of the provided test scenario?
I'm not sure I'm follo
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/202#issuecomment-178942251
I did a quick experiment (code below), generated a 10^20 "UUID"'s using a
few mechanisms
1. as you did in this pr (~120ms)
2. an slightly diffe
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/202#issuecomment-178872670
Reviewing now. Anything that makes tests faster makes me happy!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/192#issuecomment-177524368
Think I found an edge case - I believe I successfully aborted an upload,
i.e., I had an upload half done, stopped the processor, flushed the queue,
waited, then sent a
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/192#issuecomment-177515367
Did a pretty thorough test, testing weird combinations of parameters,
stopping and clearing the queue. The only real issue I ran into was with a new
nifi instance having
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/192#discussion_r51361382
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
---
@@ -89,9 +134,51
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/192#discussion_r51360885
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
---
@@ -118,6 +210,75
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/192#issuecomment-176546251
having trouble with my aws account - pretty much gone through the code,
just trying to finish tests
---
If your project is set up for it, you can reply to this email and
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/192#issuecomment-176290087
started reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
1 - 100 of 212 matches
Mail list logo
