Re: [DISCUSS] NiFi and Java 11

2019-04-05 Thread Jeff
Good idea Andy. I use the community edition of Intellij IDEA (currently 2019.1), and I have the project's SDK set to Java 11. I have Intellij IDEA configured to use an external installation of Maven (3.5.4, installed via homebrew) and when building with Maven in Intellij IDEA, Maven uses the

Re: [DISCUSS] NiFi and Java 11

2019-04-04 Thread Kevin Doran
Jeff, Thanks for all your work on this and for explaining the path forward. I also support this proposal. I suggest we take the same basic approach for NiFi Registry. That is: - For the current NiFi Registry 0.x line, we maintain Java 8 and 11 build compatibility - We perform Java 8 builds

Re: [DISCUSS] NiFi and Java 11

2019-04-04 Thread Matt Gilman
Jeff, I think this is a great approach that should help us transition to and in the long run, adopt Java 11. The staggered approach should allow us to address concerns and any issues we may encounter as we go over time. Thanks for putting these together! Matt On Thu, Apr 4, 2019 at 2:19 AM

Re: [DISCUSS] NiFi and Java 11

2019-04-04 Thread Jeff
I created a JIRA [1] to track the developer documentation changes. Andy, thanks for pointing out the specific links; I've added them to the JIRA. [1] https://issues.apache.org/jira/browse/NIFI-6187 On Wed, Apr 3, 2019 at 11:23 PM Sivaprasanna wrote: > Yep. Adding to GitHub template is a great

Re: [DISCUSS] NiFi and Java 11

2019-04-03 Thread Sivaprasanna
Yep. Adding to GitHub template is a great idea. On Thu, 4 Apr 2019 at 5:27 AM, Andy LoPresto wrote: > We should add that to the Developer Guide [1], Contributor Guide [2], note > it in the Migration Guide [3] when it takes effect, and include it in the > GitHub PR template as well. > > [1]

Re: [DISCUSS] NiFi and Java 11

2019-04-03 Thread Andy LoPresto
We should add that to the Developer Guide [1], Contributor Guide [2], note it in the Migration Guide [3] when it takes effect, and include it in the GitHub PR template as well. [1] https://nifi.apache.org/docs/nifi-docs/html/developer-guide.html

Re: [DISCUSS] NiFi and Java 11

2019-04-03 Thread Sivaprasanna
Sounds good to me. So contributors who bring in new changes are expected to write the code that should be compatible with both Java 8 as well as Java 11, right? Do we see anything that we should have in our site that would help the contributors/users with this change? Something like a document

Re: [DISCUSS] NiFi and Java 11

2019-04-03 Thread Pierre Villard
Sounds good to me as well. Given the latest news on Java 8, having the 2 PRs merged in would be great! Thanks, Pierre Le mer. 3 avr. 2019 à 20:34, Joe Witt a écrit : > Jeff > > This seems very reasonable and thorough to me. > > The only short term implication that we'd have to buy into then is

Re: [DISCUSS] NiFi and Java 11

2019-04-03 Thread Joe Witt
Jeff This seems very reasonable and thorough to me. The only short term implication that we'd have to buy into then is that PRs going forward need to be able to build on both Java 8 and 11 which seems a very fair way to bridge toward moving to Java 11 as the base requirement in the next major

[DISCUSS] NiFi and Java 11

2019-04-03 Thread Jeff
I'm reaching out to the community today to propose a plan for moving forward with NiFi on Java 11. There are currently two PRs that deal with Java 11 compatibility. The first PR allows NiFi built on Java 8 to be run on Java 11 [1]. The second PR allows NiFi to be built on Java 11 and run on